fix: fallback to localized currency symbol when list symbol is code-like by thedavos · Pull Request #78157 · Expensify/App

thedavos · 2025-12-19T19:25:47Z

Explanation of Change

This PR standardizes the currency prefix shown in the Create expense amount input.

If the currency has a real symbol in CURRENCY_LIST (e.g. $, €, £), we render that symbol as the prefix.
If the CURRENCY_LIST “symbol” is effectively just the currency code (code-like), we fallback to the localized currency output (existing Intl-based approach) instead of rendering the raw code.
This avoids showing raw currency codes when we can show localized values, and makes the Create expense input more consistent across currencies.

Fixed Issues

$ #75709
PROPOSAL: #75709 (comment)

Tests

Go to the app
Open any chat/report.
Click Create expense.
Change the currency a few times.
Verify the amount input prefix:
5.1. Shows a real symbol when available.
5.2. Falls back to localized currency output when the stored “symbol” is code-like.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Screen.Recording.2025-12-19.at.1.58.24.PM.mov

github-actions · 2025-12-19T19:25:58Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

thedavos · 2025-12-19T19:31:18Z

I have read the CLA Document and I hereby sign the CLA

Copilot

Pull request overview

This PR improves the currency symbol display in the Create expense amount input by implementing a smart fallback mechanism. When a currency's symbol in CURRENCY_LIST is just the currency code itself (e.g., "TZS"), the system now falls back to using the localized Intl-based currency symbol instead of showing the raw code.

Key changes:

Added isCurrencyCodeLikeSymbol() function to detect when a symbol is effectively just the currency code
Added getPreferredCurrencySymbol() function that chooses between the list symbol and localized symbol
Updated MoneyRequestAmountInput component to use the new preferred symbol logic

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
src/libs/CurrencyUtils.ts	Adds helper functions `isCurrencyCodeLikeSymbol` and `getPreferredCurrencySymbol` to intelligently select currency symbols
src/components/MoneyRequestAmountInput.tsx	Updates the amount input to use `getPreferredCurrencySymbol` instead of `getLocalizedCurrencySymbol` for better symbol display
tests/unit/CurrencyUtilsTest.ts	Adds comprehensive test coverage for the new currency symbol selection logic

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-19T19:31:36Z

+            [undefined, 'USD', false],
+            ['USD', undefined, false],
+            [undefined, undefined, false],
+        ])('Returns %s for symbol=%s, currencyCode=%s', (symbol, currencyCode, expected) => {


The test description template has the parameters in the wrong order. With test.each parameters [symbol, currencyCode, expected], the current template "Returns %s for symbol=%s, currencyCode=%s" will produce misleading output like "Returns true for symbol=USD, currencyCode=USD" (where the first value is actually 'expected', not 'symbol'). The template should be reordered to match the parameter order, such as "symbol=%s, currencyCode=%s returns %s".

Suggested change

])('Returns %s for symbol=%s, currencyCode=%s', (symbol, currencyCode, expected) => {

])('symbol=%s, currencyCode=%s returns %s', (symbol, currencyCode, expected) => {

Copilot · 2025-12-19T19:31:37Z

@@ -209,6 +209,35 @@ function sanitizeCurrencyCode(currencyCode: string): string {
    return isValidCurrencyCode(currencyCode) ? currencyCode : CONST.CURRENCY.USD;
 }

+/**
+ * Checks if a "symbol" is effectively just the ISO currency code (e.g. "CLP").


The example in the comment uses "CLP" but this is misleading. Looking at the currency list, CLP actually has "Ch$" as its symbol, not "CLP". A more accurate example would be a currency that truly has a code-like symbol, such as "TZS" (Tanzanian Shilling, which has "TZS" as its symbol).

Suggested change

* Checks if a "symbol" is effectively just the ISO currency code (e.g. "CLP").

* Checks if a "symbol" is effectively just the ISO currency code (e.g. "TZS").

parasharrajat · 2025-12-20T16:52:29Z

Screenshots

🔲 iOS / native

20.12.2025_22.36.21_REC.mp4

🔲 iOS / Safari

20.12.2025_22.37.53_REC.mp4

🔲 MacOS / Chrome

20.12.2025_22.20.03_REC.mp4

🔲 Android / Chrome

🔲 Android / native

20.12.2025_22.47.42_REC.mp4

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

parasharrajat · 2025-12-21T16:44:26Z

@mountiny Ready for review.

mountiny · 2025-12-21T22:16:07Z

@thedavos Prettier is failing

codecov · 2025-12-21T22:21:49Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/CurrencyUtils.ts	`89.04% <100.00%> (+2.15%)`	⬆️
src/components/MoneyRequestAmountInput.tsx	`1.92% <0.00%> (ø)`
... and 6 files with indirect coverage changes

thedavos · 2025-12-21T22:41:33Z

@thedavos Prettier is failing

Okey, it should be okey now

mountiny

@thedavos one question

mountiny

Thanks

github-actions · 2025-12-29T00:32:15Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

parasharrajat · 2025-12-29T04:17:10Z

Please don't use force push prefer merge commits.

thedavos · 2025-12-29T07:13:28Z

Please don't use force push prefer merge commits.

Thanks for the note. I used a force-push only to fix an accidentally polluted branch/PR diff. Going forward I’ll avoid force-push and will use merge commits to update the branch. If you’d prefer, I can open a fresh PR from a clean branch and close this one

mountiny

@thedavos One last thing please can you add unit tests for the helper method

thedavos · 2025-12-29T14:32:14Z

@thedavos One last thing please can you add unit tests for the helper method

Sure, i’ll add unit tests covering isCurrencyCodeLikeSymbol and update the PR shortly.

thedavos · 2025-12-29T14:54:57Z

@mountiny Added direct unit tests for isCurrencyCodeLikeSymbol, please take another look

parasharrajat · 2025-12-29T16:23:40Z

                numberFormRef.current = newRef;
            }}
-            symbol={getLocalizedCurrencySymbol(preferredLocale, currency) ?? ''}
+            symbol={getPreferredCurrencySymbol(currency) ?? ''}


You need to pass preferredLocale

Refactor getPreferredCurrencySymbol function to pass that.

It's done, i’m now passing preferredLocale into getPreferredCurrencySymbol and updated the unit tests accordingly.

…te tests

mountiny · 2025-12-30T11:44:44Z

@thedavos Prettier is failing, can you merge main and run prettier please?

github-actions · 2025-12-30T12:13:51Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-12-30T12:19:14Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #78157.

Android 🤖	iOS 🍎
❌ FAILED ❌	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-3a474a5-e6451c2216b38d672fd52d5435090e9ae296c751/index.html
The QR code can't be generated, because the Android build failed

Desktop 💻	Web 🕸️
⏩ SKIPPED ⏩	❌ FAILED ❌
The build for Desktop was skipped	The QR code can't be generated, because the Web build failed

👀 View the workflow run that generated this build 👀

…ency-symbol-fallback

thedavos · 2025-12-30T14:42:20Z

@thedavos Prettier is failing, can you merge main and run prettier please?

hi, prettier done and updated with main

mountiny

Thanks

OSBotify · 2025-12-30T22:30:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-31T19:02:43Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.90-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-02T10:34:46Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.90-2 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Copilot AI review requested due to automatic review settings December 19, 2025 19:25

thedavos requested review from a team as code owners December 19, 2025 19:25

melvin-bot Bot assigned thedavos Dec 19, 2025

melvin-bot Bot requested review from joekaufmanexpensify, mountiny and parasharrajat December 19, 2025 19:25

Copilot started reviewing on behalf of thedavos December 19, 2025 19:26 View session

thedavos mentioned this pull request Dec 19, 2025

[Due for payment 2026-01-09] [$250] Create expense - Some currencies show the name and some show the currency signs before entering the amount #75709

Closed

16 tasks

CLABotify added a commit to Expensify/CLA that referenced this pull request Dec 19, 2025

@thedavos has signed the CLA in Expensify/App#78157

8838cf0

Copilot AI reviewed Dec 19, 2025

View reviewed changes

joekaufmanexpensify previously approved these changes Dec 19, 2025

View reviewed changes

parasharrajat suggested changes Dec 20, 2025

View reviewed changes

Comment thread src/libs/CurrencyUtils.ts

thedavos dismissed joekaufmanexpensify’s stale review via 0b6073c December 20, 2025 23:46

thedavos requested a review from parasharrajat December 20, 2025 23:48

parasharrajat approved these changes Dec 21, 2025

View reviewed changes

mountiny marked this pull request as draft December 21, 2025 22:13

mountiny marked this pull request as ready for review December 21, 2025 22:13

mountiny reviewed Dec 22, 2025

View reviewed changes

Comment thread tests/unit/CurrencyUtilsTest.ts

mountiny previously approved these changes Dec 22, 2025

View reviewed changes

thedavos dismissed mountiny’s stale review via 7a11f5c December 29, 2025 00:32

thedavos requested a review from a team as a code owner December 29, 2025 00:32

thedavos added 4 commits December 28, 2025 22:28

test: clarify code-like currency symbol checks

b8a41ba

test: cover code-like symbol fallback via getPreferredCurrencySymbol

c27ba13

chore: formatted code with Prettier

d058211

refactor: updated with localize

5362fb2

thedavos force-pushed the thedavos-75709-currency-symbol-fallback branch from 7a11f5c to 5362fb2 Compare December 29, 2025 03:32

mountiny reviewed Dec 29, 2025

View reviewed changes

Comment thread src/libs/CurrencyUtils.ts

test: add unit tests for isCurrencyCodeLikeSymbol helper

5918774

chore: applied prettier for isCurrencyCodeLikeSymbol test

482cbd8

parasharrajat reviewed Dec 29, 2025

View reviewed changes

refactor: pass preferredLocale to getPreferredCurrencySymbol and upda…

cae473d

…te tests

parasharrajat approved these changes Dec 30, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny December 30, 2025 08:18

thedavos added 2 commits December 30, 2025 09:37

Merge remote-tracking branch 'upstream/main' into thedavos-75709-curr…

54cf2a0

…ency-symbol-fallback

chore: executed prettier on currency utils

a9462bf

mountiny approved these changes Dec 30, 2025

View reviewed changes

mountiny merged commit 22eca78 into Expensify:main Dec 30, 2025
30 checks passed

OSBotify mentioned this pull request Dec 31, 2025

Deploy Checklist: New Expensify 2025-12-31 #78646

Closed

28 tasks

shubham1206agra mentioned this pull request Jan 1, 2026

[CP Staging] Revert "fix: fallback to localized currency symbol when list symbol is code-like" #78746

Merged

tgolen mentioned this pull request Jan 1, 2026

Expense- Currency is different in create and confirm page for ETB expenses #78739

Closed

7 tasks

	])('Returns %s for symbol=%s, currencyCode=%s', (symbol, currencyCode, expected) => {
	])('symbol=%s, currencyCode=%s returns %s', (symbol, currencyCode, expected) => {

	* Checks if a "symbol" is effectively just the ISO currency code (e.g. "CLP").
	* Checks if a "symbol" is effectively just the ISO currency code (e.g. "TZS").

Conversation

thedavos commented Dec 19, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thedavos commented Dec 19, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

parasharrajat commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

Uh oh!

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Uh oh!

parasharrajat commented Dec 21, 2025

Uh oh!

mountiny commented Dec 21, 2025

Uh oh!

codecov Bot commented Dec 21, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

thedavos commented Dec 21, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Dec 29, 2025

Uh oh!

parasharrajat commented Dec 29, 2025

Uh oh!

thedavos commented Dec 29, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thedavos commented Dec 29, 2025

Uh oh!

thedavos commented Dec 29, 2025

Uh oh!

parasharrajat Dec 29, 2025

Choose a reason for hiding this comment

Uh oh!

parasharrajat Dec 29, 2025

Choose a reason for hiding this comment

Uh oh!

thedavos Dec 29, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Dec 19, 2025 •

edited

Loading

parasharrajat commented Dec 20, 2025 •

edited

Loading

codecov Bot commented Dec 21, 2025 •

edited by github-actions Bot

Loading