Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hooks/useAssignCard.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ import {getEmptyObject} from '@src/types/utils/EmptyObject';
import type {CombinedCardFeed} from './useCardFeeds';
import useCardFeeds from './useCardFeeds';
import useCardsList from './useCardsList';
import usePolicy from './usePolicy';
import useIsAllowedToIssueCompanyCard from './useIsAllowedToIssueCompanyCard';
import useNetwork from './useNetwork';
import useOnyx from './useOnyx';
import usePolicy from './usePolicy';

type UseAssignCardProps = {
selectedFeed: CompanyCardFeedWithDomainID | undefined;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ import useLocalize from '@hooks/useLocalize';
import useNetwork from '@hooks/useNetwork';
import useOnyx from '@hooks/useOnyx';
import usePermissions from '@hooks/usePermissions';
import useResponsiveLayout from '@hooks/useResponsiveLayout';
import usePolicy from '@hooks/usePolicy';
import useResponsiveLayout from '@hooks/useResponsiveLayout';
import useThemeStyles from '@hooks/useThemeStyles';
import {getCompanyCardFeed, getCompanyFeeds, getDomainOrWorkspaceAccountID, getSelectedFeed} from '@libs/CardUtils';
import type {PlatformStackScreenProps} from '@libs/Navigation/PlatformStackNavigation/types';
Expand Down
12 changes: 8 additions & 4 deletions src/pages/workspace/companyCards/assignCard/ConfirmationStep.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ function ConfirmationStep({route}: ConfirmationStepProps) {
const policyID = route.params.policyID;
const feed = route.params.feed as CompanyCardFeedWithDomainID;
const cardID = route.params.cardID;
const backTo = route.params?.backTo;
const {translate} = useLocalize();
const styles = useThemeStyles();
const {isOffline} = useNetwork();
Expand Down Expand Up @@ -64,9 +65,12 @@ function ConfirmationStep({route}: ConfirmationStepProps) {
}

Navigation.dismissModal();
if (backTo) {
Navigation.navigate(backTo);
}
// eslint-disable-next-line @typescript-eslint/no-deprecated
InteractionManager.runAfterInteractions(() => clearAssignCardStepAndData());
}, [assignCard?.isAssignmentFinished]);
}, [assignCard?.isAssignmentFinished, backTo]);

const submit = () => {
if (!policyID) {
Expand All @@ -85,7 +89,6 @@ function ConfirmationStep({route}: ConfirmationStepProps) {
},
});
}
// For expired feeds, navigate to the old ASSIGN_CARD route which handles these special cases
Navigation.navigate(ROUTES.WORKSPACE_COMPANY_CARDS_ASSIGN_CARD.getRoute({policyID, feed, cardID}));
return;
}
Expand All @@ -99,7 +102,7 @@ function ConfirmationStep({route}: ConfirmationStepProps) {

switch (step) {
case CONST.COMPANY_CARD.STEP.ASSIGNEE:
Navigation.navigate(ROUTES.WORKSPACE_COMPANY_CARDS_ASSIGN_CARD_ASSIGNEE.getRoute(routeParams));
Navigation.goBack(ROUTES.WORKSPACE_COMPANY_CARDS_ASSIGN_CARD_ASSIGNEE.getRoute(routeParams), {compareParams: false});
break;
case CONST.COMPANY_CARD.STEP.TRANSACTION_START_DATE:
Navigation.navigate(ROUTES.WORKSPACE_COMPANY_CARDS_ASSIGN_CARD_TRANSACTION_START_DATE.getRoute(routeParams));
Expand All @@ -113,7 +116,8 @@ function ConfirmationStep({route}: ConfirmationStepProps) {
};

const handleBackButtonPress = () => {
Navigation.navigate(ROUTES.WORKSPACE_COMPANY_CARDS_ASSIGN_CARD_ASSIGNEE.getRoute({policyID, feed, cardID}));
setAssignCardStepAndData({isEditing: true});
Navigation.goBack(ROUTES.WORKSPACE_COMPANY_CARDS_ASSIGN_CARD_ASSIGNEE.getRoute({policyID, feed, cardID}), {compareParams: false});
};

return (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@
const invitingMemberDetails = getPersonalDetailByEmail(invitingMemberEmail);
const invitingMemberName = Str.removeSMSDomain(invitingMemberDetails?.displayName ?? '');

const handleMemberPress = () => {

Check failure on line 187 in src/pages/workspace/members/WorkspaceInviteMessageComponent.tsx

View workflow job for this annotation

GitHub Actions / ESLint check

'handleMemberPress' is assigned a value but never used

Check failure on line 187 in src/pages/workspace/members/WorkspaceInviteMessageComponent.tsx

View workflow job for this annotation

GitHub Actions / Changed files ESLint check

'handleMemberPress' is assigned a value but never used
clearInviteDraft(policyID);
setAssignCardStepAndData({
currentStep: CONST.COMPANY_CARD.STEP.ASSIGNEE,
Expand Down Expand Up @@ -255,8 +255,7 @@
<MenuItemWithTopDescription
title={invitingMemberName && invitingMemberName !== invitingMemberEmail ? invitingMemberName : invitingMemberEmail}
description={translate('common.member')}
shouldShowRightIcon
onPress={handleMemberPress}
interactive={false}
/>
)}
{shouldShowMemberNames && !isInviteNewMemberStep && (
Expand Down
Loading