Skip to content

[No QA] Stringify errorInfo in ErrorBoundary so stack traces show in logs #7819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stitesExpensify merged 1 commit into from
Feb 22, 2022
Merged

[No QA] Stringify errorInfo in ErrorBoundary so stack traces show in logs #7819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/ErrorBoundary/BaseErrorBoundary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class BaseErrorBoundary extends React.Component {
}

componentDidCatch(error, errorInfo) {
this.props.logError(this.props.errorMessage, error, errorInfo);
this.props.logError(this.props.errorMessage, error, JSON.stringify(errorInfo));

// We hide the splash screen since the error might happened during app init
BootSplash.hide();
Expand Down
2 changes: 1 addition & 1 deletion src/components/ErrorBoundary/index.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ BaseErrorBoundary.defaultProps.logError = (errorMessage, error, errorInfo) => {

/* On native we also log the error to crashlytics
* Since the error was handled we need to manually tell crashlytics about it */
crashlytics().log(`errorInfo: ${JSON.stringify(errorInfo)}`);
crashlytics().log(`errorInfo: ${errorInfo}`);
crashlytics().recordError(error);
};

Expand Down