[CP Staging] Expense - Review duplicates RHP loads infinitely after deleting expense by WojtekBoman · Pull Request #78258 · Expensify/App

WojtekBoman · 2025-12-22T07:48:04Z

Explanation of Change

This PR fixes navigating back after deleting duplicated expense. It brings back the original behavior of the back button. The removed changes will be added in the PR introducing Super Wide RHP

Additionally this PR includes a small fix for setting options for SearchReport screen. In the previous version modal stack options were not passed correctly

The app behaviour after being fixed:

Screen.Recording.2025-12-22.at.08.44.30.mov

Fixed Issues

$ #78239
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2025-12-22T07:54:46Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-12-22T08:02:24Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...on/AppNavigator/Navigators/RightModalNavigator.tsx	`4.93% <ø> (ø)`
src/pages/home/ReportScreen.tsx	`68.96% <100.00%> (-0.23%)`	⬇️
... and 10 files with indirect coverage changes

ZhenjaHorbach · 2025-12-22T13:09:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2025-12-22.14.49.21.mov

Android: mWeb Chrome

2025-12-22.14.42.15.mov

iOS: HybridApp

2025-12-22.14.45.06.mov

iOS: mWeb Safari

2025-12-22.14.42.15.mov

MacOS: Chrome / Safari

2025-12-22.14.36.52.mov

ZhenjaHorbach · 2025-12-22T13:38:59Z

Minor issue
That we can go back to this infinity loading screen using go forward button
But it's not a blocker

2025-12-22.14.37.15.mov

mountiny

LGTM

mountiny · 2025-12-22T13:57:43Z

+                            options={(props) => {
+                                const options = modalStackScreenOptions(props);
+                                return {...options, animation: Animations.NONE};


Can you add a comment here to explain why this has to be done?

OSBotify · 2025-12-22T14:09:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…inite-loading [CP Staging] Expense - Review duplicates RHP loads infinitely after deleting expense (cherry picked from commit b5f5f9c) (cherry-picked to staging by mountiny)

OSBotify · 2025-12-22T15:11:22Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.85-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

m-natarajan · 2025-12-22T16:11:22Z

Not reproduce, MacOS Monterey / Chrome, Web v9.2.85-3

Screen.Recording.2025-12-22.at.17.45.32.mp4

OSBotify · 2025-12-23T00:34:27Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.85-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-23T00:54:17Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.86-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-24T18:51:24Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.86-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot Bot assigned WojtekBoman Dec 22, 2025

Fix navigating back after deleting duplicate

b24e845

WojtekBoman force-pushed the fix-wide-rhp-infinite-loading branch from 8ec210a to b24e845 Compare December 22, 2025 07:52

WojtekBoman marked this pull request as ready for review December 22, 2025 07:54

WojtekBoman requested review from a team as code owners December 22, 2025 07:54

melvin-bot Bot requested review from abdulrahuman5196 and heyjennahay and removed request for a team December 22, 2025 07:54

melvin-bot Bot removed the request for review from a team December 22, 2025 07:54

mountiny changed the title ~~Expense - Review duplicates RHP loads infinitely after deleting expense~~ [CP Staging] Expense - Review duplicates RHP loads infinitely after deleting expense Dec 22, 2025

mountiny requested review from ZhenjaHorbach and mountiny and removed request for abdulrahuman5196 December 22, 2025 13:44

mountiny approved these changes Dec 22, 2025

View reviewed changes

ZhenjaHorbach approved these changes Dec 22, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny December 22, 2025 13:58

mountiny merged commit b5f5f9c into Expensify:main Dec 22, 2025
36 of 37 checks passed

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Dec 22, 2025

OSBotify mentioned this pull request Dec 22, 2025

Deploy Checklist: New Expensify 2025-12-19 #78170

Closed

87 tasks

melvin-bot Bot mentioned this pull request Dec 24, 2025

[Due for payment 2025-12-31] Expense - Review duplicates RHP loads infinitely after deleting expense #78239

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Expense - Review duplicates RHP loads infinitely after deleting expense#78258

[CP Staging] Expense - Review duplicates RHP loads infinitely after deleting expense#78258
mountiny merged 1 commit into
Expensify:mainfrom
software-mansion-labs:fix-wide-rhp-infinite-loading

WojtekBoman commented Dec 22, 2025 •

edited

Loading

Uh oh!

melvin-bot Bot commented Dec 22, 2025

Uh oh!

codecov Bot commented Dec 22, 2025 •

edited by github-actions Bot

Loading

Uh oh!

ZhenjaHorbach commented Dec 22, 2025 •

edited

Loading

Uh oh!

ZhenjaHorbach commented Dec 22, 2025

Uh oh!

mountiny left a comment

Uh oh!

mountiny Dec 22, 2025

Uh oh!

Uh oh!

OSBotify commented Dec 22, 2025

Uh oh!

OSBotify commented Dec 22, 2025

Uh oh!

m-natarajan commented Dec 22, 2025

Uh oh!

OSBotify commented Dec 23, 2025

Uh oh!

OSBotify commented Dec 23, 2025

Uh oh!

OSBotify commented Dec 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

WojtekBoman commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Dec 22, 2025

Uh oh!

codecov Bot commented Dec 22, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ZhenjaHorbach commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Dec 22, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Dec 22, 2025

Uh oh!

OSBotify commented Dec 22, 2025

Uh oh!

m-natarajan commented Dec 22, 2025

Uh oh!

OSBotify commented Dec 23, 2025

Uh oh!

OSBotify commented Dec 23, 2025

Uh oh!

OSBotify commented Dec 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

WojtekBoman commented Dec 22, 2025 •

edited

Loading

codecov Bot commented Dec 22, 2025 •

edited by github-actions Bot

Loading

ZhenjaHorbach commented Dec 22, 2025 •

edited

Loading