Skip to content

Revert style change that causes rows to overlap or get truncated #78408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcaaron merged 2 commits into from
Dec 23, 2025
Merged

Revert style change that causes rows to overlap or get truncated #78408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb526fa
Revert style change that causes rows to overlap or get truncated
francoisl Dec 23, 2025
6c76a2e
Apply review suggestion
francoisl Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/MessagesRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ function MessagesRow({messages = {}, type, onDismiss = () => {}, containerStyles
}

return (
<View style={[styles.flexRow, styles.alignItemsCenter, styles.mb4, styles.messagesRowHeight, containerStyles]}>
<View style={[styles.flexRow, styles.alignItemsCenter, containerStyles]}>

@situchan situchan Dec 23, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@francoisl let's update below line to errorRowStyles={[styles.ph5, styles.mb4]} in addition to this removal.
I confirmed that this doesn't break what they fixed.
styles.messagesRowHeight is redundant, no need.

App/src/pages/workspace/companyCards/WorkspaceCompanyCardsTable/WorkspaceCompanyCardsTableItem.tsx

Line 129 in 8d3208e

errorRowStyles={styles.ph5}

@francoisl francoisl Dec 23, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Thanks for the review. Would you be able to also test for #78331 please? I can't get my IOS simulator to work anymore

@situchan situchan Dec 23, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On it

<DotIndicatorMessage
dismissError={dismissError}
style={styles.flex1}
Expand Down
2 changes: 1 addition & 1 deletion ...ages/workspace/companyCards/WorkspaceCompanyCardsTable/WorkspaceCompanyCardsTableItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ function WorkspaceCompanyCardTableItem({

return (
<OfflineWithFeedback
errorRowStyles={styles.ph5}
errorRowStyles={[styles.ph5, styles.mb4]}
errors={errors}
pendingAction={pendingAction}
onClose={resetFailedCompanyCardAssignment}
Expand Down
Loading