Make unread chats bold in chat switcher#787
Merged
Merged
Conversation
puneetlath
changed the title
roryabraham
reviewed
Nov 11, 2020
roryabraham
left a comment
roryabraham
left a comment
Contributor
There was a problem hiding this comment.
LGTM and it seems to work, just a couple little suggestions.
Contributor
|
@chiragsalian all yours |
This was referenced May 20, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@chiragsalian can you review please?
This makes it so that when the chat switcher is being used, if a report that is shown in the search results has unread chats, the row will be bolded. For now, this will only apply to group chats, not individual user rows that show up in the chat switcher results. @chiragsalian's PR to change the order in which the results are shown will make it so that this also gets applied to individual user rows.
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/144854
Tests
Screenshots