Update Book-Travel-for-a-Guest.md#79062
Conversation
stephanieelliott
merged commit bd197da
into
stephanieelliott-patch-22
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@RachCHopkins Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| keywords: [book guest travel, guest traveler, expensify travel, book for non-member, travel booking, classic, new expensify] | ||
| --- | ||
|
|
||
| Any member with guest booking permission can book travel for someone who doesn’t have an Expensify account. This guide explains how to get permission and how to complete a guest booking. |
There was a problem hiding this comment.
Terminology violation: Use "member" instead of "guest" in the opening sentence for clarity. The sentence currently says "book travel for a guest, aka someone who doesn't have an Expensify account" but should use clearer language like "book travel for someone who doesn't have an Expensify account" to avoid confusion with the term "guest" being defined.
| --- | ||
|
|
||
| ## How to access the travel tool | ||
| ## Where to find Expensify Travel |
There was a problem hiding this comment.
AI Readiness violation: Vague heading "How to access the travel tool" lacks the specific feature name. Change to "Where to find Expensify Travel" for better clarity and AI parsing.
|
|
||
| ## How to get access | ||
| ## How to get permission to book travel for a guest | ||
|
|
There was a problem hiding this comment.
AI Readiness violation: Vague heading "How to get access" should be more specific. Change to "How to get permission to book travel for a guest" to clearly indicate what access is being discussed.
| 2. Click on **Program** > **Users** > search and select the name of the user who needs to arrange travel. | ||
| 3. Click the **Configuration** tab and then click the toggle for **Allow employee to book for guests**. | ||
| 2. Click **Program** > **Users**, then search and select the name of the member. | ||
| 3. Click the **Configuration** tab. |
There was a problem hiding this comment.
Terminology violation: Use "member" instead of "user" to match Expensify standards. Change "the user who needs to arrange travel" to "the member who needs to arrange travel".
| --- | ||
|
|
||
| ## How to book travel for a guest | ||
| # How to book travel for a guest |
There was a problem hiding this comment.
Markdown formatting violation: This should be a level 2 heading (##) not a level 1 heading (#). HelpDot articles should use # only for the main title and FAQ section. Change to "## How to book travel for a guest".
| --- | ||
|
|
||
| ## What happens next | ||
| ## What happens after booking with Expensify Travel |
There was a problem hiding this comment.
AI Readiness violation: Vague heading "What happens next" lacks specific context. Change to "What happens after booking with Expensify Travel" for better clarity.
| # FAQ | ||
|
|
||
| ## Will the guest need an Expensify account? | ||
| ## Does the guest need to have an Expensify account? |
There was a problem hiding this comment.
Readability improvement: The FAQ question can be clearer. Change "Will the guest need an Expensify account?" to "Does the guest need to have an Expensify account?" for better natural language.
| No. Guest travelers don’t need an account to receive or use their travel reservation. | ||
|
|
||
| ## Will the travel show up in my reports? | ||
| ## Will the guest travel booking show up in my reports? |
There was a problem hiding this comment.
AI Readiness violation: Vague reference "Will the travel show up" should be more specific. Change to "Will the guest travel booking show up in my reports?" for clarity.
HelpDot Documentation ReviewOverall AssessmentThis PR updates the "Book Travel for a Guest" documentation to improve clarity, modernize terminology, and enhance the user experience. The changes demonstrate good attention to user-facing language and flow, but there are several areas where the updates diverge from established documentation patterns and introduce inconsistencies. Scores Summary
Key FindingsPositive Changes:
Critical Issues:
Style Concerns:
RecommendationsPriority Actions:
Suggestions for Improvement:
Files Reviewed
Note: This review focuses on documentation quality, structure, and consistency with established patterns observed in comparable Expensify help articles. |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.5-0 🚀
|
|
@stephanieelliott Do we need to QA this? |
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.5-7 🚀
|
3 participants
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari