Skip to content

[NO QA] Update Book-a-Rental-Car.md#79065

Merged
stephanieelliott merged 1 commit into
stephanieelliott-patch-22from
stephanieelliott-patch-22-1
Jan 8, 2026
Merged

[NO QA] Update Book-a-Rental-Car.md#79065
stephanieelliott merged 1 commit into
stephanieelliott-patch-22from
stephanieelliott-patch-22-1

Conversation

@stephanieelliott

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@stephanieelliott stephanieelliott requested a review from a team as a code owner January 8, 2026 04:18
@melvin-bot

melvin-bot Bot commented Jan 8, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @CortneyOfstad

@melvin-bot melvin-bot Bot requested a review from CortneyOfstad January 8, 2026 04:18
@melvin-bot

melvin-bot Bot commented Jan 8, 2026

Copy link
Copy Markdown

@CortneyOfstad Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team January 8, 2026 04:18
@stephanieelliott stephanieelliott merged commit 19c4347 into stephanieelliott-patch-22 Jan 8, 2026
5 of 7 checks passed
@stephanieelliott stephanieelliott deleted the stephanieelliott-patch-22-1 branch January 8, 2026 04:18
Book rental cars quickly and easily through Expensify’s integrated travel portal. This guide walks you through searching for a rental, booking it, and accessing your trip information in New Expensify.

# How to access the travel tool
## Where to find Expensify Travel

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Readiness violation: Heading should use full feature name for clarity. Consider changing to "## Where to find Expensify Travel" to be more specific and descriptive for AI parsing.


From the left-hand menu, select **Reports > Trips**.
Click the green **+** button in the bottom-left corner, then choose **Book travel**.
Tap the green ➕ **Create** button at the bottom of your screen, then choose **Book travel**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability violation: Instructions assume mobile context ("Tap") but should be platform-agnostic or provide both mobile and web instructions. Consider: "Click (or tap on mobile) the green ➕ Create button..."


# What happens next
## What happens after booking with Expensify Travel

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability violation: Heading is verbose and contains unnecessary words. Simplify to "## What happens next" for better scannability. The phrase "after booking with Expensify Travel" is implied context.


## Where can I view my car rental itinerary while on the go?
## Where can I view my trip itinerary?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Readiness violation: Question heading is too vague with "on the go" phrase. Consider changing to "## Where can I view my trip itinerary?" to be more direct and searchable.

@github-actions

github-actions Bot commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR updates the rental car booking documentation with improved heading structure and modernized navigation instructions. The changes reflect current UI patterns (Create button) and improve consistency across the documentation. Overall, this is a quality improvement with minor areas for refinement.

Scores Summary

  • Readability: 9/10 - Clear, well-organized content with excellent step-by-step instructions. Minor redundancy in FAQ headings could be streamlined.
  • AI Readiness: 7/10 - Good metadata and structure, but heading hierarchy issues prevent full compliance. Mixed use of # and ## headings creates inconsistency.
  • Style Compliance: 8/10 - Strong adherence to Expensify voice and proper terminology. Some heading styles could better match documentation standards.

Key Findings

Positive Aspects:

  • Excellent YAML metadata with descriptive title, clear description, and relevant keywords
  • Clear, concise instructions with proper UI element formatting (bold for buttons/labels)
  • Well-structured FAQ section addressing common user questions
  • Good use of breadcrumb-style navigation context
  • Consistent voice and appropriate reading level throughout

Critical Issues:

  1. Heading Hierarchy Inconsistency: The document mixes # and ## headings inconsistently:

    • Lines 11, 18 use # (H1) headings
    • Lines 36, 43 use ## (H2) headings
    • Best practice: Use only # and ## consistently, with ## for main sections after intro
  2. FAQ Heading Redundancy: FAQ question "Where can I view my trip itinerary?" could be more specific (currently removed "car rental" and "while on the go" which provided useful context)

Minor Improvements:

  • Line 14: "Create button" instruction is clearer than previous "Reports > Trips" path
  • Line 16: Cross-reference link to "Enable Travel on a Workspace" is a good addition
  • Line 36: "What happens after booking with Expensify Travel" heading is more descriptive than previous "What happens next"

Recommendations

Priority 1 - Fix Before Merge:

  1. Standardize all main section headings to use ## (H2) format:
    • Change line 11: "# How to access..." → "## How to access..."
    • Change line 18: "# How to book..." → "## How to book..."
    • Keep line 43: "# FAQ" as # (H1) since it's a major section

Priority 2 - Consider for Enhancement:

  1. The FAQ heading at line 56 "Where can I view my trip itinerary?" is less specific than the original. Consider: "Where can I view my rental car itinerary while traveling?" to maintain clarity about both the car rental context and mobile use case.

  2. Line 14: Consider clarifying the platform context - is this mobile-specific instruction? If so, mention "in the mobile app" for clarity.

Files Reviewed

  • docs/articles/travel/booking-travel/Book-a-Rental-Car.md - Good quality updates with heading hierarchy issues

Detailed analysis: This single-file PR makes targeted improvements to the rental car booking guide. The changes modernize navigation instructions and improve heading descriptiveness. The primary concern is maintaining consistent heading hierarchy for optimal AI parsing and documentation structure.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.5-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@IuliiaHerets

Copy link
Copy Markdown

@stephanieelliott any QA steps here?

@stephanieelliott stephanieelliott changed the title Update Book-a-Rental-Car.md [NO QA] Update Book-a-Rental-Car.md Jan 20, 2026
@stephanieelliott

Copy link
Copy Markdown
Contributor Author

No QA - sorry @IuliiaHerets, usually these are auto-marked as [NO QA] but it looks like it failed in a few cases.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.5-7 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants