Skip to content

Add hotkey navigation of the chat history in desktop #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex-mechler merged 4 commits into from
Nov 19, 2020
Merged

Add hotkey navigation of the chat history in desktop #792

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
86c2390
Add History menu with Forward & Backward hotkeyed options
deetergp Nov 13, 2020
a85ce69
Trying to make ESLint happy
deetergp Nov 13, 2020
a925718
Use menu.insert to put History before Window & Help
deetergp Nov 16, 2020
69eaaed
Wire up the Fwd & Back buttons
deetergp Nov 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions desktop/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,21 @@ const mainWindow = (() => {

// List the Expensify Chat instance under the Window menu, even when it's hidden
const systemMenu = Menu.getApplicationMenu();
systemMenu.insert(4, new MenuItem({
label: 'History',
submenu: [{
role: 'back',
label: 'Back',
accelerator: process.platform === 'darwin' ? 'Cmd+[' : 'Shift+[',
click: () => { browserWindow.webContents.goBack(); }
},
{
role: 'forward',
label: 'Forward',
accelerator: process.platform === 'darwin' ? 'Cmd+]' : 'Shift+]',
click: () => { browserWindow.webContents.goForward(); }
}]
}));
const windowMenu = systemMenu.items.find(item => item.role === 'windowmenu');
windowMenu.submenu.append(new MenuItem({type: 'separator'}));
windowMenu.submenu.append(new MenuItem({
Expand Down