refactor createDraftTransactionAndNavigateToParticipantSelector function by dukenv0307 · Pull Request #79580 · Expensify/App

dukenv0307 · 2026-01-14T15:18:18Z

Explanation of Change

Fixed Issues

$ #67778
PROPOSAL:

Tests

Open SelfDM chat
Track an expense
Open the expense
Click on the header to open report detail page
Click the Submit to someone button
Select any option
Verify that the expense can be submitted successfully

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2026-01-14.at.21.58.09.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2026-01-14.at.21.57.03.mov

MacOS: Chrome / Safari

Screen.Recording.2026-01-14.at.21.52.57.mov

…ion to use allTransactionDrafts from useOnyx

codecov · 2026-01-14T15:28:25Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/ReportUtils.ts	`71.73% <100.00%> (ø)`
src/pages/ReportDetailsPage.tsx	`59.94% <100.00%> (+0.11%)`	⬆️
src/pages/home/report/PureReportActionItem.tsx	`52.72% <ø> (ø)`
src/pages/home/report/ReportActionItem.tsx	`100.00% <100.00%> (ø)`
... and 6 files with indirect coverage changes

melvin-bot · 2026-01-15T08:08:29Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2026-01-15T08:12:32Z

    introSelected?: OnyxEntry<OnyxTypes.IntroSelected>;

+    /** All transaction drafts */
+    allTransactionDrafts?: OnyxCollection<OnyxTypes.Transaction>;


Suggested change

allTransactionDrafts?: OnyxCollection<OnyxTypes.Transaction>;

allTransactionDrafts: OnyxCollection<OnyxTypes.Transaction>;

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 52c51c7bef

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-01-15T08:40:48Z

                            CONST.IOU.ACTION.SUBMIT,
                            action.reportActionID,
                            introSelected,
+                            allTransactionDrafts,


Ensure draft collection updates refresh memoized handlers

PureReportActionItem is wrapped in memo with a custom comparator that does not include allTransactionDrafts, yet the newly added onPress handlers now capture and pass that collection into createDraftTransactionAndNavigateToParticipantSelector. If a new draft is created or removed after this item first renders (e.g., another expense draft is opened elsewhere), the component will not re-render and the handler will still pass the stale collection, so removeDraftTransactions can miss newer drafts and leave extra drafts behind. Consider adding allTransactionDrafts to the memo comparator or fetching the latest drafts at call time.

Useful? React with 👍 / 👎.

DylanDylann · 2026-01-15T09:20:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-01-15.at.16.15.05.mov

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

DylanDylann

LGTM

melvin-bot · 2026-01-15T09:20:25Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #67778 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

joekaufmanexpensify · 2026-01-15T18:16:10Z

No product considerations, removing my review

DylanDylann · 2026-01-19T11:40:43Z

@dukenv0307 we got conflicts

dukenv0307 · 2026-01-19T13:08:55Z

@danieldoglas all yours

OSBotify · 2026-01-19T16:41:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-20T17:42:50Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.3.5-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

jponikarchuk · 2026-01-20T20:12:54Z

This PR failing because of this issue in Offline mode
The issue is reproducible in: Web, Android app

OSBotify · 2026-01-21T23:07:19Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.5-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

danieldoglas · 2026-01-21T23:21:07Z

@dukenv0307 @DylanDylann can you check the comment above?

dukenv0307 · 2026-01-22T03:06:43Z

I don't think it's the regression because we can reproduce it on production

refactor createDraftTransactionAndNavigateToParticipantSelector funct…

9e04c1d

…ion to use allTransactionDrafts from useOnyx

melvin-bot Bot assigned dukenv0307 Jan 14, 2026

dukenv0307 changed the title ~~refactor createDraftTransactionAndNavigateToParticipantSelector funct…~~ refactor createDraftTransactionAndNavigateToParticipantSelector function Jan 14, 2026

merge main

52c51c7

dukenv0307 marked this pull request as ready for review January 15, 2026 08:08

dukenv0307 requested review from a team as code owners January 15, 2026 08:08

melvin-bot Bot requested review from DylanDylann and joekaufmanexpensify and removed request for a team January 15, 2026 08:08

DylanDylann reviewed Jan 15, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Jan 15, 2026

View reviewed changes

fix test

e27518c

DylanDylann approved these changes Jan 15, 2026

View reviewed changes

melvin-bot Bot requested a review from danieldoglas January 15, 2026 09:20

joekaufmanexpensify removed their request for review January 15, 2026 18:16

merge main

ed9537b

danieldoglas approved these changes Jan 19, 2026

View reviewed changes

danieldoglas merged commit 04759f7 into Expensify:main Jan 19, 2026
27 checks passed

OSBotify mentioned this pull request Jan 20, 2026

Deploy Checklist: New Expensify 2026-01-20 #80009

Closed

85 tasks

jponikarchuk mentioned this pull request Jan 20, 2026

[Due for Payment 2026-02-27][$250] Expense - Blank skeleton shown after submitting to WS from self DM #80027

Closed

7 tasks

melvin-bot Bot mentioned this pull request Jan 21, 2026

[Due for payment 2026-03-30] [Due for payment 2026-03-19] Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.TRANSACTION_DRAFT in src/libs/actions/Transaction.ts #67778

Closed

dukenv0307 mentioned this pull request Mar 5, 2026

Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.POLICY in src/libs/OptionsListUtils.ts #66377

Closed

	allTransactionDrafts?: OnyxCollection<OnyxTypes.Transaction>;
	allTransactionDrafts: OnyxCollection<OnyxTypes.Transaction>;

Conversation

dukenv0307 commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jan 14, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jan 15, 2026

Uh oh!

DylanDylann Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Jan 15, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Jan 15, 2026

Uh oh!

joekaufmanexpensify commented Jan 15, 2026

Uh oh!

DylanDylann commented Jan 19, 2026

Uh oh!

dukenv0307 commented Jan 19, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 19, 2026

Uh oh!

OSBotify commented Jan 20, 2026

Uh oh!

jponikarchuk commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Jan 21, 2026

Uh oh!

danieldoglas commented Jan 21, 2026

Uh oh!

dukenv0307 commented Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dukenv0307 commented Jan 14, 2026 •

edited

Loading

codecov Bot commented Jan 14, 2026 •

edited by github-actions Bot

Loading

jponikarchuk commented Jan 20, 2026 •

edited

Loading