refactor getMemberInviteOptions

src/libs/OptionsListUtils/index.ts

@@ -194,13 +194,13 @@
  */
 
 let allPersonalDetails: OnyxEntry<PersonalDetailsList>;
 Onyx.connect({
     key: ONYXKEYS.PERSONAL_DETAILS_LIST,
     callback: (value) => (allPersonalDetails = isEmptyObject(value) ? {} : value),
 });
 
 const policies: OnyxCollection<Policy> = {};
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.POLICY,
     callback: (policy, key) => {
         if (!policy || !key || !policy.name) {
@@ -212,14 +212,14 @@
 });
 
 let allPolicies: OnyxCollection<Policy> = {};
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.POLICY,
     waitForCollectionCallback: true,
     callback: (val) => (allPolicies = val),
 });
 
 let allReports: OnyxCollection<Report>;
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.REPORT,
     waitForCollectionCallback: true,
     callback: (value) => {
@@ -228,7 +228,7 @@
 });
 
 let allReportNameValuePairsOnyxConnect: OnyxCollection<ReportNameValuePairs>;
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS,
     waitForCollectionCallback: true,
     callback: (value) => {
@@ -240,7 +240,7 @@
 const allSortedReportActions: Record<string, ReportAction[]> = {};
 let allReportActions: OnyxCollection<ReportActions>;
 const lastVisibleReportActions: ReportActions = {};
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.REPORT_ACTIONS,
     waitForCollectionCallback: true,
     callback: (actions) => {
@@ -302,7 +302,7 @@
 });
 
 let activePolicyID: OnyxEntry<string>;
 Onyx.connect({
     key: ONYXKEYS.NVP_ACTIVE_POLICY_ID,
     callback: (value) => (activePolicyID = value),
 });
@@ -2585,7 +2585,7 @@
 ): Options {
     return getValidOptions(
         {personalDetails, reports: []},
-        allPolicies,
+        undefined,
         undefined,
         nvpDismissedProductTraining,
         loginList,

tests/unit/OptionsListUtilsTest.tsx

@@ -1592,7 +1592,7 @@ describe('OptionsListUtils', () => {
     });
 
     describe('getMemberInviteOptions()', () => {
-        it('should sort personal details alphabetically', () => {
+        it('should sort personal details alphabetically and return expected structure', () => {
             // Given a set of personalDetails
             // When we call getMemberInviteOptions
             const results = getMemberInviteOptions(OPTIONS.personalDetails, nvpDismissedProductTraining, loginList, CURRENT_USER_ACCOUNT_ID, CURRENT_USER_EMAIL, []);
@@ -1602,6 +1602,23 @@ describe('OptionsListUtils', () => {
             expect(results.personalDetails.at(1)?.text).toBe('Black Widow');
             expect(results.personalDetails.at(2)?.text).toBe('Captain America');
             expect(results.personalDetails.at(3)?.text).toBe('Invisible Woman');
+
+            // Then the results should contain expected structure
+            expect(results.personalDetails.length).toBeGreaterThan(0);
+            expect(results.recentReports).toEqual([]);
+            expect(results.currentUserOption).toBeUndefined();
+        });
+
+        it('should exclude logins when excludeLogins is provided', () => {
+            // Given a set of personalDetails and excludeLogins
+            const excludeLogins = {'reedrichards@expensify.com': true};
+
+            // When we call getMemberInviteOptions with excludeLogins
+            const results = getMemberInviteOptions(OPTIONS.personalDetails, nvpDismissedProductTraining, loginList, CURRENT_USER_ACCOUNT_ID, CURRENT_USER_EMAIL, [], excludeLogins);
+
+            // Then the excluded login should not be in the results
+            const excludedUser = results.personalDetails.find((detail) => detail.login === 'reedrichards@expensify.com');
+            expect(excludedUser).toBeUndefined();
         });
     });