fix: Workspace settings page can be accessible after workspace has been deleted offline by nkdengineer · Pull Request #80894 · Expensify/App

nkdengineer · 2026-01-29T15:15:48Z

Explanation of Change

fix: Workspace settings page can be accessible after workspace has been deleted offline

Fixed Issues

$ #79448
PROPOSAL: #79448 (comment)

Tests

Create a workspace
Go offline
Go to any workspace page (i.e. workspace members, invite members, workspace invite message) and copy the URL in browser
Delete that workspace
Paste and send the URL in any chat
Click on the URL in the chat
Verify that the not found page appears

Verify that no errors appear in the JS console

Offline tests

Same

QA Steps

Same as test

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-01-29.at.22.04.03.mov

Android: mWeb Chrome

Screen.Recording.2026-01-29.at.22.02.55.mov

iOS: Native

Screen.Recording.2026-01-29.at.22.11.17.mov

iOS: mWeb Safari

Screen.Recording.2026-01-29.at.22.09.15.mov

MacOS: Chrome / Safari

Screen.Recording.2026-01-29.at.21.57.38.mov

…en deleted offline

codecov · 2026-01-29T15:26:54Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/workspace/WorkspacePageWithSections.tsx	`73.61% <100.00%> (ø)`
... and 9 files with indirect coverage changes

melvin-bot · 2026-01-29T17:17:15Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6317590e16

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-01-29T17:26:47Z

        }

        // We check isPendingDelete and prevIsPendingDelete to prevent the NotFound view from showing right after we delete the workspace
-        return (!isEmptyObject(policy) && !isPolicyAdmin(policy) && !shouldShowNonAdmin) || (!shouldShowPolicy && !isPendingDelete && !prevIsPendingDelete);
+        return (!isEmptyObject(policy) && !isPolicyAdmin(policy) && !shouldShowNonAdmin) || (!shouldShowPolicy && !(isPendingDelete && !prevIsPendingDelete));
        // eslint-disable-next-line react-hooks/exhaustive-deps


Recompute shouldShow when prevIsPendingDelete flips

The new condition relies on prevIsPendingDelete becoming true on a later render to show the NotFound view for pending-delete policies, but prevIsPendingDelete isn’t in the useMemo dependency list. If a user opens a settings link for a workspace that is already pending deletion (e.g., deleted offline), the first render sets prevIsPendingDelete to false and shouldShow to false, and subsequent re-renders won’t recompute the memoized value because policy hasn’t changed. That means the NotFound view never appears and the deleted workspace can still be accessed.

Useful? React with 👍 / 👎.

@nkdengineer Could you check this comment?

It doesn't seem correct. If we open a setting link of a pending delete workspace, the not found page will appear the first time.

trjExpensify

Makes sense. I do hope one day we can come back and make these pages less generic. 👍

DylanDylann · 2026-02-05T07:03:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-02-05.at.14.04.34.mov

Android: mWeb Chrome

Screen.Recording.2026-02-05.at.14.02.54.mov

iOS: HybridApp

Screen.Recording.2026-02-05.at.14.01.03.mov

iOS: mWeb Safari

Screen.Recording.2026-02-05.at.13.59.19.mov

MacOS: Chrome / Safari

Screen.Recording.2026-02-05.at.13.48.52.mov

DylanDylann · 2026-02-05T07:17:56Z

Additional test

Because we are reverting a part of the change in #75085, we need to retest the previous issue

Create workspace
Open overview page
Press "More" dropdown button
Delete the policy
Verify you navigate to workspaces page without displaying not found page after deleting the workspace

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-02-05.at.14.05.35.mov

Android: mWeb Chrome

Screen.Recording.2026-02-05.at.14.02.43.mov

iOS: HybridApp

Screen.Recording.2026-02-05.at.14.00.45.mov

iOS: mWeb Safari

Screen.Recording.2026-02-05.at.13.55.34.mov

MacOS: Chrome / Safari

Screen.Recording.2026-02-05.at.13.51.33.mov

DylanDylann

LGTM

github-actions · 2026-02-09T21:38:49Z

🚧 @AndrewGable has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-09T21:50:28Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #80894.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-92a51ae-ec8ae680f7313a5a6db9ac8648921cd28728b60b/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-92a51ae-21adcac6da0a3742ec50c6be46f58ec65f1a1c19/index.html

Web 🕸️
https://80894.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-10T07:23:25Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.3.16-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-11T06:27:54Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.16-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: Workspace settings page can be accessible after workspace has be…

6317590

…en deleted offline

melvin-bot Bot assigned nkdengineer Jan 29, 2026

nkdengineer marked this pull request as ready for review January 29, 2026 17:17

nkdengineer requested review from a team as code owners January 29, 2026 17:17

melvin-bot Bot requested review from DylanDylann and trjExpensify and removed request for a team January 29, 2026 17:17

chatgpt-codex-connector Bot reviewed Jan 29, 2026

View reviewed changes

trjExpensify approved these changes Jan 30, 2026

View reviewed changes

Merge branch 'main' into fix/79448

ea4041f

DylanDylann approved these changes Feb 5, 2026

View reviewed changes

melvin-bot Bot requested a review from AndrewGable February 5, 2026 07:18

AndrewGable approved these changes Feb 9, 2026

View reviewed changes

AndrewGable merged commit 92a51ae into Expensify:main Feb 9, 2026
30 of 32 checks passed

MelvinBot mentioned this pull request Feb 9, 2026

[Odometer] Gate feature tab behind beta flag #81906

Merged

53 tasks

OSBotify mentioned this pull request Feb 10, 2026

Deploy Checklist: New Expensify 2026-02-10 #81937

Closed

Conversation

nkdengineer commented Jan 29, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jan 29, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jan 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

DylanDylann Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

nkdengineer Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann commented Feb 5, 2026

Additional test

Screenshots/Videos

Uh oh!

DylanDylann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Feb 9, 2026

Uh oh!

github-actions Bot commented Feb 9, 2026

Uh oh!

OSBotify commented Feb 10, 2026

Uh oh!

OSBotify commented Feb 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented Jan 29, 2026 •

edited by github-actions Bot

Loading

DylanDylann commented Feb 5, 2026 •

edited

Loading