[Home Page] Create AnnouncementsSection Component #80931
Conversation
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
| { | ||
| width: variables.iconSizeExtraLarge, | ||
| height: variables.iconSizeExtraLarge, |
There was a problem hiding this comment.
Let's move this into styles folder
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Discussed with @dannymcclain that we will do nothing about the overlap now |
|
Added overlap to #80873 for tracking |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2026-01-29.20.42.07.movAndroid: mWeb Chrome2026-01-29.20.45.16.moviOS: HybridApp2026-01-29.20.42.07.moviOS: mWeb Safari2026-01-29.20.45.16.movMacOS: Chrome / Safari2026-01-29.20.37.18.mov2026-01-29.21.49.10.mov |
5aa3f4c to
ea7fadc
Compare
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
|
Okay |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
The test drive card disappears when it's fully loaded: CleanShot.2026-01-29.at.13.28.50.mp4 |
@mountiny |
Actually weird that we don't have |
7ca1361 to
4710b8e
Compare
|
@dubielzyk-expensify Shouldn't all those chevrons be using the mini caret icon and be at 50% opacity? |
4710b8e to
c24daea
Compare
Greeeat shout! But also, that PR isn't merged yet right? So we won't have access until then? |
|
OH! I didn't realize that haha. My bad! |
c24daea to
1d60fa0
Compare
mountiny
left a comment
There was a problem hiding this comment.
The padding changes requested from @dubielzyk-expensify are a bit complex with the hover logic et all so we are going to add them in the next pr with the beta removal
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Agree with that and with Danny's comment about size. See ya in the follow ups I suppose! |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.11-16 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀
|



Explanation of Change
src/components/DateIcon.tsx: small square showing month abbreviation and day number; accepts adatestring prop.Fixed Issues
$ #79981
PROPOSAL:
Tests
Precondition: access to
newDotHomebetaOffline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari