Make CurrencySelectionList use new SelectionListWithSections#81011
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
I'm not sure why checks don't run |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-02-03.at.10.03.01.movAndroid: mWeb ChromeScreen.Recording.2026-02-03.at.09.33.30.moviOS: HybridAppScreen.Recording.2026-02-03.at.10.40.53.moviOS: mWeb SafariScreen.Recording.2026-02-03.at.09.28.51.movScreen.Recording.2026-02-03.at.09.29.26.movScreen.Recording.2026-02-03.at.09.29.56.movScreen.Recording.2026-02-03.at.09.30.20.movScreen.Recording.2026-02-03.at.09.31.00.movMacOS: Chrome / SafariScreen.Recording.2026-02-03.at.09.14.17.movScreen.Recording.2026-02-03.at.09.16.10.movScreen.Recording.2026-02-03.at.09.16.43.movScreen.Recording.2026-02-03.at.09.17.17.movScreen.Recording.2026-02-03.at.09.21.46.movScreen.Recording.2026-02-03.at.09.23.07.mov |
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.3.13-1 🚀
|
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.3.15-0 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.15-10 🚀
|
Explanation of Change
Fixed Issues
$ #65658
PROPOSAL:
Tests
There are several scenarios to test:
BankAccountDetails<-CurrencyPicker<-CurrencySelectionListAccount tabWalletAdd bank accountAccount detailspage go toCurrencyIOURequestStepCurrencyModalAmountWorkspaceOverviewCurrencyPageOverviewDefault currencyPaymentCurrencyPageAccount->PreferencesPayment currencyNote
DebugDetailsConstantPickerPagecan be tested only on devDebugDetailsConstantPickerPageDebug modeReportsand enter debug modalCurrencyBaseOnboardingWorkspaceCurrencyTrack and budget expensesEditPerDiemCurrencyPagePer diemenabledPer diemtabCurrencyCurrencySelectionPageDefault currencyOffline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-02-02.at.12.46.39.mov