Fix: Reports - Previous expense disappears after creating new one offline with "Group by" applied

[annaweber830]

Explanation of Change

Fix: Reports - Previous expense disappears after creating new one offline with "Group by" applied

Fixed Issues

$ #79838
PROPOSAL: #79838 (comment)

Tests

1. Open the Expensify app.
2. Open any workspace chat.
3. Create a manual expense.
4. Navigate to "Reports" > "Expenses"
5. Tap on "Filters"
6. Tap on "Group By" and select "From"
7. Apply the selected filter.
8. Expand the results.
9. Note that the just created expense is correctly displayed.
10. Turn off internet connection.
11. Create a new manual expense.
12. Apply the same group by filter again
13. Check that new expense and old expense is visible on results

• Verify that no errors appear in the JS console

Offline tests

Same as test

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

1. Open the Expensify app.
2. Open any workspace chat.
3. Create a manual expense.
4. Navigate to "Reports" > "Expenses"
5. Tap on "Filters"
6. Tap on "Group By" and select "From"
7. Apply the selected filter.
8. Expand the results.
9. Note that the just created expense is correctly displayed.
10. Turn off internet connection.
11. Create a new manual expense.
12. Apply the same group by filter again
13. Check that new expense and old expense is visible on results

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2026-02-16.at.10.43.07.AM.mp4

Android: mWeb Chrome

Screen.Recording.2026-02-16.at.11.16.47.AM.mp4

iOS: Native

Screen.Recording.2026-02-12.at.1.35.33.PM.mp4

iOS: mWeb Safari

Screen.Recording.2026-02-12.at.1.46.30.PM.mp4

MacOS: Chrome / Safari

Screen.Recording.2026-02-05.at.2.18.22.PM.mp4

[melvin-bot]

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...stWithSections/Search/TransactionGroupListItem.tsx	68.11% <ø> (ø)
src/libs/actions/IOU/index.ts	71.36% <100.00%> (+0.07%)	⬆️
... and 33 files with indirect coverage changes

[jjcoffee]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-app-2026-02-09_16.51.53.mp4

Android: mWeb Chrome

android-chrome-2026-02-09_16.58.56.mp4

iOS: HybridApp

ios-app-2026-02-09_16.21.00.mp4

iOS: mWeb Safari

ios-safari-2026-02-09_16.33.50.mp4

MacOS: Chrome / Safari

desktop-chrome-2026-02-09_16.10.34.mp4

[jjcoffee]

@annaweber830 Please add screenshots for all platforms.

[jjcoffee]

Seems like there's been a bit of a change of behaviour since the issue was raised, the group by filter gets removed when a new expense is added (even when offline), and on mobile this seems to result in the offline screen showing.

android-app-2026-02-09_16.51.53.mp4

[annaweber830]

Hi @jjcoffee How should I fix this issue?

[jjcoffee]

@annaweber830 I think this is probably out of scope for this issue since it's now the behaviour on production. We'll have to wait for @heyjennahay on this other issue though.

[jjcoffee]

@annaweber830 Can you add the other platform screenshots in the meantime?

[heyjennahay]

Sorry for the slow reply on this.

@jjcoffee with your question in #81607 (comment) are you suggesting the heading expense count and amount should be updated to include the offline created expense? So in your screenshot it would be 2 and €7?

[jjcoffee]

@jjcoffee with your question in #81607 (comment) are you suggesting the heading expense count and amount should be updated to include the offline created expense? So in your screenshot it would be 2 and €7?

@heyjennahay That's right. I guess in a way the new expense is pending to be added so maybe it doesn't make sense for it to be included in the total yet?

[heyjennahay]

@jjcoffee yeah I can see the argument both ways for sure but I think for the sake of getting this PR done let's go with the simplest solution which I think is not updating the header?

[jjcoffee]

@annaweber830 Let's add another step to account for the change in behaviour so QA don't get confused. Something like "apply the same group by filter again".

[jjcoffee]

@annaweber830 Please also add the remaining screenshots for Android devices.

[jjcoffee]

LGTM!

[cristipaval]

Could we please:

• Generalize beyond just GROUP_BY.FROM, or file a follow-up issue
• Add at least one unit test covering this optimistic data path
• Fill in the "Explanation of Change" section

[annaweber830]

Hi @cristipaval should I do these?:

• Generalize beyond just GROUP_BY.FROM, or file a follow-up issue
• Add at least one unit test covering this optimistic data path

[cristipaval]

yes please, it would be great to extend the fix for all groupBYs

[annaweber830]

• Generalize beyond just GROUP_BY.FROM, or file a follow-up issue

Hi @cristipaval, sorry, I don’t understand. What does this mean: “Generalize beyond just GROUP_BY.FROM, or file a follow-up issue”?

[jjcoffee]

What does this mean: “Generalize beyond just GROUP_BY.FROM, or file a follow-up issue”?

They mean so that it would work for any of the group by filters, e.g. Card, Category, etc. Is it trivial to do that?

[annaweber830]

Hi @jjcoffee
Not fully trivial, but it’s definitely feasible.
Right now my implementation fixes the concrete repro path (Group by: From) by:

1. preserving group snapshot state offline (isOffline in group fetch), and
2. optimistically updating the relevant child group snapshot when creating a new expense offline.
   To make this work for all group-by modes (Card, Category, Merchant, Tag, Month/Week/Year/Quarter, etc.), we should generalize the child-query/snapshot generation logic per group type (since each group uses different filter construction and normalization rules, especially date groups and empty-value handling).
   So I’d call it medium effort, not a one-line/trivial change.
   I can follow up with a refactor that extracts shared “group child query builder” logic and wires optimistic updates for all supported group types.

[jjcoffee]

Okay, sounds more like a follow-up or a bigger project? cc @cristipaval

[jjcoffee]

@annaweber830 You have failing tests.

[heyjennahay]

Bug fix, product review not required

[cristipaval]

Okay, sounds more like a follow-up or a bigger project? cc @cristipaval

got it!

I can follow up with a refactor that extracts shared “group child query builder” logic and wires optimistic updates for all supported group types.

Thanks @annaweber830!

[cristipaval]

@annaweber830 Please fix the checks

[jjcoffee]

@cristipaval All yours 🙏

[cristipaval]

Thank you both!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81607.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-14cf2f0-1af0040-b027b9265aec0bebac34d0b38d540785b62d19ac/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-14cf2f0-1af0040-85f129a4fe529c69f568961ca4a59fc39ca67c55/index.html

Web 🕸️
https://81607.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.3.23-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.23-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅