[No QA] update PR checklist#8184
Conversation
aldo-expensify
left a comment
aldo-expensify
left a comment
There was a problem hiding this comment.
Left some comments / questions
| - [ ] I followed proper naming convention for platform-specific files (if applicable) | ||
| - [ ] I followed style guidelines (in [`Styling.md`](https://github.com/Expensify/App/blob/main/STYLING.md)) for all style edits I made | ||
| - [ ] I followed the JSDocs style guidelines (in [`STYLE.md`](https://github.com/Expensify/App/blob/main/STYLE.md#jsdocs)) | ||
| - [ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. “toggleReport” and not “onIconClick”) |
There was a problem hiding this comment.
I think the indentation is off here
There was a problem hiding this comment.
ah yeah this is on purpose because this is a sub-bullet point of I followed proper code patterns
There was a problem hiding this comment.
Ahh I see, thanks for pointing that, fixing it
Thanks Aldo! 😀 Could you add the questions related to the checklist points directly in the gdoc? |
|
Moved my dumb questions to the doc :), I'll mark them as resolved here. Meanwhile, should we wait for some feedback before approving? Or should I just approved and if my questions translate in any change, we do a new PR? |
There are no dumb questions IMO 😄
This is an ongoing iterative process, so we'll be updating the PR template when there are new suggestions to the gdoc, meanwhile, I think it's fine to merge this PR and create a new one when the questions are resolved in the doc |
Sounds good, thanks! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @aldo-expensify in version: 1.1.44-0 🚀
|
3 participants
Details
This updates the PR checklist for both Contributors and Reviewers based on the recent changes to this doc.
slack convo
Fixed Issues
N/A
Tests
N/A
QA Steps
N/A
Screenshots
N/A