Change personal card 'Unassign card' label to 'Remove card'#82296
Conversation
This comment has been minimized.
This comment has been minimized.
|
Fixed the The checklist action is now running correctly but reports 35 unchecked items out of 51. The remaining checklist items need to be reviewed and checked off by the PR author as each verification is completed. |
|
The only failing check is This is not a code or CI issue. The The code checks all pass: ESLint, typecheck, Prettier, tests, builds, spellcheck, signed commits, etc. |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@MelvinBot change the removeCardDescription to "Removing this card will delete all associated transactions from your draft reports." |
|
Updated the
Also updated all 9 non-English translation files (de, es, fr, it, ja, nl, pl, pt-BR, zh-hans) to match the new wording. |
This comment has been minimized.
This comment has been minimized.
|
@MelvinBot also update the unassignCardDescription to "Unassigning this card will remove all associated transactions from the cardholder's draft reports." |
|
Updated the
Also updated all 9 non-English translation files (de, es, fr, it, ja, nl, pl, pt-BR, zh-hans) to match the new wording. |
|
Fixed the failing @amyevans — please review the checklist and confirm the items are accurate before merging. In particular, the non-English translations added in the language files should be verified via JaimeGPT and approved by an internal engineer per the checklist requirements. |
|
Fixed the failing checks. All 5 failures (typecheck, ESLint, Prettier, dryRun, generateTranslations) were caused by the same root issue: The
Replaced both with |
This comment has been minimized.
This comment has been minimized.
|
Fixed the failing |
@MelvinBot It looks like the existing convention is to just use |
|
Replaced |
This comment has been minimized.
This comment has been minimized.
|
The failing check was the Prettier check, which flagged a formatting issue in |
|
@MelvinBot apply the diff from @OSBotify here: #82296 (comment) |
|
Applied the @OSBotify translation diff. Updated |
|
Fixed the failing The Fix: Switched the string delimiter to double quotes ( |
Update personal card details page to use "Remove card" instead of "Unassign card" for all user-facing text. Add new translation keys (removeCard, remove, removeCardDescription) across all 10 language files. Also fix unassignCardDescription strings that contained unescaped apostrophes breaking single-quoted strings. Co-authored-by: Amy Evans <amyevans@users.noreply.github.com>
MelvinBot
force-pushed
the
claude-changeUnassignCardToRemoveCard
branch
from
6c0df46 to
08c700a
Compare
|
Fixed the failing checks. There were two issues:
All 12 files from the original PR are included with the same changes. CI should pass now. |
| unassignCardDescription: 'Desasignar esta tarjeta eliminará todas las transacciones en informes en borrador de la cuenta del titular.', | ||
| unassignCardDescription: 'Desasignar esta tarjeta eliminará todas las transacciones asociadas de los informes en borrador del titular de la tarjeta.', | ||
| removeCard: 'Eliminar tarjeta', | ||
| remove: 'Eliminar', | ||
| removeCardDescription: 'Eliminar esta tarjeta borrará todas las transacciones asociadas de tus informes en borrador.', |
There was a problem hiding this comment.
Requested confirmation: https://expensify.slack.com/archives/C01GTK53T8Q/p1770929987604559
|
Reviewed the feedback on this PR. Here's the status: Review comment (inline on Checklist failure: The All other checks pass: typecheck, ESLint, Prettier, tests, builds, signed commits, spellcheck, etc. are all green. No code changes required at this time. |
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 954acb05..7bf51188 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -175,7 +175,6 @@ import type {
ZipCodeExampleFormatParams,
} from './params';
import type {TranslationDeepObject} from './types';
-
type StateValue = {
stateISO: string;
stateName: string;
@@ -5234,10 +5233,10 @@ _Für ausführlichere Anweisungen [besuchen Sie unsere Hilfeseite](${CONST.NETSU
updateCard: 'Karte aktualisieren',
unassignCard: 'Karte zuweisen aufheben',
unassign: 'Zuweisung aufheben',
- unassignCardDescription: 'Das Aufheben der Zuweisung dieser Karte entfernt alle zugehörigen Transaktionen aus den Entwurfsberichten der Karteninhaberin/des Karteninhabers.',
+ unassignCardDescription: 'Das Entfernen der Zuweisung dieser Karte wird alle nicht eingereichten Transaktionen löschen.',
removeCard: 'Karte entfernen',
remove: 'Entfernen',
- removeCardDescription: 'Wenn Sie diese Karte entfernen, werden alle zugehörigen Transaktionen aus Ihren Entwürfen von Berichten gelöscht.',
+ removeCardDescription: 'Wenn Sie diese Karte entfernen, werden alle nicht eingereichten Transaktionen gelöscht.',
assignCard: 'Karte zuweisen',
cardFeedName: 'Name des Kartenfeeds',
cardFeedNameDescription: 'Gib dem Kartenfeed einen eindeutigen Namen, damit du ihn von den anderen unterscheiden kannst.',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index da314764..f6c882e3 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -5253,10 +5253,10 @@ _Pour des instructions plus détaillées, [visitez notre site d’aide](${CONST.
updateCard: 'Mettre à jour la carte',
unassignCard: 'Retirer l’assignation de la carte',
unassign: "Retirer l'assignation",
- unassignCardDescription: "Retirer l'assignation de cette carte supprimera toutes les transactions associées des notes de frais brouillon du titulaire de la carte.",
+ unassignCardDescription: "Retirer l'assignation de cette carte supprimera toutes les transactions non soumises.",
removeCard: 'Supprimer la carte',
remove: 'Supprimer',
- removeCardDescription: 'La suppression de cette carte effacera toutes les transactions associées de vos notes de frais brouillon.',
+ removeCardDescription: 'La suppression de cette carte effacera toutes les transactions non soumises.',
assignCard: 'Assigner une carte',
cardFeedName: 'Nom du flux de carte',
cardFeedNameDescription: 'Donnez au flux de carte un nom unique afin de pouvoir le distinguer des autres.',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index d7ca9475..4b1fc6b6 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -175,7 +175,6 @@ import type {
ZipCodeExampleFormatParams,
} from './params';
import type {TranslationDeepObject} from './types';
-
type StateValue = {
stateISO: string;
stateName: string;
@@ -5222,11 +5221,11 @@ _Per istruzioni più dettagliate, [visita il nostro sito di assistenza](${CONST.
updateCard: 'Aggiorna carta',
unassignCard: 'Rimuovi carta',
unassign: 'Rimuovi assegnazione',
- unassignCardDescription: "La rimozione dell'assegnazione di questa carta eliminerà tutte le transazioni associate dalle bozze di rendiconto del titolare della carta.",
+ unassignCardDescription: 'La rimozione dell’assegnazione di questa carta eliminerà tutte le transazioni non inviate.',
assignCard: 'Assegna carta',
removeCard: 'Rimuovi carta',
remove: 'Rimuovi',
- removeCardDescription: 'Rimuovendo questa carta, tutte le transazioni associate verranno eliminate dalle tue bozze di resoconto.',
+ removeCardDescription: 'La rimozione di questa carta eliminerà tutte le transazioni non inviate.',
cardFeedName: 'Nome feed carta',
cardFeedNameDescription: 'Dai al feed della carta un nome univoco, così puoi distinguerlo dagli altri.',
cardFeedTransaction: 'Elimina transazioni',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 01c673dd..6c7cbec1 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -175,7 +175,6 @@ import type {
ZipCodeExampleFormatParams,
} from './params';
import type {TranslationDeepObject} from './types';
-
type StateValue = {
stateISO: string;
stateName: string;
@@ -5175,10 +5174,10 @@ _詳しい手順については、[ヘルプサイトをご覧ください](${CO
updateCard: 'カードを更新',
unassignCard: 'カードの割り当てを解除',
unassign: '割り当てを解除',
- unassignCardDescription: 'このカードの割り当てを解除すると、カード名義人の下書きレポートから関連するすべての取引が削除されます。',
+ unassignCardDescription: 'このカードの割り当てを解除すると、未送信の取引はすべて削除されます。',
removeCard: 'カードを削除',
remove: '削除',
- removeCardDescription: 'このカードを削除すると、下書きレポート内の関連するすべての取引が削除されます。',
+ removeCardDescription: 'このカードを削除すると、未送信のすべての取引が削除されます。',
assignCard: 'カードを割り当てる',
cardFeedName: 'カードフィード名',
cardFeedNameDescription: '他のカードフィードと区別できるように、一意の名前を付けてください。',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 6a79eaf9..ad9738cc 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -175,7 +175,6 @@ import type {
ZipCodeExampleFormatParams,
} from './params';
import type {TranslationDeepObject} from './types';
-
type StateValue = {
stateISO: string;
stateName: string;
@@ -5211,10 +5210,10 @@ _Voor meer gedetailleerde instructies, [bezoek onze help-site](${CONST.NETSUITE_
updateCard: 'Kaart bijwerken',
unassignCard: 'Kaart loskoppelen',
unassign: 'Toewijzen ongedaan maken',
- unassignCardDescription: 'Als u deze kaart loskoppelt, worden alle bijbehorende transacties verwijderd uit de conceptrapporten van de kaarthouder.',
+ unassignCardDescription: 'Het loskoppelen van deze kaart verwijdert alle niet-ingediende transacties.',
removeCard: 'Kaart verwijderen',
remove: 'Verwijderen',
- removeCardDescription: 'Als je deze kaart verwijdert, worden alle gekoppelde transacties uit je conceptrapporten verwijderd.',
+ removeCardDescription: 'Als je deze kaart verwijdert, worden alle niet-ingediende transacties verwijderd.',
assignCard: 'Kaart toewijzen',
cardFeedName: 'Naam van kaartfeed',
cardFeedNameDescription: 'Geef de kaartfeed een unieke naam zodat je deze kunt onderscheiden van de andere.',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 45421d01..f7425def 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -175,7 +175,6 @@ import type {
ZipCodeExampleFormatParams,
} from './params';
import type {TranslationDeepObject} from './types';
-
type StateValue = {
stateISO: string;
stateName: string;
@@ -5200,10 +5199,10 @@ _Aby uzyskać bardziej szczegółowe instrukcje, [odwiedź naszą stronę pomocy
updateCard: 'Zaktualizuj kartę',
unassignCard: 'Cofnij przypisanie karty',
unassign: 'Cofnij przypisanie',
- unassignCardDescription: 'Odłączenie tej karty spowoduje usunięcie wszystkich powiązanych transakcji z roboczych raportów posiadacza karty.',
+ unassignCardDescription: 'Cofnięcie przypisania tej karty spowoduje usunięcie wszystkich niewysłanych transakcji.',
removeCard: 'Usuń kartę',
remove: 'Usuń',
- removeCardDescription: 'Usunięcie tej karty spowoduje usunięcie wszystkich powiązanych transakcji z Twoich roboczych raportów.',
+ removeCardDescription: 'Usunięcie tej karty spowoduje usunięcie wszystkich niewysłanych transakcji.',
assignCard: 'Przypisz kartę',
cardFeedName: 'Nazwa źródła karty',
cardFeedNameDescription: 'Nadaj kanałowi karty unikalną nazwę, aby odróżnić go od pozostałych.',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 0a34e51d..5b934858 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -175,7 +175,6 @@ import type {
ZipCodeExampleFormatParams,
} from './params';
import type {TranslationDeepObject} from './types';
-
type StateValue = {
stateISO: string;
stateName: string;
@@ -5206,10 +5205,10 @@ _Para instruções mais detalhadas, [visite nossa central de ajuda](${CONST.NETS
updateCard: 'Atualizar cartão',
unassignCard: 'Remover cartão',
unassign: 'Desatribuir',
- unassignCardDescription: 'Desatribuir este cartão removerá todas as transações associadas dos relatórios de rascunho do titular do cartão.',
+ unassignCardDescription: 'Desvincular este cartão excluirá todas as transações não enviadas.',
removeCard: 'Remover cartão',
remove: 'Remover',
- removeCardDescription: 'Remover este cartão excluirá todas as transações associadas dos seus relatórios em rascunho.',
+ removeCardDescription: 'Remover este cartão excluirá todas as transações não enviadas.',
assignCard: 'Atribuir cartão',
cardFeedName: 'Nome do feed do cartão',
cardFeedNameDescription: 'Dê um nome exclusivo ao feed do cartão para diferenciá-lo dos outros.',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 75b182ce..5f7cdfa7 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -5105,10 +5105,10 @@ _如需更详细的说明，请[访问我们的帮助网站](${CONST.NETSUITE_IM
updateCard: '更新卡片',
unassignCard: '取消分配卡片',
unassign: '取消分配',
- unassignCardDescription: '取消分配此卡将从持卡人的草稿报表中移除所有关联交易。',
+ unassignCardDescription: '取消分配此卡将删除所有未提交的交易。',
removeCard: '移除卡片',
remove: '移除',
- removeCardDescription: '移除此卡将从你的草稿报告中删除所有关联交易。',
+ removeCardDescription: '移除此卡片将删除所有未提交的交易。',
assignCard: '分配卡片',
cardFeedName: '卡片交易源名称',
cardFeedNameDescription: '为该卡片流水命名一个唯一名称，以便与其他区分。',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
melvin-bot
Bot
requested review from
Ollyws and
heyjennahay
and removed request for
a team
|
We can skip C+ review here |
Reviewer Checklist
|
MelvinBot
left a comment
MelvinBot
left a comment
There was a problem hiding this comment.
Re-triggering checklist after removing a conflicting comment that was blocking the reviewer checklist action.
|
Fixed the failing Fix: Deleted the conflicting MelvinBot comment and re-triggered the workflow. All checks are now passing. |
|
All checks on this PR are currently passing. There are no failing checks to fix — ESLint, typecheck, tests (all 8 jobs), builds, If checks were previously failing they appear to have been resolved already, possibly by a re-run or a recent push. |
|
🚧 @amyevans has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/amyevans in version: 9.3.23-2 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.23-3 🚀
|
4 participants
Explanation of Change
Updates the personal card details page to use "Remove card" instead of "Unassign card" for all user-facing text. The term "Unassign" is considered jargon and less understandable for typical users.
This change is scoped to personal cards only — the company card pages continue to use "Unassign card" as before.
Also updates copy as discussed in Slack
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/599728
Tests
removeCard/remove/removeCardDescriptionkeys while company card pages continue usingunassignCard/unassign/unassignCardDescriptionOffline tests
N/A - This change only affects UI labels/text, no network behavior changes.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari