[No QA] Refactor isActionLoadingSetSelector into useActionLoadingReportIDs hook#82781
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0d2ea7b004
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-02-19.at.10.46.04.PM.movAndroid: mWeb ChromeScreen.Recording.2026-02-19.at.10.46.39.PM.moviOS: HybridAppScreen.Recording.2026-02-19.at.10.44.47.PM.moviOS: mWeb SafariScreen.Recording.2026-02-19.at.10.45.29.PM.movMacOS: Chrome / SafariScreen.Recording.2026-02-19.at.10.43.25.PM.mov |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
eh2077
left a comment
There was a problem hiding this comment.
Looks good! The new hook works same as the previous selector and avoids data duplication.
This comment has been minimized.
This comment has been minimized.
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.23-2 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.23-3 🚀
|
Explanation of Change
The
isActionLoadingSetSelectorselector was defined inReportMetaData.tsand used viauseOnyxwith a collection-level selector in multiple components. This pattern required each consumer to subscribe to the entireREPORT_METADATAcollection just to build a set of loading report IDs.This PR extracts that logic into a dedicated
useActionLoadingReportIDshook (src/hooks/useActionLoadingReportIDs.ts), which centralizes the subscription and set-building in one place. All call sites (Search/index.tsx,MoneyRequestReportNavigation.tsx,TransactionGroupListItem.tsx) are updated to use the new hook. TheisActionLoadingSelector(single-entry selector) is cleaned up to be a default export, and all consumers of that are updated accordingly. Unit tests for the new hook are included.Fixed Issues
$ #82645
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari