Skip to content

Narrow React Compiler dependencies in MoneyRequestReportNavigation #82785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JmillsExpensify merged 4 commits into from
Feb 21, 2026
Merged

Narrow React Compiler dependencies in MoneyRequestReportNavigation #82785

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
498577e
Memoize getSections computation in MoneyRequestReportNavigation
OlimpiaZurek Feb 18, 2026
19416bc
fix prettier
OlimpiaZurek Feb 18, 2026
de43207
remove useMemo
OlimpiaZurek Feb 19, 2026
253903a
Merge branch 'main' into perf/memoize-getSections-in-MoneyRequestRepo…
OlimpiaZurek Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions src/components/MoneyRequestReportView/MoneyRequestReportNavigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,28 +42,34 @@ function MoneyRequestReportNavigation({reportID, shouldDisplayNarrowVersion}: Mo
const archivedReportsIdSet = useArchivedReportsIdSet();

const {type, status, sortBy, sortOrder, groupBy} = lastSearchQuery?.queryJSON ?? {};
let results: Array<string | undefined> = [];
if (!!type && !!currentSearchResults?.data && !!currentSearchResults?.search) {

const searchResultsData = currentSearchResults?.data;
const searchResultsSearch = currentSearchResults?.search;
const currentAccountID = currentUserDetails.accountID;
const currentUserEmail = currentUserDetails.email ?? '';

@marcaaron marcaaron Feb 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By extracting the specific sub-fields needed (.data, .accountID, etc.) into separate variables, the compiler now tracks only the fields actually used, so the computation only re-runs when its real inputs change.

This is a fairly subtle implementation that leads to a great improvement. I'm wondering if we have a best practice for documenting these scenarios yet? It seems relatively easy to perhaps reverse this change if you view these as unnecessary when actually they are signals for React compiler 🤔

Should we add something like:

// React Compiler: destructure to narrow reactive dependencies and avoid recomputes on unrelated changes

const searchKey = lastSearchQuery?.searchKey;

let allReports: Array<string | undefined> = [];
if (!!type && !!searchResultsData && !!searchResultsSearch) {
const [searchData] = getSections({
type,
data: currentSearchResults.data,
currentAccountID: currentUserDetails.accountID,
currentUserEmail: currentUserDetails.email ?? '',
data: searchResultsData,
currentAccountID,
currentUserEmail,
translate,
formatPhoneNumber,
bankAccountList,
groupBy,
reportActions: exportReportActions,
currentSearch: lastSearchQuery?.searchKey,
currentSearch: searchKey,
archivedReportsIDList: archivedReportsIdSet,
isActionLoadingSet,
cardFeeds,
allReportMetadata,
cardList,
});
results = getSortedSections(type, status ?? '', searchData, localeCompare, translate, sortBy, sortOrder, groupBy).map((value) => value.reportID);
allReports = getSortedSections(type, status ?? '', searchData, localeCompare, translate, sortBy, sortOrder, groupBy).map((value) => value.reportID);
}
const allReports = results;

const currentIndex = allReports.indexOf(reportID);
const allReportsCount = lastSearchQuery?.previousLengthOfResults ?? 0;
Expand Down
Loading