[No QA] Remove e2e performance tests#83094
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Delete the e2e-only ComposerWithSuggestions variant and E2EMarkdownTest, and replace the deleted NetworkInterceptor import in SequentialQueueTest. Co-authored-by: Cursor <cursoragent@cursor.com>
This comment was marked as resolved.
This comment was marked as resolved.
roryabraham
changed the title
roryabraham
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Remove the e2e/e2edelta signing config overrides in the release buildType and clean up the variantFilter that was filtering e2eDebug/e2edeltaDebug variants. Co-authored-by: Cursor <cursoragent@cursor.com>
Delete the 4 index.e2e.tsx Metro source extension overrides that are now dead code (Composer, InvertedFlatList, GenericPressable, BaseTextInput). Remove E2E_TESTING env var from README.md and E2E Tests entry from CLAUDE.md. Co-authored-by: Cursor <cursoragent@cursor.com>
Missed in the earlier cleanup alongside the e2e source set. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
The original waitForActiveRequestsToBeEmpty() was effectively a no-op (Promise.resolve) in the test environment since the E2E network interceptor was never installed. Our earlier replacement with waitForBatchedUpdates() flushed pending timers, which caused the SequentialQueue to process and consume requests before the assertions could check the queue state. Use a bare Promise.resolve() to match the original behavior. Co-authored-by: Cursor <cursoragent@cursor.com>
Re-add comments explaining why signingConfig is set to null and overridden per flavor, and why the variantFilter exists. Co-authored-by: Cursor <cursoragent@cursor.com>
This comment was marked as resolved.
This comment was marked as resolved.
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Contributor
|
🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
roryabraham
changed the title
melvin-bot
Bot
requested review from
heyjennahay
and removed request for
a team
Contributor
Author
|
@heyjennahay no product considerations here. Just removing unused test code |
This comment has been minimized.
This comment has been minimized.
AndrewGable
approved these changes
Feb 20, 2026
AndrewGable
approved these changes
Feb 20, 2026
AndrewGable
left a comment
AndrewGable
left a comment
Contributor
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel and/or tagged@Expensify/designso the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚧 @AndrewGable has triggered a test Expensify/App build. You can view the workflow run here. |
roryabraham
added a commit
that referenced
this pull request
Feb 20, 2026
Incorporate e2e performance test removal from #83094. Resolve conflicts: - buildAndroid.yml: keep our Rock-based rewrite (main only removed e2e build types from the old Fastlane-based version) - deploy.yml: keep our callable workflow structure; adopt main's removal of firebase.json 1Password load and Upload DSYMs step (dSYM upload lanes were removed in #83094) Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.3.25-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.25-13 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Remove the entire e2e performance testing infrastructure from the App repository.
Proposal
This includes:
e2ePerformanceTests.yml(AWS Device Farm orchestration) andcheckE2ETestCode.yml(CI compilation check)tests/e2e/directory (test runner, configs, server, compare utils, native commands, env files, TestSpec.yml)src/libs/E2E/directory (client, actions, test files, utils,isE2ETestSession,reactNativeLaunchingTest)e2eande2edeltaproduct flavors, Fastlane lanes,buildAndroid.ymle2e branches,android/app/src/e2e/AndroidManifest.xmlE2E_TESTINGconditionals inmetro.config.jsandbabel.config.jsE2E_TESTINGconfig flag inCONFIG.ts,isE2ETestSessionusage inPerformance.tsx, e2e guard inQueuedOnyxUpdates.ts@perf-profiler/profiler,@perf-profiler/reporter,@perf-profiler/typesdevDependencies and associated patchesComposerWithSuggestions/index.e2e.tsx,E2EMarkdownTest.ts, prettierignore entry, CLAUDE.md referenceFixed Issues
N/A - internal cleanup
Tests
Prettymuch all the code changes here are build-time, just removing unused code. So there's not much to test. I tested an AdHoc build.
Offline tests
N/A - no runtime behavior changes for end users
QA Steps
[No QA] - This is a pure infrastructure removal with no user-facing changes.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A - infrastructure removal only
Android: mWeb Chrome
N/A - infrastructure removal only
iOS: Native
N/A - infrastructure removal only
iOS: mWeb Safari
N/A - infrastructure removal only
MacOS: Chrome / Safari
N/A - infrastructure removal only