[NoQA] Implement frozen-by-admin info and ask-to-unfreeze functionality by ShridharGoel · Pull Request #83794 · Expensify/App

ShridharGoel · 2026-02-28T12:03:48Z

Explanation of Change

Implement frozen-by-admin info and ask-to-unfreeze functionality.

Fixed Issues

$ #81648
PROPOSAL:

Tests

Precondition: Have a card frozen by an admin.

Go to Account > Wallet.
Click on a frozen card.
Verify that the info about who froze the card shows.
Verify that the "Ask to unfreeze" button shows.
Click the button.
Verify that the workspace to which the card is associated opens.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message: https://expensify.slack.com/archives/C01GTK53T8Q/p1772280463094979
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Video

Screen.Recording.2026-02-28.at.5.32.48.PM.mov

melvin-bot · 2026-02-28T12:03:54Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

melvin-bot · 2026-02-28T12:03:55Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cc41517329

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

codecov · 2026-02-28T12:14:09Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...xpensifyCard/WorkspaceExpensifyCardDetailsPage.tsx	`0.00% <ø> (ø)`
.../pages/settings/Wallet/ExpensifyCardPage/index.tsx	`69.91% <87.50%> (+1.34%)`	⬆️
...e/expensifyCard/WorkspaceExpensifyCardListPage.tsx	`0.00% <0.00%> (ø)`
src/components/FrozenCardHeader.tsx	`0.00% <0.00%> (ø)`
...s/workspace/expensifyCard/WorkspaceCardListRow.tsx	`0.00% <0.00%> (ø)`
... and 8 files with indirect coverage changes

ShridharGoel · 2026-02-28T13:50:55Z

@codex review

chatgpt-codex-connector · 2026-02-28T14:00:03Z

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

joekaufmanexpensify

Core issue from design doc

Pujan92 · 2026-03-04T11:48:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Pujan92 · 2026-03-05T15:18:24Z

Props(canUnfreezeCard, onAskToUnfreezePress) are missing for WorkspaceExpensifyCardDetailsPage

ShridharGoel · 2026-03-05T22:00:23Z

@Pujan92 Updated

Pujan92 · 2026-03-06T12:08:08Z

Plz fix the Typescript failure

Pujan92 · 2026-03-06T12:11:52Z

+    const handleAskToUnfreezePress = useCallback(() => {
+        const cardHolderWorkspaceChatReportID = getPolicyExpenseChat(currentCard?.accountID, policyIDForCurrentCard)?.reportID;
+        if (!cardHolderWorkspaceChatReportID) {
+            return;
+        }
+        Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(cardHolderWorkspaceChatReportID));
+    }, [currentCard?.accountID, policyIDForCurrentCard]);
+


Aren't these changes needed in the workspace expensify card details page?

No, this would be done by a member, and members will be able to access it via wallet page

Pujan92

LGTM! Only the unfreeze api isn't tested yet as I believe it is yet to be deployed.

Screen.Recording.2026-03-13.at.17.31.36.mov

ShridharGoel · 2026-03-13T17:55:45Z

@MariaHCD Can you have a look?

MariaHCD · 2026-03-16T08:24:48Z

@Pujan92 @ShridharGoel the BE PR to allow admins to unfreeze a card was deployed to production. Could you please retest?

Pujan92 · 2026-03-17T16:19:55Z

@MariaHCD LGTM!

Screen.Recording.2026-03-17.at.21.46.56.mov

ShridharGoel · 2026-03-22T15:17:12Z

@Pujan92 Added frozen text in MenuItem here itself

MariaHCD · 2026-03-23T09:12:11Z

@ShridharGoel could you take a look at the ESLint failure?

ShridharGoel · 2026-03-23T09:16:47Z

Doesn't seem related to the changes here, merging main

Pujan92 · 2026-03-23T12:16:38Z

@Pujan92 Added frozen text in MenuItem here itself

Looks good!

MariaHCD · 2026-03-23T14:49:39Z

@ShridharGoel ESLint check is still failing unfortunately :(

github-actions · 2026-03-24T08:03:05Z

🚧 @MariaHCD has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-24T08:07:16Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83794.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-0c95aa6-de8080e-4504a39ff5ef6fb7227a26f6bfac2b2c0da65bde/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-0c95aa6-de8080e-efa721b6b5f85ea24ef921f7435ec0e4bcb108c0/index.html

Web 🕸️
https://83794.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-24T08:09:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-25T16:09:32Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.43-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Implement frozen-by-admin info and ask-to-unfreeze functionality

cc41517

ShridharGoel requested review from a team as code owners February 28, 2026 12:03

melvin-bot Bot assigned ShridharGoel Feb 28, 2026

melvin-bot Bot requested a review from Pujan92 February 28, 2026 12:03

melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team February 28, 2026 12:03

melvin-bot Bot removed the request for review from a team February 28, 2026 12:03

Implement frozen-by-admin info and ask-to-unfreeze functionality

c550cf9

github-actions Bot reviewed Feb 28, 2026

View reviewed changes

Comment thread src/pages/settings/Wallet/ExpensifyCardPage/index.tsx Outdated

chatgpt-codex-connector Bot reviewed Feb 28, 2026

View reviewed changes

Comment thread src/pages/settings/Wallet/ExpensifyCardPage/index.tsx Outdated

Address comments

2b78bdb

joekaufmanexpensify previously approved these changes Mar 2, 2026

View reviewed changes

Merge main

5259ca6

ShridharGoel dismissed joekaufmanexpensify’s stale review via 5259ca6 March 4, 2026 12:41

ShridharGoel added 2 commits March 4, 2026 18:11

Merge main

2cef018

Prettier fix

1a3c1c8

Pass missing props from WorkspaceExpensifyCardDetailsPage

04d0574

Pujan92 reviewed Mar 6, 2026

View reviewed changes

Fix naming

4df6e50

ShridharGoel requested a review from Pujan92 March 6, 2026 12:57

Pujan92 approved these changes Mar 13, 2026

View reviewed changes

ShridharGoel added 3 commits March 18, 2026 12:40

Merge branch 'main' into freezeCard9

449f645

Show frozen card details in Expensify card list

e848cec

Upgrade React Native and Expo dependencies

8b7dedd

ShridharGoel added 4 commits March 23, 2026 01:07

Fix lint

d3fea6c

Enable for narrow layouts as well

a521cae

Update import path for resolveDetachReceiptConflicts

8ef5660

Update import path for clearCachedAttachments

86a7ee0

Merge branch 'main' of https://github.com/Expensify/App into freezeCard9

35775d3

Pujan92 reviewed Mar 23, 2026

View reviewed changes

Comment thread src/pages/workspace/expensifyCard/WorkspaceExpensifyCardListPage.tsx

Update text shown in card rows

7950bea

ShridharGoel added 2 commits March 24, 2026 00:02

Fix lint

8a03271

Merge branch 'main' of https://github.com/Expensify/App into freezeCard9

c224e07

MariaHCD approved these changes Mar 24, 2026

View reviewed changes

MariaHCD merged commit 0c95aa6 into Expensify:main Mar 24, 2026
32 checks passed

OSBotify mentioned this pull request Mar 24, 2026

Deploy Checklist: New Expensify 2026-03-24 #86199

Closed

53 tasks

jponikarchuk mentioned this pull request Mar 24, 2026

Web - Expensify card - Long display name in "This card was frozen by.." message is cut off #86260

Closed

7 tasks

melvin-bot Bot mentioned this pull request Mar 25, 2026

[Due for payment 2026-04-01] [Freeze Card - R2] “Ask to unfreeze” option with workspace chat navigation #81648

Closed

Conversation

ShridharGoel commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 28, 2026

Uh oh!

melvin-bot Bot commented Feb 28, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov Bot commented Feb 28, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ShridharGoel commented Feb 28, 2026

Uh oh!

chatgpt-codex-connector Bot commented Feb 28, 2026

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Pujan92 commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Pujan92 commented Mar 5, 2026

Uh oh!

ShridharGoel commented Mar 5, 2026

Uh oh!

Pujan92 commented Mar 6, 2026

Uh oh!

Pujan92 Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

ShridharGoel Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Pujan92 left a comment

Choose a reason for hiding this comment

Uh oh!

ShridharGoel commented Mar 13, 2026

Uh oh!

MariaHCD commented Mar 16, 2026

Uh oh!

Pujan92 commented Mar 17, 2026

Uh oh!

ShridharGoel commented Mar 22, 2026

Uh oh!

MariaHCD commented Mar 23, 2026

Uh oh!

ShridharGoel commented Mar 23, 2026

Uh oh!

Pujan92 commented Mar 23, 2026

Uh oh!

Uh oh!

MariaHCD commented Mar 23, 2026

Uh oh!

Uh oh!

github-actions Bot commented Mar 24, 2026

Uh oh!

github-actions Bot commented Mar 24, 2026

Uh oh!

OSBotify commented Mar 24, 2026

Uh oh!

OSBotify commented Mar 25, 2026

Uh oh!

Reviewers

Assignees

ShridharGoel commented Feb 28, 2026 •

edited

Loading

codecov Bot commented Feb 28, 2026 •

edited by github-actions Bot

Loading

Pujan92 commented Mar 4, 2026 •

edited

Loading