Skip to content

Fix: Pdf preview is not in centered #8474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luacmartins merged 2 commits into from
Apr 8, 2022
Merged

Fix: Pdf preview is not in centered #8474

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e0774d
Pdf preview is in centered
metehanozyurt Apr 4, 2022
957f38a
Added comment about 'display: grid'
metehanozyurt Apr 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/styles/styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1691,14 +1691,17 @@ const styles = {
backgroundColor: themeColors.modalBackground,
},
PDFView: {
flex: 1,
// `display: grid` is not supported in native platforms!
// It's being used on Web/Desktop only to vertically center short PDFs,
// while preventing the overflow of the top of long PDF files.
display: 'grid',

@luacmartins luacmartins Apr 4, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a comment here to avoid setting a bad example. Something like:

`display: grid` is not supported in native platforms! It's being used on Web/Desktop only to vertically center short PDFs, while preventing the overflow of the top of long PDF files.

backgroundColor: themeColors.modalBackground,
width: '100%',
height: '100%',
flexDirection: 'row',
justifyContent: 'center',
overflow: 'hidden',
overflowY: 'auto',
alignItems: 'center',
},

modalCenterContentContainer: {
Expand Down