Skip to content

[NoQA] Replace err-on-side-of-flagging with self-critique gate in code reviewer #85068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kacper-mikolajczak wants to merge 2 commits into from
Closed

[NoQA] Replace err-on-side-of-flagging with self-critique gate in code reviewer #85068

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76cb78e
Replace err-on-side-of-flagging with self-critique gate in code reviewer
kacper-mikolajczak Mar 12, 2026
7e140fa
Condense self-critique gate instruction
kacper-mikolajczak Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .claude/agents/code-inline-reviewer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@ Each rule file contains:
7. **Do NOT post comments, call scripts, or add reactions.** Only return the structured JSON.
8. **DO NOT invent new rules, stylistic preferences, or commentary outside the listed rules.**
9. **DO NOT describe what you are doing or add extra content.**
EXCEPTION: If you believe something MIGHT be a Rule violation but are uncertain, err on the side of including it in the violations array rather than skipping it.
10. **Self-critique gate - only include violations you are fully confident about.** When uncertain, omit entirely.
- Never include deliberation, self-correction, or hedging language (e.g., "actually", "upon re-reading", "wait", "however") in the `body` field. Each violation must state the issue as a definitive fact with a concrete fix.
- A violation that you would retract upon closer reading should never appear in the output.

## Comment Format

Expand Down
Loading