[NO QA] Add wildcard access to dynamic routes entryScreens#85940
Conversation
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
mananjadhav
left a comment
There was a problem hiding this comment.
I don't think we need a checklist for this one. I'll cover the usage of the changes in #84825
JmillsExpensify
left a comment
There was a problem hiding this comment.
No product review required.
|
🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.43-3 🚀
|
Explanation of Change
Add wildcard (
'*') support for dynamic routeentryScreens. WhenentryScreensis set to['*'], the dynamic route is accessible from any screen, bypassing per-screen authorization. TheDynamicRouteConfigtype is updated to accept'*',getStateFromPathuses.some()for the check, and documentation/tests are added.Fixed Issues
$ #85935
Tests
No QA
Offline tests
No QA
QA Steps
No QA
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos