Skip to content

Move Onyx.connect() usage for ONYXKEYS.COLLECTION.POLICY_TAGS from getSendInvoiceInformation to sendInvoice in src/libs/actions/IOU/SendInvoice.ts #86322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Valforte merged 10 commits into from
Apr 1, 2026
Merged

Move Onyx.connect() usage for ONYXKEYS.COLLECTION.POLICY_TAGS from getSendInvoiceInformation to sendInvoice in src/libs/actions/IOU/SendInvoice.ts #86322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4a7a359
remove onyx.connect from getSendInvoiceInformation
jakubstec Mar 25, 2026
a1d6b8c
remove onyx.connect from getSendInvoiceInformation part2
jakubstec Mar 25, 2026
0da27b6
add tests to getSendInvoiceInformation()
jakubstec Mar 25, 2026
8f7767c
refactor getSendInvoiceInformation() tests
jakubstec Mar 26, 2026
c0c90ec
apply changes based on the review
jakubstec Mar 30, 2026
31d51cb
resolve merge conflicts
jakubstec Mar 30, 2026
6a8855d
fix eslint, typecheck, spelling errors
jakubstec Mar 30, 2026
4944f31
add review changes
jakubstec Mar 31, 2026
0f546e3
replace name participantsPolicyTags with senderPolicyTags in SendInvo…
jakubstec Mar 31, 2026
3563ffc
Merge remote-tracking branch 'origin/main' into jakubstec/remove-onyx…
jakubstec Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/libs/actions/IOU/SendInvoice.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,7 +598,8 @@ function getSendInvoiceInformation({
companyWebsite,
policyRecentlyUsedCategories,
policyRecentlyUsedTags,
}: SendInvoiceOptions): SendInvoiceInformation {
senderPolicyTags,
}: SendInvoiceOptions & {senderPolicyTags: OnyxTypes.PolicyTagLists}): SendInvoiceInformation {
const {amount = 0, currency = '', created = '', merchant = '', category = '', tag = '', taxCode = '', taxAmount = 0, taxValue, billable, comment, participants} = transaction ?? {};
const trimmedComment = (comment?.comment ?? '').trim();
const senderWorkspaceID = participants?.find((participant) => participant?.isSender)?.policyID;
Expand Down Expand Up @@ -654,9 +655,7 @@ function getSendInvoiceInformation({

const optimisticPolicyRecentlyUsedCategories = mergePolicyRecentlyUsedCategories(category, policyRecentlyUsedCategories);
const optimisticPolicyRecentlyUsedTags = buildOptimisticPolicyRecentlyUsedTags({
// TODO: remove `allPolicyTags` from this file https://github.com/Expensify/App/issues/80048
// eslint-disable-next-line @typescript-eslint/no-deprecated
policyTags: getPolicyTagsData(optimisticInvoiceReport.policyID),
policyTags: senderPolicyTags,
policyRecentlyUsedTags,
transactionTags: tag,
});
Expand Down Expand Up @@ -745,6 +744,10 @@ function sendInvoice({
policyRecentlyUsedTags,
isFromGlobalCreate,
}: SendInvoiceOptions) {
// TODO: remove `allPolicyTags` from this file https://github.com/Expensify/App/issues/80048
// eslint-disable-next-line @typescript-eslint/no-deprecated
Comment thread
jakubstec marked this conversation as resolved.
const senderPolicyTags = getPolicyTagsData(transaction?.participants?.find((p) => p?.isSender)?.policyID) ?? {};

const parsedComment = getParsedComment(transaction?.comment?.comment?.trim() ?? '');
if (transaction?.comment) {
// eslint-disable-next-line no-param-reassign
Expand Down Expand Up @@ -777,6 +780,7 @@ function sendInvoice({
companyWebsite,
policyRecentlyUsedCategories,
policyRecentlyUsedTags,
senderPolicyTags,
});

const parameters: SendInvoiceParams = {
Expand Down
Loading
Loading