Skip to content

[No QA] perf: remove unused policyMemberAccountIDs from sidebar context #86323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JS00001 merged 1 commit into from
Mar 25, 2026
Merged

[No QA] perf: remove unused policyMemberAccountIDs from sidebar context #86323

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions src/hooks/useSidebarOrderedReports.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import React, {createContext, useCallback, useContext, useEffect, useMemo, useRe
import type {OnyxEntry} from 'react-native-onyx';
import Log from '@libs/Log';
import {getTransactionThreadReportID} from '@libs/MergeTransactionUtils';
import {getPolicyEmployeeListByIdWithoutCurrentUser} from '@libs/PolicyUtils';
import {isOneTransactionReport} from '@libs/ReportUtils';
import SidebarUtils from '@libs/SidebarUtils';
import CONST from '@src/CONST';
Expand Down Expand Up @@ -31,7 +30,6 @@ type SidebarOrderedReportsStateContextValue = {
orderedReports: OnyxTypes.Report[];
orderedReportIDs: string[];
currentReportID: string | undefined;
policyMemberAccountIDs: number[];
};

type SidebarOrderedReportsActionsContextValue = {
Expand All @@ -44,7 +42,6 @@ const SidebarOrderedReportsStateContext = createContext<SidebarOrderedReportsSta
orderedReports: [],
orderedReportIDs: [],
currentReportID: '',
policyMemberAccountIDs: [],
});

const SidebarOrderedReportsActionsContext = createContext<SidebarOrderedReportsActionsContextValue>({
Expand Down Expand Up @@ -93,7 +90,6 @@ function SidebarOrderedReportsContextProvider({
// I don't like it either, but clearing the cache is only a hack for the debug modal and I will endeavor to make it better as I work to improve the cache correctness of the LHN more broadly
const [clearCacheDummyCounter, setClearCacheDummyCounter] = useState(0);

const policyMemberAccountIDs = useMemo(() => getPolicyEmployeeListByIdWithoutCurrentUser(policies, undefined, accountID), [policies, accountID]);
const prevBetas = usePrevious(betas);
const prevPriorityMode = usePrevious(priorityMode);

Expand Down Expand Up @@ -305,17 +301,15 @@ function SidebarOrderedReportsContextProvider({
orderedReports: updatedReports,
orderedReportIDs: updatedReportIDs,
currentReportID: derivedCurrentReportID,
policyMemberAccountIDs,
};
}

return {
orderedReports,
orderedReportIDs,
currentReportID: derivedCurrentReportID,
policyMemberAccountIDs,
};
}, [getOrderedReportIDs, orderedReportIDs, derivedCurrentReportID, policyMemberAccountIDs, shouldUseNarrowLayout, getOrderedReports, orderedReports]);
}, [getOrderedReportIDs, orderedReportIDs, derivedCurrentReportID, shouldUseNarrowLayout, getOrderedReports, orderedReports]);

const actionsValue: SidebarOrderedReportsActionsContextValue = useMemo(() => ({clearLHNCache}), [clearLHNCache]);

Expand All @@ -334,7 +328,6 @@ function SidebarOrderedReportsContextProvider({
currentReportIDValue,
derivedCurrentReportID,
prevDerivedCurrentReportID,
policyMemberAccountIDs,
prevBetas,
prevPriorityMode,
reportsToDisplayInLHN,
Expand Down
Loading