Skip to content

[No QA] fix: Remove duplicate useOnyx subscription and redundant hook call in LHN #86956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JS00001 merged 2 commits into from
Apr 2, 2026
Merged

[No QA] fix: Remove duplicate useOnyx subscription and redundant hook call in LHN #86956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9c0abe
fix: remove duplicate useOnyx subscription and redundant hook call in…
BartekObudzinski Apr 2, 2026
4ab48d2
fix: replace deprecated absoluteFillObject with absoluteFill
BartekObudzinski Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/components/LHNOptionsList/OptionRowLHNData.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ function OptionRowLHNData({
const [conciergeReportID] = useOnyx(ONYXKEYS.CONCIERGE_REPORT_ID);
const {login} = useCurrentUserPersonalDetails();
const [policyTags] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${fullReport?.policyID}`);
const [fullReportActions] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${fullReport?.reportID}`);

const card = useGetExpensifyCardFromReportAction({reportAction: lastAction, policyID: fullReport?.policyID});

Expand Down Expand Up @@ -157,7 +156,7 @@ function OptionRowLHNData({
reportAttributesDerived,
policyTags,
currentUserLogin: login ?? '',
reportActions: fullReportActions,
reportActions,
});

// For single-sender IOUs, trim to the sender's avatar to match the header.
Expand Down
5 changes: 1 addition & 4 deletions src/pages/inbox/sidebar/SidebarLinks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import type {EdgeInsets} from 'react-native-safe-area-context';
import type {ValueOf} from 'type-fest';
import LHNOptionsList from '@components/LHNOptionsList/LHNOptionsList';
import OptionsListSkeletonView from '@components/OptionsListSkeletonView';
import useConfirmReadyToOpenApp from '@hooks/useConfirmReadyToOpenApp';
import useOnyx from '@hooks/useOnyx';
import useResponsiveLayout from '@hooks/useResponsiveLayout';
import useStyleUtils from '@hooks/useStyleUtils';
Expand Down Expand Up @@ -41,8 +40,6 @@ function SidebarLinks({insets, optionListItems, priorityMode = CONST.PRIORITY_MO
const {shouldUseNarrowLayout} = useResponsiveLayout();
const [isLoadingReportData = true] = useOnyx(ONYXKEYS.IS_LOADING_REPORT_DATA);

useConfirmReadyToOpenApp();

@JS00001 JS00001 Apr 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this removed?

@BartekObudzinski BartekObudzinski Apr 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useConfirmReadyToOpenApp() is already called in BaseSidebarScreen (the parent component), so this was a duplicate invocation. The hook only needs to run once per screen.

@JS00001 JS00001 Apr 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that in the description, sorry haha


useEffect(() => {
ReportActionContextMenu.hideContextMenu(false);
// eslint-disable-next-line react-hooks/exhaustive-deps
Expand Down Expand Up @@ -100,7 +97,7 @@ function SidebarLinks({insets, optionListItems, priorityMode = CONST.PRIORITY_MO
onFirstItemRendered={setSidebarLoaded}
/>
{isLoadingReportData && optionListItems?.length === 0 && (
<View style={[StyleSheet.absoluteFillObject, styles.appBG, styles.mt3]}>
<View style={[StyleSheet.absoluteFill, styles.appBG, styles.mt3]}>
<OptionsListSkeletonView
shouldAnimate
reasonAttributes={sidebarSkeletonReasonAttributes}
Expand Down
Loading