QBD - fix: The workspace with a connection error is still listed as reusable by lakchote · Pull Request #87468 · Expensify/App

lakchote · 2026-04-09T08:48:23Z

Explanation of Change

The QuickBooks Desktop reuse existing connections flow treated any admin workspace with a QBD connection as reusable, so a workspace could appear in the Existing connections list even when that workspace's QBD connection was in an error state.

Fixed Issues

$ #87457
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Preconditions: Have a workspace with the Accounting feature enabled with the next error connection: Can't connect to QuickBooks Desktop ("Data sync did not complete, please make sure the Web Connector is running and try again later.")
Steps to reach this condition:

Go to workspace settings > Accounting
Click Connect, next to QuickBooks Desktop
Click Done

Steps:

Navigate to https://staging.new.expensify.com/
Log in as a workspace admin
Go to workspace settings > Accounting
Click on the three dots button > Reinstall connector

Expected Result:

Below the Existing connections section, workspaces with a connection error should not appear as reusable.
Also, only other workspaces should be available, not the self workspace.

Video test

Screen.Recording.2026-04-09.at.10.43.09.mov

Offline tests

NA

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

Same as in tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-04-09T08:48:56Z

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-04-09T09:08:39Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...omponents/ConnectToQuickbooksDesktopFlow/index.tsx	`100.00% <100.00%> (+12.50%)`	⬆️
...s/workspace/accounting/AccountingContext/index.tsx	`0.00% <ø> (ø)`
src/selectors/Policy.ts	`67.07% <100.00%> (+3.07%)`	⬆️
...ages/workspace/accounting/PolicyAccountingPage.tsx	`0.00% <0.00%> (ø)`
...g/qbd/QuickbooksDesktopExistingConnectionsPage.tsx	`0.00% <0.00%> (ø)`
src/hooks/useReusablePoliciesConnectedToQBD.ts	`0.00% <0.00%> (ø)`
... and 46 files with indirect coverage changes

ahmedGaber93 · 2026-04-09T12:54:44Z

@lakchote Do we consider this a bug? I see in the code the other accounting integrations not block reusing if it has sync error.

I think "copy integration" should still work even if we have a sync error.

ahmedGaber93 · 2026-04-09T13:08:43Z

Bug: Workspace is displayed on reuse list even it not synced yet, after synced and failed it disappear.

20260409151700262.mp4

lakchote · 2026-04-09T14:01:37Z

Bug: Workspace is displayed on reuse list even it not synced yet, after synced and failed it disappear.

@ahmedGaber93 this has been handled

ahmedGaber93 · 2026-04-09T14:53:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

20260409164447731.mp4

melvin-bot · 2026-04-09T14:55:16Z

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

francoisl

Going to approve as it's fixing a blocker(ish), we can address the 2 comments as follow-up if needed.

francoisl · 2026-04-09T15:39:23Z

 import ScreenWrapper from '@components/ScreenWrapper';
 import ScrollView from '@components/ScrollView';
 import Text from '@components/Text';
-import useAdminPoliciesConnectedToQBD from '@hooks/useAdminPoliciesConnectedToQBD';


Do we still need that hook anywhere at all?

francoisl · 2026-04-09T15:40:33Z

 function PolicyAccountingPage({policy}: PolicyAccountingPageProps) {
    useWorkspaceDocumentTitle(policy?.name, 'workspace.common.accounting');
    const hasPoliciesConnectedToSageIntacct = useHasPoliciesConnectedToSageIntacct();
-    const hasPoliciesConnectedToQBD = useHasPoliciesConnectedToQBD();


Same thing for this hook, do we still need it anywhere?

francoisl · 2026-04-09T15:45:03Z

^Sent you a cleanup PR Lucien #87512

github-actions · 2026-04-09T15:46:26Z

🚧 @francoisl has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-09T15:51:26Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #87468.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-a41990f-b0990c7-6d19a789025720ce9b279fd461cca7e90674add1/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-a41990f-b0990c7-7769e75afc832ceb494d147f4334bb187b08273c/index.html

Web 🕸️
https://87468.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-10T08:26:40Z

🚀 Deployed to staging by https://github.com/francoisl in version: 9.3.58-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-10T08:28:06Z

I reviewed the changes in this PR against the help site files under App/docs/articles.

This PR is a bug fix that filters out QuickBooks Desktop workspaces with connection errors (and the current workspace) from the "Existing connections" reuse list. It changes internal filtering logic only — no user-facing feature names, UI labels, navigation steps, or workflows documented in the help site are affected.

The relevant help article (docs/articles/new-expensify/connections/quickbooks-desktop/Connect-to-QuickBooks-Desktop.md) covers the initial QBD setup flow but does not reference the "existing connections" reuse feature, so no updates are needed there either.

No help site changes are required for this PR.

OSBotify · 2026-04-13T20:21:36Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.3.58-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2026-04-13T20:57:27Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.3.58-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

lakchote added 8 commits April 9, 2026 08:58

add reusable qbd selectors

f70d496

add hook

289ae49

fix qbd reuse routing in flow

8743ae0

fix qbd reuse list filtering

1e1db3c

update qbd reuse check in context

08818ed

update qbd reuse check in page

c85d32f

add test for qbd reuse flow

9ce00f4

add test for qbd reusable selector

a3a3303

lakchote self-assigned this Apr 9, 2026

lakchote marked this pull request as ready for review April 9, 2026 08:48

lakchote requested review from a team as code owners April 9, 2026 08:48

melvin-bot Bot requested review from ahmedGaber93 and joekaufmanexpensify and removed request for a team April 9, 2026 08:48

melvin-bot Bot removed the request for review from a team April 9, 2026 08:48

lakchote mentioned this pull request Apr 9, 2026

[Due for payment 2026-04-20] QBD - The self workspace with a connection error is still listed as reusable #87457

Closed

7 tasks

lakchote added 2 commits April 9, 2026 10:52

fix style

146af0b

fix test key naming in

6fe3e62

lakchote added 2 commits April 9, 2026 16:00

update qbd reuse hook filter

a499b59

fix qbd reusable selector

8204202

lakchote changed the title ~~[CP Staging] QBD - fix: The workspace with a connection error is still listed as reusable~~ QBD - fix: The workspace with a connection error is still listed as reusable Apr 9, 2026

ahmedGaber93 approved these changes Apr 9, 2026

View reviewed changes

melvin-bot Bot requested a review from srikarparsi April 9, 2026 14:55

francoisl approved these changes Apr 9, 2026

View reviewed changes

francoisl merged commit a41990f into main Apr 9, 2026
37 checks passed

francoisl deleted the lucien/fixes-qbd-reuse-connection branch April 9, 2026 15:41

francoisl mentioned this pull request Apr 9, 2026

[NoQA] Remove unused hooks #87512

Merged

52 tasks

OSBotify mentioned this pull request Apr 10, 2026

Deploy Checklist: New Expensify 2026-04-10 #87562

Closed

87 tasks

MelvinBot mentioned this pull request Apr 14, 2026

Steph's chat with Melvin #87829

Closed

lakchote mentioned this pull request Apr 24, 2026

Exclude broken reusable connections for NetSuite/Sage Intacct #88445

Merged

52 tasks

Conversation

lakchote commented Apr 9, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Expected Result:

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 9, 2026

Uh oh!

codecov Bot commented Apr 9, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ahmedGaber93 commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahmedGaber93 commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lakchote commented Apr 9, 2026

Uh oh!

ahmedGaber93 commented Apr 9, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 9, 2026

Uh oh!

francoisl left a comment

Choose a reason for hiding this comment

Uh oh!

francoisl Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

francoisl Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

francoisl commented Apr 9, 2026

Uh oh!

github-actions Bot commented Apr 9, 2026

Uh oh!

github-actions Bot commented Apr 9, 2026

Uh oh!

OSBotify commented Apr 10, 2026

Uh oh!

MelvinBot commented Apr 10, 2026

Uh oh!

OSBotify commented Apr 13, 2026

Uh oh!

OSBotify commented Apr 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lakchote commented Apr 9, 2026 •

edited by github-actions Bot

Loading

codecov Bot commented Apr 9, 2026 •

edited by github-actions Bot

Loading

ahmedGaber93 commented Apr 9, 2026 •

edited

Loading

ahmedGaber93 commented Apr 9, 2026 •

edited

Loading