Fix case-sensitive CSV import disabling categories and tags#87748
Conversation
The CSV export writes the enabled field with mixed casing (e.g. TRUE, True) but the import parser used strict === 'true' comparison, causing all re-imported categories and tags to become disabled. Co-authored-by: Sobit Neupane <sobitneupane@users.noreply.github.com>
|
I created this PR from an upstream branch since I don't have push access to your fork. To take ownership of this branch and be able to push updates, run: Then you can close this PR and open a new one from your fork. |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
| return { | ||
| name, | ||
| enabled: categoriesEnabledColumn !== -1 ? categoriesEnabled?.[containsHeader ? index + 1 : index] === 'true' : true, | ||
| enabled: categoriesEnabledColumn !== -1 ? String(categoriesEnabled?.[containsHeader ? index + 1 : index]).toLowerCase() === 'true' : true, |
There was a problem hiding this comment.
@MelvinBot Should we trim the string before lowercasing it to cover edge cases involving whitespace?
There was a problem hiding this comment.
Good catch. The XLSX library is used with raw: true (ImportSpreadsheet.tsx:124), which preserves raw string values from the CSV without trimming. If a user manually edits the CSV and introduces leading/trailing whitespace (e.g., " TRUE "), .toLowerCase() alone would produce " true " which wouldn't match 'true'. Added .trim() before .toLowerCase() in both files — pushed in d9ad730.
…ield Co-authored-by: Sobit Neupane <sobitneupane@users.noreply.github.com>
|
@MelvinBot Mark the PR "Ready for review" |
|
I attempted to mark this PR as "Ready for review" but the command was blocked by environment permissions. You can mark it ready yourself by running: Or by clicking "Ready for review" on the PR page. |
|
@MelvinBot Please mark it "Ready for review" |
|
Done — this PR has been marked as Ready for review. |
melvin-bot
Bot
requested review from
sobitneupane
and removed request for
a team
|
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@MelvinBot Please resolve the merge conflicts. |
melvin-bot
Bot
requested review from
trjExpensify
and removed request for
a team
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Combined our trim() fix with main's addition of 'yes' as a valid enabled value, so the enabled field now accepts 'true'/'yes' with any casing and surrounding whitespace. Co-authored-by: Sobit Neupane <sobitneupane@users.noreply.github.com>
|
Resolved the merge conflicts by merging |
|
@madmax330 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@sobitneupane can you address the AI reviewer comments? |
There was a problem hiding this comment.
Screenshots/Videos
Android: HybridApp
Screen.Recording.2026-04-28.at.16.53.51.mov
Android: mWeb Chrome
Screen.Recording.2026-04-28.at.16.55.08.mov
iOS: HybridApp
Screen.Recording.2026-04-28.at.16.38.04.mov
Screen.Recording.2026-04-28.at.16.39.45.mov
iOS: mWeb Safari
Screen.Recording.2026-04-28.at.16.40.59.mov
MacOS: Chrome / Safari
Screen.Recording.2026-04-28.at.16.09.49.mov
Screen.Recording.2026-04-28.at.16.15.22.mov
|
@madmax330 The review comments got addressed in the latest merge commit. So, no action needed. |
There was a problem hiding this comment.
Pull request overview
Fixes a CSV re-import edge case where the enabled column value may include casing/formatting variations, ensuring categories and tags remain enabled after re-import.
Changes:
- Normalize imported
enabledcell values by trimming whitespace before lowercasing for tags. - Normalize imported
enabledcell values by trimming whitespace before lowercasing for categories.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/pages/workspace/tags/ImportedTagsPage.tsx | Trims and lowercases imported enabled values before checking truthy strings. |
| src/pages/workspace/categories/ImportedCategoriesPage.tsx | Trims and lowercases imported enabled values before checking truthy strings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| return { | ||
| name, | ||
| enabled: categoriesEnabledColumn !== -1 ? ['true', 'yes'].includes(categoriesEnabled?.[containsHeader ? index + 1 : index]?.toString().toLowerCase() ?? '') : true, | ||
| enabled: categoriesEnabledColumn !== -1 ? ['true', 'yes'].includes(categoriesEnabled?.[containsHeader ? index + 1 : index]?.toString().trim().toLowerCase() ?? '') : true, |
There was a problem hiding this comment.
The PR description/title mention fixing a case-sensitivity issue, but this code was already normalizing with .toLowerCase() before. The actual behavior change here is trimming whitespace before the comparison, so it would be good to update the PR description/title to match (and/or add a note that exported CSV values may include surrounding whitespace).
sobitneupane
left a comment
sobitneupane
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
- I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel and/or tagged@Expensify/designso the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
- If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
|
🚧 @madmax330 has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/madmax330 in version: 9.3.65-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. The fix adds I reviewed both relevant help articles:
Since the docs don't document specific accepted values for the |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.65-6 🚀
|
Explanation of Change
The CSV export writes the
enabledfield with mixed casing (e.g.TRUE,True), but the import parser used a strict=== 'true'comparison. This caused all re-imported categories and tags to become disabled because'TRUE' === 'true'evaluates tofalse.This PR wraps the value in
String(...).toLowerCase()before comparing, so any casing variant (TRUE,True,true) is correctly recognized as enabled.Fixed Issues
$ #87033
PROPOSAL: #87033 (comment)
Tests
TRUE(orTrue) for enabled categoriesOffline tests
N/A — CSV import requires an active connection to fetch the spreadsheet data.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A — no UI changes
Android: mWeb Chrome
N/A — no UI changes
iOS: Native
N/A — no UI changes
iOS: mWeb Safari
N/A — no UI changes
MacOS: Chrome / Safari
N/A — no UI changes