Skip to content

Give buttons more space in the preferences page#8789

Merged
arosiclair merged 1 commit into
mainfrom
tgolen-fix-invalidate-button
Apr 27, 2022
Merged

Give buttons more space in the preferences page#8789
arosiclair merged 1 commit into
mainfrom
tgolen-fix-invalidate-button

Conversation

@tgolen

@tgolen tgolen commented Apr 26, 2022

Copy link
Copy Markdown
Contributor

Details

The buttons didn't quite have enough room to display full text

Fixed Issues

$ #8783

Tests

  1. For testing locally, you must modify this code to get access to the options. Change it to DEV (or delete the logic)
  2. Go to User settings > Preferences
  3. Verify the full buttons can be seen for "Invalidate"

QA Steps

  1. Go to User settings > Preferences
  2. Verify the full buttons can be seen for "Invalidate"
  • Verify that no errors appear in the JS console

Screenshots

Web

Mobile Web

image

Desktop

image

iOS

image

Android

I am having troubles getting my emulator to launch

@tgolen tgolen requested a review from a team as a code owner April 26, 2022 21:03
@tgolen tgolen self-assigned this Apr 26, 2022
@melvin-bot melvin-bot Bot requested review from arosiclair and removed request for a team April 26, 2022 21:04
@arosiclair arosiclair merged commit 26c6e3b into main Apr 27, 2022
@arosiclair arosiclair deleted the tgolen-fix-invalidate-button branch April 27, 2022 14:12
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented May 9, 2022

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by @sketchydroide in version: 1.1.57-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.57-17 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants