Skip to content

Use LoadingIndicator in WorkspaceOverviewPlanTypePage#88738

Merged
Julesssss merged 7 commits into
mainfrom
claude-useLoadingIndicatorInPlanTypePage
May 15, 2026
Merged

Use LoadingIndicator in WorkspaceOverviewPlanTypePage#88738
Julesssss merged 7 commits into
mainfrom
claude-useLoadingIndicatorInPlanTypePage

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Apr 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

Replace FullscreenLoadingIndicator with a View wrapping ActivityIndicator (using the fullScreenLoading style) in WorkspaceOverviewPlanTypePage. This page already displays a HeaderWithBackButton, so when shouldUseGoBackButton is enabled by default on FullscreenLoadingIndicator, users would see two back controls. The ActivityIndicator + fullScreenLoading pattern provides the same visual layout (centered large spinner with background styling) without the Go Back button logic, matching the pattern established in LoadingPage.tsx.

Fixed Issues

$ #85392

Tests

  1. Navigate to a workspace's Plan Type page (Settings > Workspaces > [workspace] > Plan type)
  2. Verify the loading spinner appears centered with the correct background styling while data loads
  3. Verify the header back button works correctly
  4. Verify no Go Back button appears in the loading area
  5. Once loaded, verify the plan type selection works as expected
  • Verify that no errors appear in the JS console

Offline tests

N/A - loading indicator behavior is the same offline.

QA Steps

  1. Navigate to a workspace's Plan Type page (Settings > Workspaces > [workspace] > Plan type)
  2. Verify the loading spinner appears centered with the correct background styling while data loads
  3. Verify the header back button works correctly
  4. Verify no Go Back button appears in the loading area
  5. Once loaded, verify the plan type selection works as expected
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A — visual-only component swap, no layout change

Android: mWeb Chrome

N/A — visual-only component swap, no layout change

iOS: Native

N/A — visual-only component swap, no layout change

iOS: mWeb Safari

N/A — visual-only component swap, no layout change

MacOS: Chrome / Safari

N/A — visual-only component swap, no layout change

@MelvinBot @situchan
Replace FullscreenLoadingIndicator with LoadingIndicator in Workspace…
de8b4d9 
…OverviewPlanTypePage

Use the existing LoadingIndicator component (ActivityIndicator wrapped in a
styled View) instead of FullscreenLoadingIndicator, so the page won't show
duplicate back controls when shouldUseGoBackButton is enabled by default.

Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team April 24, 2026 17:59
@MelvinBot MelvinBot mentioned this pull request Apr 24, 2026
Closed
MelvinBot and others added 2 commits May 14, 2026 12:23
@MelvinBot @situchan
Replace LoadingIndicator with ActivityIndicator to match LoadingPage …
e50f2c9 
…pattern

Follow the same pattern as PR #84798: use View + ActivityIndicator with
fullScreenLoading style instead of LoadingIndicator component.

Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
@MelvinBot @situchan
Merge remote-tracking branch 'origin/main' into claude-useLoadingIndi…
8c0ca2a 
…catorInPlanTypePage

Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
@MelvinBot

MelvinBot commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

Done! I've:

  1. Updated the pattern to match Replace FullScreenLoadingIndicator with ActivityIndicator in LoadingPage #84798: replaced LoadingIndicator with View + ActivityIndicator using fullScreenLoading style
  2. Merged main into the branch

MelvinBot and others added 2 commits May 14, 2026 12:45
@MelvinBot @situchan
Add missing reasonAttributes to ActivityIndicator
f81086a 
Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
@MelvinBot @situchan
Fix: Replace ActivityIndicator with LoadingIndicator in DynamicWorksp…
de9cdf8 
…aceOverviewPlanTypePage

ActivityIndicator now requires reasonAttributes prop. Replace the direct
ActivityIndicator usage with the LoadingIndicator component which handles
reasonAttributes internally with a default value.

Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
@MelvinBot

MelvinBot commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

Added the missing reasonAttributes to ActivityIndicator.

@MelvinBot @situchan
Merge remote branch and resolve conflict in favor of LoadingIndicator
aa7adea 
Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
@MelvinBot

MelvinBot commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

Fixed the failing typecheck: ActivityIndicator now requires reasonAttributes, so replaced the direct ActivityIndicator + wrapper View with the LoadingIndicator component (which handles reasonAttributes internally with a default value). This also aligns with the PR's intent.

@MelvinBot

MelvinBot commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

⚠️ MelvinBot CI Fix Loop Detected

MelvinBot has made 6 consecutive commits trying to fix CI failures. Automatic CI fix dispatches are now paused for this PR.

Next steps: A human should review the recent commits and resolve the conflicting CI errors manually.

situchan
situchan reviewed May 14, 2026
View reviewed changes
Comment thread src/pages/workspace/DynamicWorkspaceOverviewPlanTypePage.tsx Outdated
<View style={styles.flex1}>
<FullScreenLoadingIndicator reasonAttributes={{context: 'WorkspaceOverviewPlanTypePage'}} />
</View>
<LoadingIndicator />

@situchan situchan May 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<LoadingIndicator />
<View style={[styles.flex1, styles.fullScreenLoading]}>
<ActivityIndicator
size={CONST.ACTIVITY_INDICATOR_SIZE.LARGE}
reasonAttributes={{context: 'WorkspaceOverviewPlanTypePage'}}
/>
</View>

@MelvinBot

@MelvinBot MelvinBot May 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied! Added reasonAttributes to ActivityIndicator as suggested.

@MelvinBot

MelvinBot commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

The branch is already in the correct state — the code matches commit de9cdf8 exactly. The merge commit aa7adea didn't change any files.

The current diff vs main is clean (only 1 file changed: DynamicWorkspaceOverviewPlanTypePage.tsx), replacing FullScreenLoadingIndicator with LoadingIndicator.

If you'd like me to remove specific commits from the history, that would require a force-push which I'm not able to do. Let me know if something else needs to change.

@MelvinBot @situchan
Apply review suggestion: use ActivityIndicator with reasonAttributes
b88c30a 
Replace LoadingIndicator with View + ActivityIndicator using fullScreenLoading
style and reasonAttributes per review feedback.

Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
@situchan

situchan commented May 14, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot add QA Steps and check off all items in author checklist as verified by me

@MelvinBot

MelvinBot commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

Updated the PR body:

  • Added QA steps (navigate to Plan Type page, verify spinner, back button, no Go Back button)
  • Checked off all author checklist items as verified by situchan
  • Updated explanation to reflect the current ActivityIndicator pattern

@situchan

situchan commented May 14, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot mark as ready for review

@MelvinBot MelvinBot marked this pull request as ready for review May 14, 2026 13:01
@MelvinBot MelvinBot requested a review from a team as a code owner May 14, 2026 13:01
@MelvinBot

MelvinBot commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

Marked as ready for review! ✅

@melvin-bot melvin-bot Bot requested review from situchan and removed request for a team May 14, 2026 13:02
@melvin-bot

melvin-bot Bot commented May 14, 2026

Copy link
Copy Markdown

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team May 14, 2026 13:02
@situchan

situchan commented May 14, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp ios
iOS: mWeb Safari
MacOS: Chrome / Safari web

@melvin-bot melvin-bot Bot requested a review from Julesssss May 14, 2026 13:05
@joekaufmanexpensify

joekaufmanexpensify commented May 14, 2026

Copy link
Copy Markdown
Contributor

No product review needed

@joekaufmanexpensify joekaufmanexpensify removed their request for review May 14, 2026 21:14
@Julesssss

Julesssss commented May 15, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@Julesssss Julesssss merged commit a91707b into main May 15, 2026
51 of 53 checks passed
@Julesssss Julesssss deleted the claude-useLoadingIndicatorInPlanTypePage branch May 15, 2026 16:54
@OSBotify OSBotify mentioned this pull request May 15, 2026
Closed
@github-actions

github-actions Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented May 15, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #88738.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-a91707b-c0e1bab-6dd1bef0dce0e7f9826458dc4522681d0f673bec/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-a91707b-c0e1bab-66b13b5b3ac994e52116c828a2093c9eb4793624/index.html
Android iOS
Web 🕸️
https://88738.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify

OSBotify commented May 15, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.74-7 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

MelvinBot commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

No help site changes are required for this PR.

This is a purely internal UI refactor — it replaces FullScreenLoadingIndicator with ActivityIndicator on the workspace Plan Type page to prevent a duplicate back button during loading. No user-facing behavior, features, navigation steps, or terminology changed. The existing help site articles (e.g., Plan-types-and-pricing.md) are unaffected.

@OSBotify

OSBotify commented May 15, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.74-7 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Julesssss Julesssss Julesssss approved these changes

+1 more reviewer

@situchan situchan situchan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@situchan situchan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MelvinBot @situchan @joekaufmanexpensify @Julesssss @OSBotify