perf: defer ReportScreen mount on wide layout to speed up Inbox tab navigation#88937
Closed
BartekObudzinski wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Closing — the span improvement (605→116ms) was largely a measurement artifact. Deferring ReportScreen mount made the LHN paint faster but caused the chat to appear visibly later than before. Need a different approach (reduce ReportScreen mount cost itself, not shuffle it outside the span window). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The
ReportsSplitNavigatormounts both the LHN sidebar (BaseSidebarScreen) and the centralReportScreenin the same render tick. On wide layout this meansReportScreencompetes with the LHN for JS frame budget during theManualNavigateToInboxTabspan — the time from BottomTab click to LHN layout completion.This change wraps the central
ReportScreeninNavigationDeferredMount(the component introduced in #88522) so on wide layout it hydrates after the navigation transition completes, insidestartTransition. The LHN paints first and ends the span;ReportScreenmounts non-urgently afterward. On narrow layout (shouldUseNarrowLayoutis true), the wrapper is bypassed andReportScreenrenders immediately as before — narrow layout only mountsReportScreenin response to a user tap, where deferral would be wrong.Measured impact (web wide, dev environment)
Scope
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari