Skip to content

[Payment due @eVoloshchak] Share transaction thread on create with submitter #88985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roryabraham merged 5 commits into from
Apr 29, 2026
+7 −1
Merged

[Payment due @eVoloshchak] Share transaction thread on create with submitter #88985

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
010aa5b
warn about travel data on domain delete
s77rt Apr 26, 2026
f2fa2ab
pass submitter in OpenReport when creating transaction thread to shar…
s77rt Apr 27, 2026
9ed60f0
revert unintended change
s77rt Apr 27, 2026
e3f417e
Merge branch 'main' into create-transaction-thread-share-with-submitter
s77rt Apr 29, 2026
866660c
do not include your email as submitter twice
s77rt Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/libs/actions/Report/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1967,10 +1967,16 @@ function createTransactionThreadReport(
const optimisticTransactionThreadReportID = generateReportID();
const optimisticTransactionThread = buildTransactionThread(iouReportAction, reportToUse, undefined, optimisticTransactionThreadReportID);
const shouldAddPendingFields = transaction?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD || iouReportAction?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD;
const participantAccountIDsForDetails = [currentUserAccountID];
if (iouReportAction?.actorAccountID && iouReportAction.actorAccountID !== currentUserAccountID) {
participantAccountIDsForDetails.push(iouReportAction.actorAccountID);
}
const participantLogins = PersonalDetailsUtils.getLoginsByAccountIDs(participantAccountIDsForDetails);
const participants = buildParticipantInfoFromLogins(participantLogins);
Comment thread
s77rt marked this conversation as resolved.
openReport({
reportID: optimisticTransactionThreadReportID,
introSelected,
participants: currentUserLogin ? [{login: currentUserLogin, accountID: currentUserAccountID}] : [],
participants,
// TODO: allPersonalDetails fallback should be removed in follow-up PRs https://github.com/Expensify/App/issues/73656
personalDetails: personalDetails ?? allPersonalDetails,
newReportObject: optimisticTransactionThread,
Expand Down
Loading