Skip to content

Fix: Maximum character limit error message cuts off if composer expanded #89041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristipaval merged 2 commits into from
Apr 28, 2026
Merged

Fix: Maximum character limit error message cuts off if composer expanded #89041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0259f2
move Offline block to outside
DylanDylann Apr 28, 2026
1b553f3
remove redundant
DylanDylann Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 11 additions & 23 deletions src/pages/inbox/report/ReportActionCompose/ComposerBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
import React from 'react';
import {View} from 'react-native';
import OfflineWithFeedback from '@components/OfflineWithFeedback';
import useOnyx from '@hooks/useOnyx';
import useThemeStyles from '@hooks/useThemeStyles';
import {getReportOfflinePendingActionAndErrors} from '@libs/ReportUtils';
import ONYXKEYS from '@src/ONYXKEYS';
import {useComposerMeta, useComposerSendState, useComposerState} from './ComposerContext';

Expand All @@ -18,31 +16,21 @@ function ComposerBox({reportID, children}: ComposerBoxProps) {
const {exceededMaxLength, isBlockedFromConcierge} = useComposerSendState();
const {containerRef} = useComposerMeta();
const [isComposerFullSize = false] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_IS_COMPOSER_FULL_SIZE}${reportID}`);
const [report] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`);

const {reportPendingAction: pendingAction} = getReportOfflinePendingActionAndErrors(report);
const shouldUseFocusedColor = !isBlockedFromConcierge && isFocused;

return (
<OfflineWithFeedback
shouldDisableOpacity
pendingAction={pendingAction}
style={isComposerFullSize ? styles.chatItemFullComposeRow : {}}
contentContainerStyle={isComposerFullSize ? styles.flex1 : {}}
<View
ref={containerRef}
style={[
shouldUseFocusedColor ? styles.chatItemComposeBoxFocusedColor : styles.chatItemComposeBoxColor,
styles.flexRow,
styles.chatItemComposeBox,
isComposerFullSize && styles.chatItemFullComposeBox,
!!exceededMaxLength && styles.borderColorDanger,
]}
>
<View
ref={containerRef}
style={[
shouldUseFocusedColor ? styles.chatItemComposeBoxFocusedColor : styles.chatItemComposeBoxColor,
styles.flexRow,
styles.chatItemComposeBox,
isComposerFullSize && styles.chatItemFullComposeBox,
!!exceededMaxLength && styles.borderColorDanger,
]}
>
{children}
</View>
</OfflineWithFeedback>
{children}
</View>
);
}

Expand Down
36 changes: 23 additions & 13 deletions src/pages/inbox/report/ReportActionCompose/ReportActionCompose.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import React from 'react';
import {View} from 'react-native';
import OfflineIndicator from '@components/OfflineIndicator';
import OfflineWithFeedback from '@components/OfflineWithFeedback';
import useOnyx from '@hooks/useOnyx';
import useResponsiveLayout from '@hooks/useResponsiveLayout';
import useThemeStyles from '@hooks/useThemeStyles';
import {getReportOfflinePendingActionAndErrors} from '@libs/ReportUtils';
import ONYXKEYS from '@src/ONYXKEYS';
import AgentZeroAwareTypingIndicator from './AgentZeroAwareTypingIndicator';
import ComposerActionMenu from './ComposerActionMenu';
Expand All @@ -29,6 +31,7 @@ function ReportActionComposeInner({reportID}: ReportActionComposeProps) {
const {shouldUseNarrowLayout} = useResponsiveLayout();
const [report] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`);
const [isComposerFullSize = false] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_IS_COMPOSER_FULL_SIZE}${reportID}`);
const {reportPendingAction: pendingAction} = getReportOfflinePendingActionAndErrors(report);

if (!report) {
return null;
Expand All @@ -38,19 +41,26 @@ function ReportActionComposeInner({reportID}: ReportActionComposeProps) {
<View style={[isComposerFullSize && styles.chatItemFullComposeRow]}>
<ComposerLocalTime reportID={reportID} />
<View style={isComposerFullSize ? styles.flex1 : {}}>
<ComposerDropZone reportID={reportID}>
<ComposerBox reportID={reportID}>
<ComposerActionMenu reportID={reportID} />
<ComposerInput reportID={reportID} />
<ComposerEmojiPicker reportID={reportID} />
<ComposerSendButton />
</ComposerBox>
</ComposerDropZone>
<ComposerFooter>
{!shouldUseNarrowLayout && <OfflineIndicator containerStyles={[styles.chatItemComposeSecondaryRow]} />}
<AgentZeroAwareTypingIndicator reportID={reportID} />
<ComposerExceededLength />
</ComposerFooter>
<OfflineWithFeedback
shouldDisableOpacity
pendingAction={pendingAction}
style={isComposerFullSize ? styles.chatItemFullComposeRow : {}}
contentContainerStyle={isComposerFullSize ? styles.flex1 : {}}
>
<ComposerDropZone reportID={reportID}>
<ComposerBox reportID={reportID}>
<ComposerActionMenu reportID={reportID} />
<ComposerInput reportID={reportID} />
<ComposerEmojiPicker reportID={reportID} />
<ComposerSendButton />
</ComposerBox>
</ComposerDropZone>
<ComposerFooter>
{!shouldUseNarrowLayout && <OfflineIndicator containerStyles={[styles.chatItemComposeSecondaryRow]} />}
<AgentZeroAwareTypingIndicator reportID={reportID} />
<ComposerExceededLength />
</ComposerFooter>
</OfflineWithFeedback>
<ComposerImportedState />
</View>
</View>
Expand Down
Loading