POC adding new ul and li renderers by jmusial · Pull Request #89162 · Expensify/App

jmusial · 2026-04-29T09:41:50Z

Explanation of Change

Concierge sends HTML bullet lists using standard <ul> / <li> tags, sometimes with an orphaned   inside the <ul> (e.g. <ul><li>One</li><li>Two</li> </ul>). Two problems resulted:

The orphaned   rendered as an extra empty bullet at the end of the list.
The library's default ul renderer wraps each child in MarkedListItem, which doesn't match how our existing <bullet-list> / <bullet-item> markup is rendered, and the spacing felt off.

This PR fixes both:

Adds custom HTMLElementModels for ul and li in BaseHTMLEngineProvider (mirroring the existing bullet-list / bullet-item models), and applies marginVertical: 12 to <ul> for consistent spacing.
Adds a new ULRenderer that renders <ul> as a plain block container (a <View> wrapping TNodeChildrenRenderer), bypassing the library's default MarkedListItem wrapping. The bullet markers are drawn by the <li> renderer.
Reuses the existing BulletItemRenderer for <li>, so standard <li> and the legacy <bullet-item> render identically.
In RenderHTML, strips orphaned   tags that are direct children of <ul> (both the   immediately before </ul> and any   between </li> and the next <li>) before handing the HTML to react-native-render-html. This prevents the extra empty bullet without touching   usage outside of lists.

Fixed Issues

$ #89039
PROPOSAL:

Tests

Sign in and open the Concierge chat.
Trigger a Concierge response that contains a bulleted list — for example, send "What can you do? Use the list format" or any prompt that returns a list of options.
Verify the rendered bullet list:

Each item is preceded by a single bullet (•).
There is no extra empty bullet at the end of the list.
The list has comfortable vertical spacing above and below it.

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-04-29T09:41:56Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

codecov · 2026-04-29T09:52:02Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...ents/HTMLEngineProvider/BaseHTMLEngineProvider.tsx	`81.42% <100.00%> (+0.26%)`	⬆️
...ngineProvider/HTMLRenderers/BulletItemRenderer.tsx	`100.00% <100.00%> (+100.00%)`	⬆️
...ts/HTMLEngineProvider/HTMLRenderers/ULRenderer.tsx	`100.00% <100.00%> (ø)`
...mponents/HTMLEngineProvider/HTMLRenderers/index.ts	`100.00% <ø> (ø)`
src/components/RenderHTML.tsx	`100.00% <100.00%> (ø)`
... and 25 files with indirect coverage changes

war-in · 2026-05-06T10:26:04Z

@roryabraham PR is ready for review! However, I'm not able to update the description, so I posted a comment. Could you please paste it? 🙏

Also, I can't mark the PR as opened. Could you also do that, please?

melvin-bot · 2026-05-07T00:18:57Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

roryabraham · 2026-05-07T00:19:11Z

done @war-in. Looks like ESLint is failing though

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d46cead464

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-07T00:21:06Z

    a: AnchorRenderer,
    code: CodeRenderer,
    img: ImageRenderer,
+    li: BulletItemRenderer,


Preserve ordered-list numbering

Registering BulletItemRenderer for every standard li means it also runs for ordered lists, because this renderer always emits CONST.DOT_SEPARATOR. In any HTML passed to RenderHTMLSource like <ol><li>First</li><li>Second</li></ol>, the built-in ordered-list marker is bypassed and the items render as bullets instead of 1., 2., which regresses standard HTML list rendering while adding <ul> support.

Useful? React with 👍 / 👎.

It's very useful. I'm fixing this now

github-actions · 2026-05-07T00:21:47Z

+ */
+function ULRenderer({tnode, style}: CustomRendererProps<TBlock>) {
+    return (
+        <View style={[style, {gap: 8}]}>


❌ CONSISTENCY-2 (docs)

The magic number 8 is used for gap styling without a named constant or comment explaining the design intent. This makes it harder to maintain consistent spacing across the codebase.

Extract this value into a named constant or use an existing spacing variable from the theme/variables system:

// e.g., in CONST or variables const BULLET_LIST_ITEM_GAP = 8; // Then in the component: <View style={[style, {gap: BULLET_LIST_ITEM_GAP}]}>

Reviewed at: d46cead | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

github-actions · 2026-05-07T00:21:49Z

+            ul: HTMLElementModel.fromCustomModel({
+                tagName: 'ul',
+                contentModel: HTMLContentModel.block,
+                mixedUAStyles: {marginVertical: 12},


❌ CONSISTENCY-2 (docs)

The magic number 12 is used for marginVertical styling without a named constant or comment explaining the design intent.

Extract this value into a named constant or use an existing spacing variable from the theme/variables system:

// e.g., in CONST or variables const UL_MARGIN_VERTICAL = 12; // Then in the model definition: mixedUAStyles: {marginVertical: UL_MARGIN_VERTICAL},

Reviewed at: d46cead | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

and also fixed

trjExpensify · 2026-05-07T01:40:12Z

PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself.

aimane-chnaif · 2026-05-07T05:41:25Z

Before:

After:

Before:

After:

aimane-chnaif · 2026-05-07T05:42:14Z

Reviewer Checklist

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

#89162 (comment)

Note to myself:

import {useEffect} from 'react';
import Onyx from 'react-native-onyx';

    useEffect(() => {
        setTimeout(() => {
            Onyx.merge('reportActions_7779067723124970', {
                '3834599462744614': {
                    message: [
                        {
                            html: 'You can’t directly “pair” your personal Uber app with your individual Expensify account in a way that I can see or manage from here; automatic imports work in one of two supported ways.<br/><br><br><br/><strong>1. Via your company’s Uber for Business integration (fully automatic)</strong><br><br/>If your company uses <strong>Uber for Business</strong> and your workspace admin has connected it to Expensify:<ul><li>You’ll be invited/linked to your company’s Uber for Business program.</li><li>When you take rides or place Uber Eats orders on that <strong>business profile</strong>, Uber sends the trip data to Expensify.</li><li>Expensify automatically creates expenses with SmartScanned receipts and adds them to your reports according to your workspace rules.</li><br/></ul><br/>The admin-side setup is documented here: <a href="https://help.expensify.com/articles/new-expensify/connections/Uber-for-Business">Uber for Business</a>.<br/><br><br><br/><strong>2. By forwarding Uber receipt emails to Expensify (personal fallback)</strong><br><br/>If your company doesn’t have Uber for Business connected, you can still automate things using email receipts:<ul><li>Make sure your Uber receipts go to an email that’s listed as a <strong>contact method</strong> on your Expensify account.</li><li>Forward those emails (or set an auto‑forward rule) to <a href="mailto:receipts@expensify.com">receipts@expensify.com</a>.</li><li>Each forwarded receipt is SmartScanned into an expense automatically, as described in <a href="https://help.expensify.com/articles/new-expensify/reports-and-expenses/Create-an-Expense">Create an Expense</a>.</li><br/></ul><br/>There isn’t a separate “connect my Expensify account in the Uber app” toggle that I can walk you through step‑by‑step today; it’s either the workspace‑level Uber for Business integration or receipt‑forwarding. If you tell me whether EXFY has Uber for Business turned on for you, I can help you sanity‑check which of these paths should apply in your case.<followup-list><followup><followup-text>Once it’s connected, how do Uber receipts show up in Expensify?</followup-text><followup-response>You don’t need to do anything special in the Uber app itself once your company has connected Uber for Business to Expensify.<br><br>When the integration is enabled on your workspace and you’ve been invited/linked on the Uber side, your eligible Uber Rides and Uber Eats trips will automatically generate expenses in Expensify:<br><ul><li>A SmartScanned receipt image is created for each trip</li><li>An expense is created with the correct merchant, date, and amount</li><li>The expense is added to your next report according to your workspace’s rules</li></ul>You can read more about how the integration works in <a href="https://help.expensify.com/articles/new-expensify/connections/Uber-for-Business">Uber for Business</a>.</followup-response></followup><followup><followup-text>What if my company doesn’t use Uber for Business? Can I still automate Uber receipts?</followup-text><followup-response>If your company doesn’t use Uber for Business, or if the integration isn’t enabled on your workspace, you can still get Uber rides into Expensify automatically by using SmartScan:<br><br><ul><li>Make sure your Uber receipts go to an email address that’s added as a contact method on your Expensify account</li><li>Forward your Uber receipt emails to <a href="mailto:receipts@expensify.com">receipts@expensify.com</a>, or set up an auto‑forward rule in your email client</li><li>Each forwarded email will create a SmartScanned expense in Expensify</li></ul>The general receipt‑to‑expense flow is outlined in <a href="https://help.expensify.com/articles/new-expensify/reports-and-expenses/Create-an-Expense">Create an Expense</a>.</followup-response></followup><followup><followup-text>Why aren’t my Uber rides showing up in Expensify?</followup-text><followup-response>If an Uber ride or meal isn’t appearing in Expensify as expected, try the following:<br><ul><li>Confirm whether your company actually has the Uber for Business integration enabled and that you’ve been invited/linked in that program</li><li>Check that the Uber trip used the email address your company expects (for U4B) or an email that’s on your Expensify account if you’re forwarding receipts</li><li>Look on your Expenses/Spend page for Unreported expenses that may not have hit a report yet</li></ul>If the integration is definitely enabled and you’re linked but trips are still missing, your workspace admin can review the connection and invites as described in <a href="https://help.expensify.com/articles/new-expensify/connections/Uber-for-Business">Uber for Business</a>.</followup-response></followup></followup-list>',
                            text: 'You can’t directly “pair” your personal Uber app with your individual Expensify account in a way that I can see or manage from here; automatic imports work in one of two supported ways.\n\n\n\n1. Via your company’s Uber for Business integration (fully automatic)\n\nIf your company uses Uber for Business and your workspace admin has connected it to Expensify:You’ll be invited/linked to your company’s Uber for Business program.When you take rides or place Uber Eats orders on that business profile, Uber sends the trip data to Expensify.Expensify automatically creates expenses with SmartScanned receipts and adds them to your reports according to your workspace rules.\n\nThe admin-side setup is documented here: Uber for Business.\n\n\n\n2. By forwarding Uber receipt emails to Expensify (personal fallback)\n\nIf your company doesn’t have Uber for Business connected, you can still automate things using email receipts:Make sure your Uber receipts go to an email that’s listed as a contact method on your Expensify account.Forward those emails (or set an auto‑forward rule) to receipts@expensify.com.Each forwarded receipt is SmartScanned into an expense automatically, as described in Create an Expense.\n\nThere isn’t a separate “connect my Expensify account in the Uber app” toggle that I can walk you through step‑by‑step today; it’s either the workspace‑level Uber for Business integration or receipt‑forwarding. If you tell me whether EXFY has Uber for Business turned on for you, I can help you sanity‑check which of these paths should apply in your case.',
                            type: 'COMMENT',
                            whisperedTo: [],
                        },
                    ],
                    originalMessage: {
                        html: 'You can’t directly “pair” your personal Uber app with your individual Expensify account in a way that I can see or manage from here; automatic imports work in one of two supported ways.<br/><br><br><br/><strong>1. Via your company’s Uber for Business integration (fully automatic)</strong><br><br/>If your company uses <strong>Uber for Business</strong> and your workspace admin has connected it to Expensify:<ul><li>You’ll be invited/linked to your company’s Uber for Business program.</li><li>When you take rides or place Uber Eats orders on that <strong>business profile</strong>, Uber sends the trip data to Expensify.</li><li>Expensify automatically creates expenses with SmartScanned receipts and adds them to your reports according to your workspace rules.</li><br/></ul><br/>The admin-side setup is documented here: <a href="https://help.expensify.com/articles/new-expensify/connections/Uber-for-Business">Uber for Business</a>.<br/><br><br><br/><strong>2. By forwarding Uber receipt emails to Expensify (personal fallback)</strong><br><br/>If your company doesn’t have Uber for Business connected, you can still automate things using email receipts:<ul><li>Make sure your Uber receipts go to an email that’s listed as a <strong>contact method</strong> on your Expensify account.</li><li>Forward those emails (or set an auto‑forward rule) to <a href="mailto:receipts@expensify.com">receipts@expensify.com</a>.</li><li>Each forwarded receipt is SmartScanned into an expense automatically, as described in <a href="https://help.expensify.com/articles/new-expensify/reports-and-expenses/Create-an-Expense">Create an Expense</a>.</li><br/></ul><br/>There isn’t a separate “connect my Expensify account in the Uber app” toggle that I can walk you through step‑by‑step today; it’s either the workspace‑level Uber for Business integration or receipt‑forwarding. If you tell me whether EXFY has Uber for Business turned on for you, I can help you sanity‑check which of these paths should apply in your case.<followup-list><followup><followup-text>Once it’s connected, how do Uber receipts show up in Expensify?</followup-text><followup-response>You don’t need to do anything special in the Uber app itself once your company has connected Uber for Business to Expensify.<br><br>When the integration is enabled on your workspace and you’ve been invited/linked on the Uber side, your eligible Uber Rides and Uber Eats trips will automatically generate expenses in Expensify:<br><ul><li>A SmartScanned receipt image is created for each trip</li><li>An expense is created with the correct merchant, date, and amount</li><li>The expense is added to your next report according to your workspace’s rules</li></ul>You can read more about how the integration works in <a href="https://help.expensify.com/articles/new-expensify/connections/Uber-for-Business">Uber for Business</a>.</followup-response></followup><followup><followup-text>What if my company doesn’t use Uber for Business? Can I still automate Uber receipts?</followup-text><followup-response>If your company doesn’t use Uber for Business, or if the integration isn’t enabled on your workspace, you can still get Uber rides into Expensify automatically by using SmartScan:<br><br><ul><li>Make sure your Uber receipts go to an email address that’s added as a contact method on your Expensify account</li><li>Forward your Uber receipt emails to <a href="mailto:receipts@expensify.com">receipts@expensify.com</a>, or set up an auto‑forward rule in your email client</li><li>Each forwarded email will create a SmartScanned expense in Expensify</li></ul>The general receipt‑to‑expense flow is outlined in <a href="https://help.expensify.com/articles/new-expensify/reports-and-expenses/Create-an-Expense">Create an Expense</a>.</followup-response></followup><followup><followup-text>Why aren’t my Uber rides showing up in Expensify?</followup-text><followup-response>If an Uber ride or meal isn’t appearing in Expensify as expected, try the following:<br><ul><li>Confirm whether your company actually has the Uber for Business integration enabled and that you’ve been invited/linked in that program</li><li>Check that the Uber trip used the email address your company expects (for U4B) or an email that’s on your Expensify account if you’re forwarding receipts</li><li>Look on your Expenses/Spend page for Unreported expenses that may not have hit a report yet</li></ul>If the integration is definitely enabled and you’re linked but trips are still missing, your workspace admin can review the connection and invites as described in <a href="https://help.expensify.com/articles/new-expensify/connections/Uber-for-Business">Uber for Business</a>.</followup-response></followup></followup-list>',
                    },
                },
            });
        }, 3000);
    });

aimane-chnaif · 2026-05-07T05:48:11Z

Not working on native

MelvinBot · 2026-05-07T06:55:06Z

The bullet-list tag has no built-in behavior in react-native-render-html — it's a custom element Expensify invented, so the library just renders whatever we tell it to.

<ul>, on the other hand, is a standard HTML tag that the library already handles internally by wrapping children in MarkedListItem. That default wrapping produces incorrect spacing and double-bullet rendering. The ULRenderer exists specifically to override that built-in library behavior and render <ul> as a plain block container instead.

In short: bullet-list doesn't need an override because the library has no opinion about it. <ul> does need one because the library's default ul handling conflicts with how Expensify renders bullet lists. The items themselves already share the same renderer (BulletItemRenderer is reused for both <bullet-item> and <li>).

war-in · 2026-05-07T07:40:09Z

Not working on native

On it, I'll try to investigate the issue 🫡

war-in · 2026-05-07T09:42:39Z

@aimane-chnaif mobile platforms should be working now, sorry for the oversight
I also fixed the ordered list because previously every numbered item contained an additional dot

joekaufmanexpensify

Good for product

MelvinBot · 2026-05-07T17:05:47Z

Code Review

Overall this is a well-structured fix. The approach of overriding the library's default <ul> renderer to match existing <bullet-list>/<bullet-item> behavior is sound, the   stripping regex is correctly scoped, and the test coverage is good. CI is green (only failing check is checklist which is expected).

A few observations:

1. Magic number in BulletItemRenderer (pre-existing, minor)

paddingHorizontal: 8 on line 17 of BulletItemRenderer.tsx is a magic number. Since this file was touched by the PR (type signature change + w100 addition), it would be a good opportunity to replace it with a style constant — but not blocking.

2. renderers object in RenderHTML.tsx is not memoized (pre-existing)

The renderers object (lines 58–63) is recreated on every render. This was true before this PR (for bullet-item and sparkles-icon), but worth noting since adding ul extends the pattern. A useMemo wrapper would prevent unnecessary re-renders of the HTML tree. Not blocking since it's a pre-existing pattern.

3. Consistency note: bullet-list vs ul element models

bullet-list uses a hardcoded {marginVertical: 12} while ul correctly uses styles.mv3. These resolve to the same value, but it would be slightly cleaner if bullet-list also used styles.mv3 for consistency. Again, pre-existing — not blocking.

Looks good overall — the regex stripping correctly targets only orphaned   between </li> boundaries, <li> is intentionally left unregistered globally to preserve <ol> numbering, and the tests cover the key edge cases (nested   inside <li>,   outside lists).

MelvinBot · 2026-05-07T17:13:25Z

Regression Analysis

No high-risk regressions found. One minor edge case worth noting.

Areas investigated

Area	Risk	Verdict
`<ol>` (ordered list) rendering	None	Library resolves renderers per-tag independently (`Custom \|\| Default`). Since only `ul` has a custom renderer, `<ol>` continues using the library's built-in `OLRenderer` with numbered markers. Confirmed `<ol>` is used in production content.
`BulletItemRenderer` type change	None	All 3 callers (`index.ts:41`, `RenderHTML.tsx:60`, `ULRenderer.tsx:22`) only pass `tnode`. Widening from `TBlock` → `TNode` improves type correctness for `ULRenderer`'s usage. `w100` is correct — parent is already block-level.
`<br/>` stripping regex	Low	See edge case below
Dual `ULRenderer` registration	None	Two independent rendering paths (`BaseHTMLEngineProvider` vs `RenderHTML.tsx`'s own `RenderHTMLConfigProvider`). Inner provider overrides outer via React context — no merging, no duplication. Dual registration is necessary because `RenderHTML.tsx`'s provider replaces (not merges) the parent's renderers.

Edge case: consecutive ` ` tags

The second regex strips one   between </li> and <li>, but replaceAll scans left-to-right without re-examining consumed text. For </li> <li>:

First match consumes </li> , replaces with </li>, scanner advances past it
Remaining  <li> lacks the </li> anchor — no match, one orphan   survives

Result: </li> <li> — which would still render an empty item between bullets.

This is unlikely in practice (Concierge responses typically have a single  ), but a test case for </li> <li> would confirm the expected behavior.

Missing test coverage (non-blocking)

Nested lists: <ul><li><ul><li>inner</li></ul></li></ul>
Multiple consecutive  : </li> <li>

aimane-chnaif · 2026-05-07T17:36:17Z

@war-in can we apply same fix to ordered list?

Use this for example data:

            Onyx.merge('reportActions_xxx', {
                'zzz': {
                    message: [
                        {
                            html: 'You can’t directly “pair” your personal Uber app with your individual Expensify account in a way that I can see or manage from here; automatic imports work in one of two supported ways.<br/><br><br><br/><strong>1. Via your company’s Uber for Business integration (fully automatic)</strong><br><br/>If your company uses <strong>Uber for Business</strong> and your workspace admin has connected it to Expensify:<ol><li>You’ll be invited/linked to your company’s Uber for Business program.</li><li>When you take rides or place Uber Eats orders on that <strong>business profile</strong>, Uber sends the trip data to Expensify.</li><li>Expensify automatically creates expenses with SmartScanned receipts and adds them to your reports according to your workspace rules.</li><br/></ol><br/>The admin-side setup is documented here: <a href="https://help.expensify.com/articles/new-expensify/connections/Uber-for-Business">Uber for Business</a>.<br/><br><br><br/><strong>2. By forwarding Uber receipt emails to Expensify (personal fallback)</strong><br><br/>If your company doesn’t have Uber for Business connected, you can still automate things using email receipts:<ol><li>Make sure your Uber receipts go to an email that’s listed as a <strong>contact method</strong> on your Expensify account.</li><li>Forward those emails (or set an auto‑forward rule) to <a href="mailto:receipts@expensify.com">receipts@expensify.com</a>.</li><li>Each forwarded receipt is SmartScanned into an expense automatically, as described in <a href="https://help.expensify.com/articles/new-expensify/reports-and-expenses/Create-an-Expense">Create an Expense</a>.</li><br/></ol><br/>There isn’t a separate “connect my Expensify account in the Uber app” toggle that I can walk you through step‑by‑step today; it’s either the workspace‑level Uber for Business integration or receipt‑forwarding. If you tell me whether EXFY has Uber for Business turned on for you, I can help you sanity‑check which of these paths should apply in your case.<followup-list><followup><followup-text>Once it’s connected, how do Uber receipts show up in Expensify?</followup-text><followup-response>You don’t need to do anything special in the Uber app itself once your company has connected Uber for Business to Expensify.<br><br>When the integration is enabled on your workspace and you’ve been invited/linked on the Uber side, your eligible Uber Rides and Uber Eats trips will automatically generate expenses in Expensify:<br><ol><li>A SmartScanned receipt image is created for each trip</li><li>An expense is created with the correct merchant, date, and amount</li><li>The expense is added to your next report according to your workspace’s rules</li></ol>You can read more about how the integration works in <a href="https://help.expensify.com/articles/new-expensify/connections/Uber-for-Business">Uber for Business</a>.</followup-response></followup><followup><followup-text>What if my company doesn’t use Uber for Business? Can I still automate Uber receipts?</followup-text><followup-response>If your company doesn’t use Uber for Business, or if the integration isn’t enabled on your workspace, you can still get Uber rides into Expensify automatically by using SmartScan:<br><br><ol><li>Make sure your Uber receipts go to an email address that’s added as a contact method on your Expensify account</li><li>Forward your Uber receipt emails to <a href="mailto:receipts@expensify.com">receipts@expensify.com</a>, or set up an auto‑forward rule in your email client</li><li>Each forwarded email will create a SmartScanned expense in Expensify</li></ol>The general receipt‑to‑expense flow is outlined in <a href="https://help.expensify.com/articles/new-expensify/reports-and-expenses/Create-an-Expense">Create an Expense</a>.</followup-response></followup><followup><followup-text>Why aren’t my Uber rides showing up in Expensify?</followup-text><followup-response>If an Uber ride or meal isn’t appearing in Expensify as expected, try the following:<br><ol><li>Confirm whether your company actually has the Uber for Business integration enabled and that you’ve been invited/linked in that program</li><li>Check that the Uber trip used the email address your company expects (for U4B) or an email that’s on your Expensify account if you’re forwarding receipts</li><li>Look on your Expenses/Spend page for Unreported expenses that may not have hit a report yet</li></ol>If the integration is definitely enabled and you’re linked but trips are still missing, your workspace admin can review the connection and invites as described in <a href="https://help.expensify.com/articles/new-expensify/connections/Uber-for-Business">Uber for Business</a>.</followup-response></followup></followup-list>',
                            text: 'You can’t directly “pair” your personal Uber app with your individual Expensify account in a way that I can see or manage from here; automatic imports work in one of two supported ways.\n\n\n\n1. Via your company’s Uber for Business integration (fully automatic)\n\nIf your company uses Uber for Business and your workspace admin has connected it to Expensify:You’ll be invited/linked to your company’s Uber for Business program.When you take rides or place Uber Eats orders on that business profile, Uber sends the trip data to Expensify.Expensify automatically creates expenses with SmartScanned receipts and adds them to your reports according to your workspace rules.\n\nThe admin-side setup is documented here: Uber for Business.\n\n\n\n2. By forwarding Uber receipt emails to Expensify (personal fallback)\n\nIf your company doesn’t have Uber for Business connected, you can still automate things using email receipts:Make sure your Uber receipts go to an email that’s listed as a contact method on your Expensify account.Forward those emails (or set an auto‑forward rule) to receipts@expensify.com.Each forwarded receipt is SmartScanned into an expense automatically, as described in Create an Expense.\n\nThere isn’t a separate “connect my Expensify account in the Uber app” toggle that I can walk you through step‑by‑step today; it’s either the workspace‑level Uber for Business integration or receipt‑forwarding. If you tell me whether EXFY has Uber for Business turned on for you, I can help you sanity‑check which of these paths should apply in your case.',
                            type: 'COMMENT',
                            whisperedTo: [],
                        },
                    ],
                    originalMessage: {
                        html: 'You can’t directly “pair” your personal Uber app with your individual Expensify account in a way that I can see or manage from here; automatic imports work in one of two supported ways.<br/><br><br><br/><strong>1. Via your company’s Uber for Business integration (fully automatic)</strong><br><br/>If your company uses <strong>Uber for Business</strong> and your workspace admin has connected it to Expensify:<ol><li>You’ll be invited/linked to your company’s Uber for Business program.</li><li>When you take rides or place Uber Eats orders on that <strong>business profile</strong>, Uber sends the trip data to Expensify.</li><li>Expensify automatically creates expenses with SmartScanned receipts and adds them to your reports according to your workspace rules.</li><br/></ol><br/>The admin-side setup is documented here: <a href="https://help.expensify.com/articles/new-expensify/connections/Uber-for-Business">Uber for Business</a>.<br/><br><br><br/><strong>2. By forwarding Uber receipt emails to Expensify (personal fallback)</strong><br><br/>If your company doesn’t have Uber for Business connected, you can still automate things using email receipts:<ol><li>Make sure your Uber receipts go to an email that’s listed as a <strong>contact method</strong> on your Expensify account.</li><li>Forward those emails (or set an auto‑forward rule) to <a href="mailto:receipts@expensify.com">receipts@expensify.com</a>.</li><li>Each forwarded receipt is SmartScanned into an expense automatically, as described in <a href="https://help.expensify.com/articles/new-expensify/reports-and-expenses/Create-an-Expense">Create an Expense</a>.</li><br/></ol><br/>There isn’t a separate “connect my Expensify account in the Uber app” toggle that I can walk you through step‑by‑step today; it’s either the workspace‑level Uber for Business integration or receipt‑forwarding. If you tell me whether EXFY has Uber for Business turned on for you, I can help you sanity‑check which of these paths should apply in your case.<followup-list><followup><followup-text>Once it’s connected, how do Uber receipts show up in Expensify?</followup-text><followup-response>You don’t need to do anything special in the Uber app itself once your company has connected Uber for Business to Expensify.<br><br>When the integration is enabled on your workspace and you’ve been invited/linked on the Uber side, your eligible Uber Rides and Uber Eats trips will automatically generate expenses in Expensify:<br><ol><li>A SmartScanned receipt image is created for each trip</li><li>An expense is created with the correct merchant, date, and amount</li><li>The expense is added to your next report according to your workspace’s rules</li></ol>You can read more about how the integration works in <a href="https://help.expensify.com/articles/new-expensify/connections/Uber-for-Business">Uber for Business</a>.</followup-response></followup><followup><followup-text>What if my company doesn’t use Uber for Business? Can I still automate Uber receipts?</followup-text><followup-response>If your company doesn’t use Uber for Business, or if the integration isn’t enabled on your workspace, you can still get Uber rides into Expensify automatically by using SmartScan:<br><br><ol><li>Make sure your Uber receipts go to an email address that’s added as a contact method on your Expensify account</li><li>Forward your Uber receipt emails to <a href="mailto:receipts@expensify.com">receipts@expensify.com</a>, or set up an auto‑forward rule in your email client</li><li>Each forwarded email will create a SmartScanned expense in Expensify</li></ol>The general receipt‑to‑expense flow is outlined in <a href="https://help.expensify.com/articles/new-expensify/reports-and-expenses/Create-an-Expense">Create an Expense</a>.</followup-response></followup><followup><followup-text>Why aren’t my Uber rides showing up in Expensify?</followup-text><followup-response>If an Uber ride or meal isn’t appearing in Expensify as expected, try the following:<br><ol><li>Confirm whether your company actually has the Uber for Business integration enabled and that you’ve been invited/linked in that program</li><li>Check that the Uber trip used the email address your company expects (for U4B) or an email that’s on your Expensify account if you’re forwarding receipts</li><li>Look on your Expenses/Spend page for Unreported expenses that may not have hit a report yet</li></ol>If the integration is definitely enabled and you’re linked but trips are still missing, your workspace admin can review the connection and invites as described in <a href="https://help.expensify.com/articles/new-expensify/connections/Uber-for-Business">Uber for Business</a>.</followup-response></followup></followup-list>',
                    },
                },
            });

Btw not blocker sine this is happening on production. I am fine to fix as follow-up, limiting the scope of PR to <ul> only.

melvin-bot · 2026-05-07T18:23:24Z

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

roryabraham · 2026-05-07T18:31:31Z

tests were passing?

OSBotify · 2026-05-07T18:31:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-05-07T19:05:01Z

🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-07T19:09:29Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #89162.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-7670402-593d847-ead5184f17c4b58a2f003bfd1a5c132eab9afa07/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-7670402-593d847-1b621ff798f2cf2fed1929c48aa96803235e50f5/index.html

Web 🕸️
https://89162.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-08T15:41:46Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.3.69-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-08T15:43:13Z

No help site changes are required for this PR.

This is a technical rendering fix for how <ul>/<li> HTML tags display in Concierge chat messages (removing an extra empty bullet and fixing spacing). It doesn't change any user-facing features, workflows, settings, or terminology documented on the help site.

OSBotify · 2026-05-11T23:42:15Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.69-18 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

POC adding new ul and li renderers

b8cc418

melvin-bot Bot assigned jmusial Apr 29, 2026

strip extra brs, revert translation

90452d0

jmusial mentioned this pull request Apr 29, 2026

[Due for payment 2026-05-28] [$250] Bullet lists render extra bullet from orphaned and have suboptimal spacing #89039

Closed

jmusial and others added 5 commits April 29, 2026 12:11

fix lint

d6ec5b1

Merge branch 'main' into fix/add-ul-li-renderer-poc

a34e7f9

test: add BulletListRendererTest

820e699

test: add case with inside <li>

bb1e818

feat: add gap between list items in ULRenderer

d46cead

This comment was marked as duplicate.

Sign in to view

roryabraham marked this pull request as ready for review May 7, 2026 00:18

roryabraham requested review from a team as code owners May 7, 2026 00:18

melvin-bot Bot requested review from aimane-chnaif and joekaufmanexpensify and removed request for a team May 7, 2026 00:18

melvin-bot Bot requested review from a team and trjExpensify and removed request for a team May 7, 2026 00:18

chatgpt-codex-connector Bot reviewed May 7, 2026

View reviewed changes

github-actions Bot reviewed May 7, 2026

View reviewed changes

trjExpensify removed their request for review May 7, 2026 01:40

war-in added 4 commits May 7, 2026 09:43

Merge branch 'main' into fix/add-ul-li-renderer-poc

4e1f72b

fix: don't render bullets in ordered list

ab7b6cd

fix: list content not visible on mobile

dcc81fd

fix: address codex review

adf4a33

joekaufmanexpensify approved these changes May 7, 2026

View reviewed changes

aimane-chnaif approved these changes May 7, 2026

View reviewed changes

melvin-bot Bot requested a review from roryabraham May 7, 2026 17:41

roryabraham approved these changes May 7, 2026

View reviewed changes

roryabraham merged commit 7670402 into Expensify:main May 7, 2026
44 of 47 checks passed

melvin-bot Bot added the Emergency label May 7, 2026

roryabraham removed the Emergency label May 7, 2026

OSBotify mentioned this pull request May 8, 2026

Deploy Checklist: New Expensify 2026-05-08 #90006

Closed

jmusial mentioned this pull request May 13, 2026

Add OL renderer #90482

Merged

50 tasks

Conversation

jmusial commented Apr 29, 2026 • edited by roryabraham Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 29, 2026

Uh oh!

codecov Bot commented Apr 29, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment was marked as duplicate.

war-in commented May 6, 2026

Uh oh!

melvin-bot Bot commented May 7, 2026

Uh oh!

roryabraham commented May 7, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 7, 2026

Choose a reason for hiding this comment

Uh oh!

war-in May 7, 2026

Choose a reason for hiding this comment

Uh oh!

war-in May 7, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 7, 2026

Choose a reason for hiding this comment

❌ CONSISTENCY-2 (docs)

Uh oh!

war-in May 7, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot May 7, 2026

Choose a reason for hiding this comment

❌ CONSISTENCY-2 (docs)

Uh oh!

war-in May 7, 2026

Choose a reason for hiding this comment

Uh oh!

trjExpensify commented May 7, 2026

Uh oh!

aimane-chnaif commented May 7, 2026

Uh oh!

aimane-chnaif commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

aimane-chnaif commented May 7, 2026

Uh oh!

MelvinBot commented May 7, 2026

Uh oh!

war-in commented May 7, 2026

Uh oh!

war-in commented May 7, 2026

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

MelvinBot commented May 7, 2026

Code Review

Uh oh!

MelvinBot commented May 7, 2026

Regression Analysis

Areas investigated

Edge case: consecutive <br/> tags

Missing test coverage (non-blocking)

Uh oh!

jmusial commented Apr 29, 2026 •

edited by roryabraham

Loading

codecov Bot commented Apr 29, 2026 •

edited by github-actions Bot

Loading

aimane-chnaif commented May 7, 2026 •

edited

Loading

Edge case: consecutive `<br/>` tags

aimane-chnaif commented May 7, 2026 •

edited

Loading