Skip to content

Offline/Online toggle data fetch for workspace settings page #8921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndrewGable merged 2 commits into from
May 12, 2022
Merged

Offline/Online toggle data fetch for workspace settings page #8921

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1542bb
Reload WorkspaceSettings data when toggling online
May 10, 2022
4f57b9f
Lint WorkspaceSettingsPage.js methods order
May 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion src/pages/workspace/WorkspaceSettingsPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,21 @@ import FixedFooter from '../../components/FixedFooter';
import WorkspacePageWithSections from './WorkspacePageWithSections';
import FullScreenLoadingIndicator from '../../components/FullscreenLoadingIndicator';
import withFullPolicy, {fullPolicyPropTypes, fullPolicyDefaultProps} from './withFullPolicy';
import {withNetwork} from '../../components/OnyxProvider';
import networkPropTypes from '../../components/networkPropTypes';

const propTypes = {
/** Information about the network from Onyx */
network: networkPropTypes.isRequired,

/** List of betas */
betas: PropTypes.arrayOf(PropTypes.string),

...fullPolicyPropTypes,

...withLocalizePropTypes,
};

const defaultProps = {
betas: [],

Expand All @@ -58,7 +64,15 @@ class WorkspaceSettingsPage extends React.Component {
}

componentDidMount() {
PersonalDetails.getCurrencyList();
this.fetchData();
}

componentDidUpdate(prevProps) {
if (!prevProps.network.isOffline || this.props.network.isOffline) {
return;
}

this.fetchData();
}

/**
Expand All @@ -72,6 +86,10 @@ class WorkspaceSettingsPage extends React.Component {
}));
}

fetchData() {
PersonalDetails.getCurrencyList();
}

removeAvatar() {
this.setState({previewAvatarURL: ''});
Policy.update(this.props.policy.id, {avatarURL: ''}, true);
Expand Down Expand Up @@ -196,4 +214,5 @@ export default compose(
currencyList: {key: ONYXKEYS.CURRENCY_LIST},
}),
withLocalize,
withNetwork(),
)(WorkspaceSettingsPage);