[Odometer] Show discard changes modal when switching tabs by jakubkalinski0 · Pull Request #89612 · Expensify/App

jakubkalinski0 · 2026-05-05T15:27:01Z

Explanation of Change

This PR adds a feature we agreed on in this discussion to show a Discard Changes confirmation modal when the user tries to switch away from the Odometer tab to another tab with unsaved changes.

The tab-switch guard is generic, not odometer-specific. A new TabSwitchGuardContext lets any tab screen register getHasUnsavedChanges / onDiscard / onCancel callbacks keyed by tab name, and OnyxTabNavigator intercepts tabPress to show the shared "Discard changes?" modal - on confirm it runs onDiscard and then jumps to the target tab (it always jumps, even if onDiscard fails, surfacing a Growl error rather than stranding the user). It's wired through the existing useDiscardChangesConfirmation hook via a new onTabSwitchDiscard option that self-disables outside a tab navigator, and both the nav-away and tab-switch paths render an identical modal from getDiscardChangesModalConfig. On the Odometer tab, confirming clears the readings/images (or restores the confirmation-edit backup when editing) before the tab switch.

The discard diff is hardened against false positives: image changes use a re-mint-invariant identity (getOdometerImageIdentity, name|size|lastModified) that survives the draft round-trip but still detects a real swap, and the resync / unsaved-changes branching is extracted into unit-tested pure predicates (odometerResync.ts, getOdometerHasUnsavedChanges) that won't re-hydrate readings the user intentionally cleared.

Diff overview

24 files changed · +2097 / −197 - breakdown of main...HEAD at 290f76a

Tests vs. non-test source

Category	Insertions	%
Test files (8 files, 5 new)	1578	75%
Non-test source (14 files, 3 new)	516	25%
Config / wordlist data (2 files)	3	<1%
Total insertions	2097	100%

So roughly three quarters of the diff is tests - new unit + UI tests covering the generic tab-switch guard, the resync predicates, the odometer draft round-trip, and the edit-from-confirmation backup/restore path.

Inside the 519 non-test insertions

File	Insertions	Comment-only lines	Actual code
`OnyxTabNavigator.tsx` (modified)	123	4	116 (+3 blank)
`IOURequestStepDistanceOdometer.tsx` (modified)	115	8	98 (+9 blank)
`odometerResync.ts` (NEW)	78	31	36 (+11 blank)
`OdometerTransactionUtils.ts` (modified)	67	16	42 (+9 blank)
`TabSwitchGuardContext.tsx` (NEW)	45	7	31 (+7 blank)
`getDiscardChangesModalConfig.ts` (NEW)	18	5	11 (+2 blank)
`OdometerImageUtils.ts` (modified)	18	7	10 (+1 blank)
`useOdometerReadingsState.ts` (modified)	14	13	1 (comment touch-up)
`useDiscardChangesConfirmation/index.native.ts` (modified)	10	2	7 (+1 blank)
`useDiscardChangesConfirmation/index.ts` (modified)	10	2	7 (+1 blank)
`useDiscardChangesConfirmation/types.ts` (modified)	6	4	1 (+1 blank)
`OdometerDraft.ts` (modified)	6	2	2 (+2 blank)
`DistanceRequestStartPage.tsx` (modified)	5	0	4 (+1 blank)
`Attachment.ts` (modified)	1	0	1
`cspell.json` + `eslint.seatbelt.tsv` (data)	3	0	3 (config)
Subtotals	519	101	367 (+48 blank, +3 config)

The tab-switch registration was added to both the web (index.ts) and native (index.native.ts) variants of useDiscardChangesConfirmation - they already had a platform split (usePreventRemove on native vs useBeforeRemove on web), and the new guard hooks into each identically. The new TabSwitchGuardContext and the OnyxTabNavigator integration are single cross-platform files: the guard lives at the navigator level, so there is no platform-specific behavior to split out.

Summary

Category	Lines	% of insertions
Tests	1578	75%
Comments / JSDoc in source	101	5%
Blank lines in source	48	2%
Config / wordlist data	3	<1%
Actual non-comment, non-blank source code	367	17.5%
Total insertions	2097	100%

Deletions (197 lines)

File(s)	Deletions	Nature
`OnyxTabNavigator.tsx`	42	return block restructured to add the provider + `tabPress` listener (rewrite, not removal)
`IOURequestStepDistanceOdometer.tsx`	41	old inline discard hook moved up and replaced by `getOdometerHasUnsavedChanges`
Tests (3 modified files)	52	updated assertions / helpers
`useOdometerReadingsState.ts`	20	resync effect relocated to the step + comment trims
`OdometerTransactionUtils.ts`	15	`isOdometerDraftPendingHydration` rewrite + comment removal
`index.native.ts` / `index.ts`	9 / 7	inline modal config replaced by shared `getDiscardChangesModalConfig`
`OdometerImageUtils.ts`	7	comment trim
`DistanceRequestStartPage.tsx` / `Attachment.ts` / `eslint.seatbelt.tsv`	2 / 1 / 1	misc

Bottom line: the PR is overwhelmingly additive. Of the 197 deletions, ~104 are source code and the rest are comments (39), tests (52), one blank line, and config. Crucially, almost none of those 104 lines are dead-code removal - they are rewrites/relocations: the OnyxTabNavigator return block was restructured to add the guard, and the odometer discard logic was moved out and re-expressed as pure predicates. Net new "real" source logic is roughly +263 lines (367 added − 104 removed), concentrated in the generic tab-guard wiring (OnyxTabNavigator + TabSwitchGuardContext), the odometerResync / getOdometerHasUnsavedChanges predicates, and the lastModified image-identity plumbing. Tests (1578 insertions / 52 deletions) are ~75% of the diff.

Fixed Issues

$ #89940
PROPOSAL: N/A

Tests

Start a new expense and open the Distance request flow, then switch to the Odometer tab.
Enter a start reading and/or end reading, and/or attach a start/end odometer image. Do not save.
Tap a different tab (Map, Manual, or GPS) and verify that a "Discard changes?" confirmation modal appears.
Tap Cancel and verify that you stay on the Odometer tab with your unsaved readings/images intact.
Tap a different tab again, then tap the danger/confirm button in the modal.
Verify that the modal closes, the Odometer tab is reset (readings cleared, images removed), and the app navigates to the tab you originally tapped.
Back on the Odometer tab with empty readings/images, switch tabs and verify that no modal is shown and the tab switch happens immediately.
Type a reading, then delete it so the field is empty. Verify the field stays empty (it does not snap back to the value you just cleared) and that switching tabs now shows no modal.
Regression check the shared navigator: open another OnyxTabNavigator-based flow that does not register a guard (e.g. the Map/Manual distance tabs with no unsaved odometer changes) and verify tab switches happen immediately with no modal.

Odometer regression tests (optional)

Nav-away discard still works

With unsaved odometer changes, use the in-app back button or press outside the RHP to leave the flow.
Verify the existing "Discard changes?" modal still appears (this PR does not change nav-away behavior).

Save-for-later draft

With odometer readings/images entered, tap Save for later, then reopen the flow.
Switch tabs without making further edits and verify that NO modal appears (the hydrated draft equals the transaction, so it is not treated as an unsaved change).

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

untitled.webm

Android: mWeb Chrome

untitled2.webm

iOS: Native

Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2026-06-16.at.23.05.25.mov

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2026-06-16.at.23.22.23.mov

MacOS: Chrome / Safari

Screen.Recording.2026-06-16.at.20.56.57.mov

codecov · 2026-05-05T15:37:00Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...ooks/useDiscardChangesConfirmation/index.native.ts	`53.33% <100.00%> (+53.33%)`	⬆️
src/libs/OdometerImageUtils.ts	`77.27% <100.00%> (+39.77%)`	⬆️
...uestStepDistance/hooks/useOdometerReadingsState.ts	`100.00% <100.00%> (+1.81%)`	⬆️
...uest/step/IOURequestStepDistance/odometerResync.ts	`100.00% <100.00%> (ø)`
src/pages/iou/request/DistanceRequestStartPage.tsx	`0.00% <0.00%> (ø)`
...ou/request/step/IOURequestStepDistanceOdometer.tsx	`85.29% <96.00%> (+85.29%)`	⬆️
...hangesConfirmation/getDiscardChangesModalConfig.ts	`0.00% <0.00%> (ø)`
src/hooks/useDiscardChangesConfirmation/index.ts	`0.00% <0.00%> (ø)`
src/libs/Navigation/TabSwitchGuardContext.tsx	`84.61% <84.61%> (ø)`
src/libs/actions/OdometerTransactionUtils.ts	`54.80% <83.33%> (+37.76%)`	⬆️
... and 1 more
... and 20 files with indirect coverage changes

jakubkalinski0 · 2026-05-11T15:23:34Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4a624d5330

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

jakubkalinski0 · 2026-05-11T15:50:57Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 31b9b37c2f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

jakubkalinski0 · 2026-05-11T16:20:48Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b2690b40a8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

jakubkalinski0 · 2026-05-11T16:40:02Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b2690b40a8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

jakubkalinski0 · 2026-05-11T16:57:27Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bd1d392ced

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

jakubkalinski0 · 2026-05-11T17:15:55Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f9086f72ef

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

jakubkalinski0 · 2026-05-11T17:49:58Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4f59a798f4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

jakubkalinski0 · 2026-05-11T18:14:43Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 62149d8334

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

jakubkalinski0 · 2026-05-11T18:43:06Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 62149d8334

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

jakubkalinski0 · 2026-05-11T18:52:57Z

@codex review

chatgpt-codex-connector · 2026-05-11T19:02:23Z

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…causing double-restore

…identity

…n tab/back

…_modal_when_switching_tabs

…itch Removes the browser-Back-button discard mechanism introduced in 4ab9a73: the tab-history replacement router, goForwardInBrowserHistory helper, and the page-level useActiveTabGuardDiscardConfirmation hook. Restores the per-step useDiscardChangesConfirmation (header/hardware back) and keeps the core tab-switch discard modal and the resync guard untouched.

jakubkalinski0 · 2026-06-12T14:52:12Z

@codex review

chatgpt-codex-connector · 2026-06-12T14:58:04Z

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 08b559197d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

TaduJR · 2026-06-12T15:19:59Z

Took a deep look at the PR since our flows now compose. It's great!

But one architectural thought: DistanceTabGuardContext is a second guard system parallel to useDiscardChangesConfirmation the odometer screen declares its unsaved state to two APIs, and the modal config is hand-copied into the page (already diverged: the hook restores input focus on Cancel, the tab modal doesn't). Alternative shape: OnyxTabNavigator owns a generic guard registry + the tabPress listener, and useDiscardChangesConfirmation registers into it when rendered under a tab screen. One registration per screen, modal config in one place, and any tabbed flow gets this for free imo.

Smaller things:

screenListeners accepts the function form ({navigation}) => ({tabPress: …}), so the tabBar wrapper and the two refs sniffing its props can go.
activeGuardRef is a single slot with last-writer-wins: visited tabs stay mounted, so a second registering tab would silently disarm the guard. A Map keyed by tab name removes that class.
handleTabSwitchDiscard rejections only Log.warn the user confirmed Discard, a partial reset may have run, and they get no feedback.
The seatbelt entries and the exhaustive-deps suppression look avoidable: typed factories for the test casts, the waitForBatchedUpdates().then() idiom for async/await, and including the omitted deps in the resync effect refs and setters are stable, so it won't re-run more often (and if it did, that's a hook-stability bug worth surfacing).
Also some comments are mile-long, I think we can compress them right, and remove unnecessary ones to reduce the diff like obvious ones that the codes are self explanatory by them selfs.

…gator

…text

…omments

…_modal_when_switching_tabs

…flow

jakubkalinski0 · 2026-06-15T23:17:21Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dd02532305

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…ories Add a Growl.error toast in OnyxTabNavigator when a tab-switch onDiscard rejects (alongside the existing Log.warn + always-jump), so a failed reset isn't silent. Replace remaining no-unsafe-type-assertion casts in the odometer tests with typed factories: OdometerDraft literals are cast-free (all-optional), and Transaction fixtures build on createRandomTransaction. Removes the seatbelt rows for the Backup/UtilsTest/ReadingsState/TransactionBackup tests and trims the two DISTANCE_CREATE route casts to one each.

…ame/size swaps

…_modal_when_switching_tabs

jakubkalinski0 · 2026-06-16T17:01:59Z

@codex review

jakubkalinski0 · 2026-06-16T17:02:06Z

@TaduJR Great input there! I liked your idea and refactored the code in that direction. Could you please check it out if it's more to your liking?

chatgpt-codex-connector · 2026-06-16T17:11:22Z

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 290f76a7dc

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…_modal_when_switching_tabs

jakubkalinski0 · 2026-06-16T21:39:41Z

@DylanDylann All yours! (Don't get scared about the LOC, it's mostly tests 😅 )

DylanDylann · 2026-06-17T08:48:25Z

 "../../tests/ui/ForYouSectionTest.tsx"	"@typescript-eslint/no-unsafe-type-assertion"	3
 "../../tests/ui/IOURequestStartPageTest.tsx"	"@typescript-eslint/no-unsafe-type-assertion"	2
 "../../tests/ui/IOURequestStepAmountDraftTest.tsx"	"@typescript-eslint/no-unsafe-type-assertion"	2
+"../../tests/ui/IOURequestStepDistanceOdometerNextSyncTest.tsx"	"@typescript-eslint/no-unsafe-type-assertion"	1


No need to update it manually. It will be updated automatically when it is merged into main.

DylanDylann · 2026-06-17T09:53:38Z

+        return register({
+            tabName,
+            getHasUnsavedChanges: () => guardCallbacksRef.current.getHasUnsavedChanges(),
+            onDiscard: () => guardCallbacksRef.current.onDiscard?.(),
+            onCancel: () => guardCallbacksRef.current.onCancel?.(),


@jakubkalinski0 When switching away from the distance odometer tab, this tab isn't always unmounted

Screen.Recording.2026-06-17.at.16.39.49.mov

DylanDylann · 2026-06-17T10:00:28Z

    odometerEndImage?: string;
+
+    /** `lastModified` of the start image, preserved so the re-minted image keeps its identity (getOdometerImageIdentity) */
+    odometerStartImageLastModified?: number;


@jakubkalinski0 Why do we need this field?

melvin-bot Bot assigned jakubkalinski0 May 5, 2026

Julesssss mentioned this pull request May 7, 2026

[Odometer] Show discard changes modal when switching tabs with unsaved values #89940

Open

chatgpt-codex-connector Bot reviewed May 11, 2026

View reviewed changes

Comment thread src/pages/iou/request/DistanceRequestStartPage.tsx Outdated

chatgpt-codex-connector Bot reviewed May 11, 2026

View reviewed changes

Comment thread src/pages/iou/request/DistanceRequestStartPage.tsx Outdated

Comment thread src/pages/iou/request/step/confirmation/ReceiptFileValidator.tsx Outdated

chatgpt-codex-connector Bot reviewed May 11, 2026

View reviewed changes

Comment thread src/pages/iou/request/step/confirmation/OdometerReceiptStitcher.tsx Outdated

chatgpt-codex-connector Bot reviewed May 11, 2026

View reviewed changes

Comment thread src/pages/iou/request/step/confirmation/ReceiptFileValidator.tsx Outdated

chatgpt-codex-connector Bot reviewed May 11, 2026

View reviewed changes

Comment thread src/pages/iou/request/DistanceRequestStartPage.tsx Outdated

chatgpt-codex-connector Bot reviewed May 11, 2026

View reviewed changes

Comment thread src/pages/iou/request/step/IOURequestStepDistanceOdometer.tsx

chatgpt-codex-connector Bot reviewed May 11, 2026

View reviewed changes

Comment thread src/pages/iou/request/DistanceRequestStartPage.tsx Outdated

chatgpt-codex-connector Bot reviewed May 11, 2026

View reviewed changes

Comment thread src/pages/iou/request/step/IOURequestStepDistanceOdometer.tsx

chatgpt-codex-connector Bot reviewed May 11, 2026

View reviewed changes

Comment thread src/pages/iou/request/step/IOURequestStepDistanceOdometer.tsx

jakubkalinski0 marked this pull request as ready for review May 11, 2026 21:27

jakubkalinski0 requested review from a team as code owners May 11, 2026 21:27

melvin-bot Bot requested review from DylanDylann and heyjennahay and removed request for a team and heyjennahay May 11, 2026 21:27

TaduJR mentioned this pull request Jun 12, 2026

[$250] Discard changes modal does't show up when going back with the browser back button #84246

Open

7 tasks

jakubkalinski0 added 7 commits June 12, 2026 12:37

fix(odometer): remove duplicate edit-from-confirmation backup effect …

ebd7849

…causing double-restore

fix(odometer): make discard-changes diff re-mint-invariant via image …

3a95d0f

…identity

fix(odometer): guard resync from re-hydrating user-cleared readings o…

fd2a38e

…n tab/back

Merge branch 'main' into jakubkalinski0/Odometer_show_discard_changes…

12269b9

…_modal_when_switching_tabs

chore: prettier run

abef5e3

chore: add reminted to cspell wordlist

08b5591

jakubkalinski0 added 6 commits June 15, 2026 02:29

feat(navigation): add generic tab-switch discard guard to OnyxTabNavi…

572d2e7

…gator

refactor(odometer): adopt generic tab guard, drop DistanceTabGuardCon…

3ec31e7

…text

chore(odometer): typed test factories, drop lint suppressions, trim c…

fd2b2fb

…omments

chore(odometer): trim redundant and verbose comments

a6961d3

Merge branch 'main' into jakubkalinski0/Odometer_show_discard_changes…

2ad7a85

…_modal_when_switching_tabs

docs: condense comments in discard-changes confirmation and odometer …

dd02532

…flow

chore: prettier run

6b7b41d

chatgpt-codex-connector Bot reviewed Jun 15, 2026

View reviewed changes

Comment thread src/libs/OdometerImageUtils.ts Outdated

jakubkalinski0 added 3 commits June 16, 2026 17:23

fix: include lastModified in odometer image identity to detect same-n…

f4576b0

…ame/size swaps

Merge branch 'main' into jakubkalinski0/Odometer_show_discard_changes…

290f76a

…_modal_when_switching_tabs

Merge branch 'main' into jakubkalinski0/Odometer_show_discard_changes…

1e088c9

…_modal_when_switching_tabs

DylanDylann reviewed Jun 17, 2026

View reviewed changes

Conversation

jakubkalinski0 commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Diff overview

Tests vs. non-test source

Inside the 519 non-test insertions

Summary

Deletions (197 lines)

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented May 5, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jakubkalinski0 commented May 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

jakubkalinski0 commented May 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

jakubkalinski0 commented May 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

jakubkalinski0 commented May 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

jakubkalinski0 commented May 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

jakubkalinski0 commented May 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

jakubkalinski0 commented May 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

jakubkalinski0 commented May 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

jakubkalinski0 commented May 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

jakubkalinski0 commented May 5, 2026 •

edited

Loading

codecov Bot commented May 5, 2026 •

edited by github-actions Bot

Loading