-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Docs updates for E/A#85194 Add partial approval from Reports page #89640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -42,6 +42,17 @@ To review and approve a report submitted to you for approval: | |||||
|
|
||||||
| --- | ||||||
|
|
||||||
| ## How to approve a report that contains held expenses | ||||||
|
|
||||||
| If a report contains one or more held expenses, clicking **Approve** (from within the report or from the **Reports** page) displays a confirmation modal with two options: | ||||||
|
|
||||||
| - **Approve only [non-held amount]**: Approves only the compliant (non-held) expenses. The held expenses are moved to a separate report so they can be reviewed independently. | ||||||
| - **Approve [full amount]**: Approves the entire report, including all held expenses. | ||||||
|
|
||||||
| If every expense on the report is held, only the **Approve [full amount]** option is available. | ||||||
|
|
||||||
| --- | ||||||
|
|
||||||
| ## How to add an approver to a report | ||||||
|
|
||||||
| 1. From the Report, choose **More**. | ||||||
|
|
@@ -157,3 +168,7 @@ Expense reports group multiple expenses into one batch for review or payment. Dr | |||||
| ## What happens after I approve a report? | ||||||
|
|
||||||
| The report moves to the next approver in the workflow. If you are the final approver, the report becomes **Approved** and is ready for payment. | ||||||
|
|
||||||
| ## What happens to held expenses when I partially approve a report? | ||||||
|
|
||||||
| When you choose **Approve only**, the held expenses are moved to a new separate report. The non-held expenses are approved on the original report. You can then review and approve the held expenses independently once they are ready. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Naming and style: Per naming conventions, use "Click" or "Select" for UI button interactions instead of "choose."
Suggested change
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Readability / style: The word "compliant" is internal jargon that may not be clear to end users. Consider replacing "compliant (non-held)" with just "non-held" since the parenthetical already clarifies the meaning, or use plain language like "remaining" or "non-held".
Suggestion: