88447: Improve Home page trial banner display#89787
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp<img width="359" height="774" alt="Screenshot 2026-05-18 at 22 00 09" src="https://github.com/user-attachments/assets/5522f5c0-f657-4c38-8fa5-40cea44ec59a" / |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4f5fb7e52
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Looks mostly right to me. Keen on 🦅👀 's thoughts though. @shawnborton Wish we didn't do double |
|
Oh hmm that's odd, @JmillsExpensify that seems incorrect to have two spots to show the same information no? |
|
@JmillsExpensify soft remainder to take a look into above comment. Thanks |
|
in the meantime, please tackle this issue #89787 (comment) @abbasifaizan70 |
Dang yes, that's probably my bad. We should have removed this from Time Sensitive. |
|
@thelullabyy I updated the PR. Removed the Widget from the time-sensitive banner and also removed all unnecessary code, as well as updated test cases in PR. |
@abbasifaizan70 how about this point? Also please update PR title to reflect changes correctly |
@thelullabyy I have already fixed the padding issues. |
|
@abbasifaizan70 I'm asking about the ! issue #89787 (comment) |
|
@abbasifaizan70 Please update the test case as well, I see it doesn't match with new changes |
|
@thelullabyy I updated the test case and also fixed the above-mentioned issue. Thanks |
|
@abbasifaizan70 Test cases and PR desc are still not be updated. Besides, the recordings are not up to date & missing android web and ios web |
|
Overall, the changes LGTM |
|
@thelullabyy I have updated test cases, description, and screenshots as well. |
|
🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.3.78-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. The changes in this PR are:
I checked all help site articles under
None of these articles quote or reference the specific promotional strings that were changed. The "50% off" / "25% off" mentions in Expensify Card Perks articles are about third-party partner discounts (Highfive, Xero, Slack, PagerDuty), which are unrelated to the free trial banner. |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.78-1 🚀
|










Explanation of Change
Fixes Home Free Trial banner vertical alignment with Time sensitive rows (pt3 / 12px top padding on the widget content row). Keeps the 50%/25% trial offer only in FreeTrialSection (live countdown via existing discount helpers, Claim → Subscription), drops the extra ! on offer body copy, and removes the unused Time Sensitive early-discount implementation.
Fixed Issues
$ #88447
PROPOSAL: #88447 (comment)
Tests
Test 1 — Day 1 (50% in Free Trial widget)
Free trial: 30 days left!| bodyGet 50% off your first year(no!on body) |Time remaining: 23h : 59m : XXs(ticking) | greenClaim.Claim→ Account → Subscription (add-card route OK).Test 2 — After 25 hours (25% phase)
Get 25% off your first year(no!) | countdown in days (e.g.6 days) | no 50% / live H:M:S timer.Test 3 — Post-trial
Offline tests
Same as tests.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-05-19.at.12.24.53.AM.mp4
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-05-18.at.3.52.23.PM.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-05-17.at.3.37.06.AM.mov