Skip to content

88447: Improve Home page trial banner display#89787

Merged
puneetlath merged 11 commits into
Expensify:mainfrom
abbasifaizan70:88447
May 19, 2026
Merged

88447: Improve Home page trial banner display#89787
puneetlath merged 11 commits into
Expensify:mainfrom
abbasifaizan70:88447

Conversation

@abbasifaizan70

@abbasifaizan70 abbasifaizan70 commented May 6, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixes Home Free Trial banner vertical alignment with Time sensitive rows (pt3 / 12px top padding on the widget content row). Keeps the 50%/25% trial offer only in FreeTrialSection (live countdown via existing discount helpers, Claim → Subscription), drops the extra ! on offer body copy, and removes the unused Time Sensitive early-discount implementation.

Fixed Issues

$ #88447
PROPOSAL: #88447 (comment)

Tests

  • Verify that no errors appear in the JS console

Test 1 — Day 1 (50% in Free Trial widget)

  1. Go to Home → paste in console:
Onyx.set('nvp_private_firstPolicyCreatedDate', '2025-01-01');
Onyx.set('nvp_private_manualTeam2025Pricing', null);
Onyx.set('nvp_private_firstDayFreeTrial', new Date().toISOString().slice(0, 19));
const l = new Date(); l.setDate(l.getDate() + 30);
Onyx.set('nvp_private_lastDayFreeTrial', l.toISOString().slice(0, 19));
Onyx.set('nvp_private_billingFundID', null);
  1. Right column: Free trial: 30 days left! | body Get 50% off your first year (no ! on body) | Time remaining: 23h : 59m : XXs (ticking) | green Claim.
  2. ClaimAccount → Subscription (add-card route OK).

Test 2 — After 25 hours (25% phase)

  1. On Home → paste :
const past = new Date(Date.now() - 25 * 60 * 60 * 1000);
Onyx.set('nvp_private_firstDayFreeTrial', past.toISOString().slice(0, 19));
  1. Body: Get 25% off your first year (no !) | countdown in days (e.g. 6 days) | no 50% / live H:M:S timer.

Test 3 — Post-trial

  1. On Home → paste:
const expired = new Date(Date.now() - 10 * 24 * 60 * 60 * 1000);
Onyx.set('nvp_private_firstDayFreeTrial', expired.toISOString().slice(0, 19));
  1. No 50%/25% offer (widget hidden or trial-ended / add-card state).

Offline tests

Same as tests.

QA Steps

  • Verify that no errors appear in the JS console
    Same as tests.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message: Link
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2026-05-19.at.12.24.53.AM.mp4
Android: mWeb Chrome Screenshot 2026-05-19 at 12 41 29 AM
iOS: Native
Screen.Recording.2026-05-18.at.3.52.23.PM.mp4
iOS: mWeb Safari Screenshot 2026-05-19 at 12 50 44 AM
MacOS: Chrome / Safari
Screen.Recording.2026-05-17.at.3.37.06.AM.mov

@melvin-bot

melvin-bot Bot commented May 6, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@abbasifaizan70 abbasifaizan70 changed the title 88447 88447: Home - No expected banner shown after running a snippet May 6, 2026
@abbasifaizan70 abbasifaizan70 marked this pull request as ready for review May 6, 2026 23:38
@abbasifaizan70 abbasifaizan70 requested review from a team as code owners May 6, 2026 23:38
@melvin-bot melvin-bot Bot requested review from heyjennahay and thelullabyy and removed request for a team May 6, 2026 23:38
@melvin-bot

melvin-bot Bot commented May 6, 2026

Copy link
Copy Markdown

@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team May 6, 2026 23:38
Comment thread src/components/BaseWidgetItem.tsx Outdated
Comment thread src/pages/home/TimeSensitiveSection/items/EarlyDiscount.tsx Outdated
Comment thread src/pages/home/TimeSensitiveSection/hooks/useTimeSensitiveEarlyDiscount.ts Outdated
@codecov

codecov Bot commented May 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/pages/home/FreeTrialSection/index.tsx 100.00% <100.00%> (ø)
... and 9 files with indirect coverage changes

Comment thread src/languages/es.ts Outdated
@thelullabyy

thelullabyy commented May 8, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

<img width="359" height="774" alt="Screenshot 2026-05-18 at 22 00 09" src="https://github.com/user-attachments/assets/5522f5c0-f657-4c38-8fa5-40cea44ec59a" /

Android: mWeb Chrome Screenshot 2026-05-18 at 21 59 26
iOS: HybridApp Screenshot 2026-05-18 at 22 01 23
iOS: mWeb Safari Screenshot 2026-05-18 at 22 00 43
MacOS: Chrome / Safari Screenshot 2026-05-18 at 21 58 21

@thelullabyy

thelullabyy commented May 8, 2026

Copy link
Copy Markdown
Contributor

@Expensify/design Please help review this "50% off your first year" banner in Time sensitive section

image image

@thelullabyy

Copy link
Copy Markdown
Contributor

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c4f5fb7e52

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/pages/home/TimeSensitiveSection/hooks/useTimeSensitiveEarlyDiscount.ts Outdated
@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

Looks mostly right to me. Keen on 🦅👀 's thoughts though. @shawnborton

Wish we didn't do double !, but if people have approved the copy, then lets roll with it

@shawnborton

Copy link
Copy Markdown
Contributor

Agree with removing one of the !s, otherwise looking good.

One thing that I've always wanted to do with this banner though: when you have a new account, notice how the paddings are slightly difference from right to left:
CleanShot 2026-05-08 at 10 43 59@2x

Ideally it should be this:
CleanShot 2026-05-08 at 10 44 43@2x

The row on the right is missing 12px of top padding.

🦅 👁️, over and out

@thelullabyy

thelullabyy commented May 8, 2026

Copy link
Copy Markdown
Contributor
image image

How about the 50% discount in Time sensitive section? We have another banner here

@shawnborton

Copy link
Copy Markdown
Contributor

Oh hmm that's odd, @JmillsExpensify that seems incorrect to have two spots to show the same information no?

@abbasifaizan70

Copy link
Copy Markdown
Contributor Author

@JmillsExpensify soft remainder to take a look into above comment. Thanks

@thelullabyy

Copy link
Copy Markdown
Contributor

in the meantime, please tackle this issue #89787 (comment) @abbasifaizan70

@JmillsExpensify

Copy link
Copy Markdown
Contributor

Oh hmm that's odd, @JmillsExpensify that seems incorrect to have two spots to show the same information no?

Dang yes, that's probably my bad. We should have removed this from Time Sensitive.

@abbasifaizan70

Copy link
Copy Markdown
Contributor Author

@thelullabyy I updated the PR. Removed the Widget from the time-sensitive banner and also removed all unnecessary code, as well as updated test cases in PR.

@thelullabyy

Copy link
Copy Markdown
Contributor

Agree with removing one of the !s, otherwise looking good.

@abbasifaizan70 how about this point? Also please update PR title to reflect changes correctly

@abbasifaizan70

Copy link
Copy Markdown
Contributor Author

please update PR title to reflect changes correctly

@thelullabyy I have already fixed the padding issues.

@abbasifaizan70 abbasifaizan70 changed the title 88447: Home - No expected banner shown after running a snippet 88447: Improve Home page trial banner display May 17, 2026
@thelullabyy

Copy link
Copy Markdown
Contributor

@abbasifaizan70 I'm asking about the ! issue #89787 (comment)

@thelullabyy

Copy link
Copy Markdown
Contributor

@abbasifaizan70 Please update the test case as well, I see it doesn't match with new changes

@abbasifaizan70

Copy link
Copy Markdown
Contributor Author

@thelullabyy I updated the test case and also fixed the above-mentioned issue. Thanks

@thelullabyy

thelullabyy commented May 18, 2026

Copy link
Copy Markdown
Contributor

@abbasifaizan70 Test cases and PR desc are still not be updated. Besides, the recordings are not up to date & missing android web and ios web

@thelullabyy

Copy link
Copy Markdown
Contributor

Overall, the changes LGTM

@abbasifaizan70

Copy link
Copy Markdown
Contributor Author

@thelullabyy I have updated test cases, description, and screenshots as well.

@thelullabyy thelullabyy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melvin-bot melvin-bot Bot requested a review from puneetlath May 19, 2026 15:01
@puneetlath puneetlath merged commit a9ddce8 into Expensify:main May 19, 2026
44 of 49 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.3.78-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site changes are required for this PR.

The changes in this PR are:

  1. UI padding fix — adds top padding (pt3) to the Free Trial widget for better vertical alignment
  2. Copy tweak — removes the trailing ! from the 50%/25% offer body strings across all language files (e.g., "Get 50% off your first year!" → "Get 50% off your first year")

I checked all help site articles under App/docs/articles/ that reference the free trial, including:

  • new-expensify/getting-started/Expensify-Home-Overview.md — describes the Home page sections but does not quote the banner copy
  • new-expensify/getting-started/Create-a-company-workspace.md — mentions monitoring the free trial but not the banner text
  • new-expensify/getting-started/Track-Personal-Expenses.md — references the free trial status but not the banner text

None of these articles quote or reference the specific promotional strings that were changed. The "50% off" / "25% off" mentions in Expensify Card Perks articles are about third-party partner discounts (Highfive, Xero, Slack, PagerDuty), which are unrelated to the free trial banner.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.78-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants