[HOLD BE] Render Travel Invoicing audit-trail link for QuickBooks Desktop exports#89810
[HOLD BE] Render Travel Invoicing audit-trail link for QuickBooks Desktop exports#89810allgandalf wants to merge 7 commits into
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
I'll check this out in a few hours |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good for product
|
@allgandalf the change set look good. However, I'm unable to complete the manual testing steps since I can't set |
|
Lets hold on this PR for a while, still need to get backend changes in, I'll bump you once those are done so we can resume testing from there |
|
closing, qbd has no clickable urls (codat returns sync ids), would create broken hrefs in oldDot. cleaner to keep qbd in no-link set like sage. we only need https://github.com/Expensify/Integration-Server/pull/8922 for the issue |
Explanation of Change
QBD's export-action audit message wasn't rendering the Travel Invoicing link with a multi-URL fallback. NetSuite App #89339 already added the
travelInvoicingUrlstype and the Oxford-comma fragment renderer. This PR adds the QBD multi-URL fallback to point at the QBO landing page (mirroring QBD's existing nonReimbursableUrls fallback) so a 2+ URL TI list renders one collapsed link instead of dropping into the NetSuite render path.Companion PRs:
Fixed Issues
$ #88272
PROPOSAL:
Tests
Offline tests
No offline behaviour change. The audit-trail message is cached in Onyx via the existing report-action persistence.
QA Steps
Same steps as Tests above, on the staging environment after IS #8922 lands.
PR Author Checklist
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari