Skip to content

[HOLD BE] Render Travel Invoicing audit-trail link for QuickBooks Desktop exports#89810

Closed
allgandalf wants to merge 7 commits into
Expensify:mainfrom
allgandalf:qbd-travel-invoicing-audit-trail
Closed

[HOLD BE] Render Travel Invoicing audit-trail link for QuickBooks Desktop exports#89810
allgandalf wants to merge 7 commits into
Expensify:mainfrom
allgandalf:qbd-travel-invoicing-audit-trail

Conversation

@allgandalf

Copy link
Copy Markdown
Contributor

Explanation of Change

QBD's export-action audit message wasn't rendering the Travel Invoicing link with a multi-URL fallback. NetSuite App #89339 already added the travelInvoicingUrls type and the Oxford-comma fragment renderer. This PR adds the QBD multi-URL fallback to point at the QBO landing page (mirroring QBD's existing nonReimbursableUrls fallback) so a 2+ URL TI list renders one collapsed link instead of dropping into the NetSuite render path.

Companion PRs:

Fixed Issues

$ #88272
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console
  1. on a QBD-connected workspace, set the Travel Invoicing payable account NVP via DB or clitools
  2. seed TI expenses via `expensifytravel:invoicingBilling --no-bill`
  3. submit + approve a mixed report (TI + regular non-reimbursable)
  4. export to QBD
  5. open the report and verify the Concierge audit message renders both "View company card expenses" and "View travel card expenses" links

Offline tests

No offline behaviour change. The audit-trail message is cached in Onyx via the existing report-action persistence.

QA Steps

  • Verify that no errors appear in the JS console

Same steps as Tests above, on the staging environment after IS #8922 lands.

PR Author Checklist

  • I linked the correct issue in the `### Fixed Issues` section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the `Tests` section
    • I added steps for the expected offline behavior in the `Offline steps` section
    • I added steps for Staging and/or Production testing in the `QA steps` section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. `toggleReport` and not `onIconClick`)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to `src/languages/*` files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in `STYLE.md`) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like `Avatar`, I verified the components using `Avatar` are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. `StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)`)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run `npm run compress-svg`)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like `Avatar` is modified, I verified that `Avatar` is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added `Design` label and/or tagged `@Expensify/design` so the design team can review the changes.
  • If a new page is added, I verified it's using the `ScrollView` component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the `main` branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the `Test` steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@allgandalf allgandalf requested review from a team as code owners May 6, 2026 20:08
@melvin-bot melvin-bot Bot requested review from joekaufmanexpensify and suneox and removed request for a team May 6, 2026 20:08
@melvin-bot

melvin-bot Bot commented May 6, 2026

Copy link
Copy Markdown

@suneox Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@codecov

codecov Bot commented May 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/libs/ReportActionsUtils.ts 76.92% <0.00%> (+0.45%) ⬆️
... and 11 files with indirect coverage changes

@suneox

suneox commented May 7, 2026

Copy link
Copy Markdown
Contributor

I'll check this out in a few hours

@joekaufmanexpensify joekaufmanexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for product

@allgandalf allgandalf changed the title Render Travel Invoicing audit-trail link for QuickBooks Desktop exports [HOLD BE] Render Travel Invoicing audit-trail link for QuickBooks Desktop exports May 8, 2026
@suneox

suneox commented May 8, 2026

Copy link
Copy Markdown
Contributor

@allgandalf the change set look good. However, I'm unable to complete the manual testing steps since I can't set travelInvoicingPayableAccount NVP (no DB/clitools access) Any tips on how I should verify the audit trail rendering in this case?

@allgandalf

Copy link
Copy Markdown
Contributor Author

Lets hold on this PR for a while, still need to get backend changes in, I'll bump you once those are done so we can resume testing from there

@allgandalf

Copy link
Copy Markdown
Contributor Author

closing, qbd has no clickable urls (codat returns sync ids), would create broken hrefs in oldDot. cleaner to keep qbd in no-link set like sage. we only need https://github.com/Expensify/Integration-Server/pull/8922 for the issue

@allgandalf allgandalf closed this May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants