-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[No QA] Update Add-Approvals.md #89845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,7 +1,7 @@ | ||||||
| --- | ||||||
| title: Add Approvals | ||||||
| description: Require report approvals in your Expensify workspace, including setting approval thresholds and over-limit approvers. | ||||||
| keywords: [New Expensify, approvals, report approvals, approving reports, approval workflow, workspace workflows, approver, final approver, approval chain, approval threshold, approval limit, over-limit approval, report amount limit, dollar limit approver, reassign approver, automatic approver reassignment, change approver workflow] | ||||||
| keywords: [New Expensify, approvals, report approvals, approving reports, approval workflow, workspace workflows, approver, final approver, approval chain, approval threshold, approval limit, over-limit approval, report amount limit, dollar limit approver, reassign approver, automatic approver reassignment, change approver workflow, automatic approval, approval audit] | ||||||
| --- | ||||||
|
|
||||||
| Each Expensify workspace can be configured to require additional approvals for reports before payments are authorized. When approvals are enabled, admins can set a default approval workflow for all members or create custom workflows for individual members. | ||||||
|
|
@@ -81,6 +81,27 @@ You can update or remove approval workflows at any time as your team or process | |||||
|
|
||||||
| --- | ||||||
|
|
||||||
| ## Enable Concierge to auto-approve compliant reports | ||||||
|
|
||||||
| Concierge can automatically approve reports that don't exceed a specific threshold and don't contain violations. | ||||||
|
|
||||||
| ## Set the auto-approve threshold | ||||||
|
kadiealexander marked this conversation as resolved.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Heading / AI readiness: Per HELP_AUTHORING_GUIDELINES.md Section 6, headings should include the feature name to be searchable and feature-specific. "Set the auto-approve threshold" is generic -- consider something like |
||||||
|
|
||||||
| 1. On the **Workflows** page, click the **Auto-approve compliant reports** toggle. | ||||||
| 2. Click **Auto-approve reports with all expenses under** | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Step formatting: This step is missing a period at the end. All other steps in this article end with a period for consistency.
Suggested change
|
||||||
| 3. Enter the maximum amount a report can have before requiring manual approval. | ||||||
| 4. Click **Save**. | ||||||
|
|
||||||
| ## Set a random audit percentage | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Heading / AI readiness: Same as the heading on line 88 -- "Set a random audit percentage" lacks the feature name. Consider |
||||||
|
|
||||||
| Even with auto-approvals enabled, you can route a percentage of compliant reports for manual approval. | ||||||
|
|
||||||
|
kadiealexander marked this conversation as resolved.
|
||||||
| 1. On the **Workflows** page, click **Random report audit**. | ||||||
| 2. Enter your desired percentage amount. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Style / deterministic writing: "Enter your desired percentage amount" uses subjective language ("your desired"). Per HELPSITE_NAMING_CONVENTIONS.md deterministic writing rules, prefer literal and exact phrasing. Consider: "Enter the percentage of compliant reports to route for manual approval." |
||||||
| 3. Click **Save**. | ||||||
|
|
||||||
| **Note:** Custom auto-approval settings are only available on the Control plan. Collect plans will have a $100 auto-approval threshold and 0% random audit percentage. | ||||||
|
|
||||||
| # FAQ | ||||||
|
|
||||||
| ## Can an employee have more than one approval workflow applied to them? | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Structure / heading hierarchy: This heading introduces a concept ("Enable Concierge to auto-approve compliant reports") followed by a description paragraph, but then lines 88 and 95 use peer-level
##headings for the sub-tasks underneath it. Since###is not allowed per HELP_AUTHORING_GUIDELINES.md Section 4, this creates a flat structure where the relationship between the overview heading and its sub-tasks is unclear.Consider restructuring so that lines 88-103 are folded into this section as a single set of steps (similar to how "Set the Default Approval Workflow" handles optional sub-steps), or rewrite this heading as a "How to..." heading (e.g.,
## How to enable Concierge auto-approval for compliant reports) and merge the steps below into one numbered sequence. This would also satisfy the requirement from Section 6 that the article include at least one "How to..." heading with the feature name.