perf: narrow Onyx subs in InvoiceSenderField and ReportField by OlimpiaZurek · Pull Request #90311 · Expensify/App

OlimpiaZurek · 2026-05-12T08:29:50Z

Explanation of Change

Both InvoiceSenderField and ReportField subscribed to Onyx collections without selectors, causing re-renders on every mutation across all policies/reports. This narrows them to per-key or selector-scoped subscriptions.
PR 1 of 4. Follow-up: #90208 (structural decomposition of MoneyRequestConfirmationListFooter). Subsequent PRs will narrow leaf Onyx subscriptions and add a ConfirmationFieldsProvider.

Results from profiling ( scenario: confirmation page open (policy-expense flow), then triggered an unrelated mutation (add/remove a tag in workspace):

🟢 Total profiling duration: −286.9 ms (−17.7%)
🟢 Commit count: −19

Fixed Issues

$ #90385

Tests

Open an Invoice flow → confirmation page renders with sender workspace shown correctly
Switch sender workspace → field updates
Open an Expense flow on a policy expense chat → Report field renders with outstanding reports list
Change the selected report → field updates correctly
Verify no regressions in the confirmation page for regular submit/split/track flows

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ba04c097ce

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-12T10:55:21Z

+    const [canUpdateSenderWorkspace] = useOnyx(ONYXKEYS.COLLECTION.POLICY, {
+        selector: createCanUpdateSenderWorkspaceSelector(selectedParticipants, currentUserLogin, isFromGlobalCreate),
+    });


Add dependencies for sender-workspace selector

When the policy collection is already cached and currentUserLogin, selectedParticipants, or isFromGlobalCreate changes afterward, this selector keeps the previously selected value because useOnyx only re-runs selector closures for external values when the dependency argument is provided. In the common initial-load path the selector can evaluate with currentUserLogin still undefined and leave canUpdateSenderWorkspace false, so eligible global invoice creators cannot open the “Send from” workspace picker until some unrelated policy update occurs.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-05-12T10:55:21Z

+    const policyID = selectedParticipants?.at(0)?.policyID;
    const [reportNameValuePairs] = useOnyx(ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS);
-    const [outstandingReportsByPolicyID] = useOnyx(ONYXKEYS.DERIVED.OUTSTANDING_REPORTS_BY_POLICY_ID);
+    const [outstandingReportsForPolicy] = useOnyx(ONYXKEYS.DERIVED.OUTSTANDING_REPORTS_BY_POLICY_ID, {selector: createOutstandingReportsForPolicySelector(policyID)});


Refresh selected outstanding reports when policy changes

This selector closes over policyID but the useOnyx call does not pass policyID as a dependency, so changing the participant/workspace while staying on the confirmation screen can leave outstandingReportsForPolicy selected for the previous policy. That makes the displayed/default report come from the wrong workspace until the derived outstanding-reports object changes for another reason; pass the policy ID in the dependency list so the selector is re-applied immediately.

Useful? React with 👍 / 👎.

trjExpensify · 2026-05-12T21:40:12Z

PR doesn’t need product input as a performance PR. Unassigning and unsubscribing myself.

ShridharGoel · 2026-05-13T16:39:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-05-16.at.1.26.42.AM.mov

Android: mWeb Chrome

Screen.Recording.2026-05-15.at.11.45.03.PM.mov

iOS: HybridApp

Screen.Recording.2026-05-15.at.11.32.56.PM.mov

iOS: mWeb Safari

Screen.Recording.2026-05-15.at.11.38.07.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2026-05-15.at.11.39.43.PM.mov

ShridharGoel · 2026-05-14T18:20:21Z

Can we also include the perf metric changes in the description? Would be helpful for future reference.

Julesssss · 2026-05-14T21:28:17Z

@OlimpiaZurek BartekObudzinski's new agent-device metric skill might help with this

OlimpiaZurek · 2026-05-15T11:20:54Z

Can we also include the perf metric changes in the description? Would be helpful for future reference.

This PR is part of a bigger refactor, so span metrics probably won’t show any statistically significant improvement on their own. What this PR actually improves is how often these components re-render. I added profiling results to the PR description.

ShridharGoel · 2026-05-15T17:56:35Z

Can we get an adhoc build for Android?

github-actions · 2026-05-15T19:20:57Z

🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here.

ShridharGoel · 2026-05-15T19:42:48Z

        return name;
    })();

    const outstandingReports = useOutstandingReports(undefined, isFromGlobalCreate && !isPerDiemRequest ? undefined : policyID, ownerAccountID, false);


Should we be using the scoped selector here as well?

The hook has two paths. If selectedPolicyID exists, it only reads a single entry, so that part is scopeable. But for personal / self-DM / global create flows, it has to iterate through all policies, which means it still needs the full map.So to support both cases, we’d either need to add a second scoped subscription inside the same hook (which every caller would pay for, even if they don’t benefit from it), or split this into two separate hooks and migrate call sites accordingly. Both options feel like extra complexity for pretty limited gains here

Thanks for the explanation

melvin-bot · 2026-05-19T18:01:45Z

@Julesssss looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2026-05-19T18:12:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-05-19T18:23:11Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-19T18:29:27Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #90311.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-66ad67d-67d807d-e7c58144190c74ebfc5bb08c48ae74efc6031500/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-66ad67d-67d807d-579bf194f739142a02204956a688f335eea9ba3c/index.html

Web 🕸️
https://90311.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

Julesssss · 2026-05-19T20:14:20Z

@Julesssss looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

Don't recall, but not emergency.

OSBotify · 2026-05-19T22:08:07Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.78-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-19T22:11:50Z

No help site changes are needed for this PR.

This is a performance optimization that narrows Onyx subscriptions in InvoiceSenderField and ReportField to reduce unnecessary re-renders. There are no user-facing behavior changes, new features, UI changes, or terminology updates that would require documentation updates.

OSBotify · 2026-05-21T21:26:14Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.78-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

perf: narrow Onyx subs in InvoiceSenderField and ReportField

ba04c09

melvin-bot Bot assigned OlimpiaZurek May 12, 2026

OlimpiaZurek mentioned this pull request May 12, 2026

Refactor: extract sections from MoneyRequestConfirmationListFooter #90208

Merged

52 tasks

OlimpiaZurek marked this pull request as ready for review May 12, 2026 10:48

OlimpiaZurek requested review from a team as code owners May 12, 2026 10:48

melvin-bot Bot requested review from marcochavezf and trjExpensify and removed request for a team May 12, 2026 10:48

This comment was marked as outdated.

Sign in to view

chatgpt-codex-connector Bot reviewed May 12, 2026

View reviewed changes

fix: pass selector dependencies to useOnyx

19f93d1

OlimpiaZurek mentioned this pull request May 12, 2026

[Metrics] Create Expense flows #81849

Open

trjExpensify removed their request for review May 12, 2026 21:40

Julesssss mentioned this pull request May 12, 2026

[Tracking] Refactor MoneyRequestConfirmationListFooter to reduce re-renders #90385

Open

Julesssss requested review from Julesssss, ShridharGoel and cristipaval and removed request for marcochavezf May 12, 2026 21:59

Merge branch 'main' into narrow-invoice-and-report-selectors

a77fe4c

Merge branch 'main' into narrow-invoice-and-report-selectors

b08c709

This comment has been minimized.

Sign in to view

ShridharGoel reviewed May 15, 2026

View reviewed changes

ShridharGoel approved these changes May 19, 2026

View reviewed changes

Julesssss approved these changes May 19, 2026

View reviewed changes

Julesssss merged commit 66ad67d into Expensify:main May 19, 2026
48 of 50 checks passed

melvin-bot Bot added the Emergency label May 19, 2026

Julesssss removed the Emergency label May 19, 2026

OSBotify mentioned this pull request May 19, 2026

Deploy Checklist: New Expensify 2026-05-19 #91122

Closed

39 tasks

Conversation

OlimpiaZurek commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

This comment was marked as outdated.

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 12, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot May 12, 2026

Choose a reason for hiding this comment

Uh oh!

trjExpensify commented May 12, 2026

Uh oh!

ShridharGoel commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ShridharGoel commented May 14, 2026

Uh oh!

Julesssss commented May 14, 2026

Uh oh!

OlimpiaZurek commented May 15, 2026

Uh oh!

ShridharGoel commented May 15, 2026

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

This comment has been minimized.

ShridharGoel May 15, 2026

Choose a reason for hiding this comment

Uh oh!

OlimpiaZurek May 18, 2026

Choose a reason for hiding this comment

Uh oh!

ShridharGoel May 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melvin-bot Bot commented May 19, 2026

Uh oh!

OSBotify commented May 19, 2026

Uh oh!

github-actions Bot commented May 19, 2026

Uh oh!

github-actions Bot commented May 19, 2026

Uh oh!

Julesssss commented May 19, 2026

Uh oh!

OSBotify commented May 19, 2026

Uh oh!

MelvinBot commented May 19, 2026

Uh oh!

OSBotify commented May 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

OlimpiaZurek commented May 12, 2026 •

edited

Loading

ShridharGoel commented May 13, 2026 •

edited

Loading