Skip to content

feat: Hide most sections for agents in account page#90371

Merged
NicolasBonet merged 18 commits into
mainfrom
feat/90248-hide-account-items
May 19, 2026
Merged

feat: Hide most sections for agents in account page#90371
NicolasBonet merged 18 commits into
mainfrom
feat/90248-hide-account-items

Conversation

@NicolasBonet

@NicolasBonet NicolasBonet commented May 12, 2026

Copy link
Copy Markdown
Contributor

Hides the following sections from accounts:

  • Subscription
  • Wallet
  • Agents
  • Preferences
  • Security

Explanation of Change

Fixed Issues

$ #90248
PROPOSAL: https://expensify.enterprise.slack.com/docs/T03SC9DTT/F0AKV1FPD41?focus_section_id=temp:C:PDZf756705845f1464c9cffffcb8

Tests

  1. As the agent owner, copilot into the agent account.
  2. Open Account.
  3. Verify the sections listed above are not visible.
  4. Verify Profile, Troubleshoot, Copilot, Sign out, etc are still visible.
  5. In web, go to a route you shouldn't have access to like: /settings/agents, you shouldn't be able to see it.
  6. Return to the owner account and confirm the hidden entries reappear for a regular account.
  • Verify that no errors appear in the JS console

Offline tests

No special test needed.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I verified that similar component doesn't exist in the codebase
  • I verified that all props are defined accurately and each prop has a /** comment above it */
  • I verified that each file is named correctly
  • I verified that each component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • I verified that the only data being stored in component state is data necessary for rendering and nothing else
  • In component if we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • I verified that component internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • I verified that all JSX used for rendering exists in the render method
  • I verified that each component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

Screenshots/Videos

Android: Native
screen-20260512-150918-1778616531875.mp4
Android: mWeb Chrome
screen-20260512-150636-1778616373757.mp4
iOS: Native
ScreenRecording_05-13-2026.17-43-35_1.mp4
iOS: mWeb Safari
ScreenRecording_05-13-2026.17-32-56_1.mp4
MacOS: Chrome / Safari
Screen.Recording.2026-05-12.at.2.37.44.PM.mov

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @NicolasBonet has triggered a test Expensify/App build. You can view the workflow run here.

@codecov

codecov Bot commented May 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/CONST/index.ts 92.30% <ø> (ø)
.../Navigation/AppNavigator/withAgentAccessDenied.tsx 100.00% <100.00%> (ø)
src/pages/settings/InitialSettingsPage.tsx 85.50% <100.00%> (+85.50%) ⬆️
src/components/DelegateNoAccessWrapper.tsx 69.23% <80.00%> (+15.06%) ⬆️
...AppNavigator/Navigators/SettingsSplitNavigator.tsx 12.00% <0.00%> (ø)
...gation/AppNavigator/ModalStackNavigators/index.tsx 6.72% <0.00%> (ø)
... and 13 files with indirect coverage changes

@NicolasBonet NicolasBonet marked this pull request as ready for review May 12, 2026 20:11
@NicolasBonet NicolasBonet requested review from a team as code owners May 12, 2026 20:11
@melvin-bot melvin-bot Bot requested review from ahmedGaber93 and flaviadefaria and removed request for a team May 12, 2026 20:11
@melvin-bot

melvin-bot Bot commented May 12, 2026

Copy link
Copy Markdown

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team May 12, 2026 20:11

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 18c80ca9d7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/pages/settings/InitialSettingsPage.tsx
Comment thread src/pages/settings/InitialSettingsPage.tsx
@NicolasBonet NicolasBonet force-pushed the feat/90247-hide-non-applicable-profile-sections-for-agents branch from 9a07c27 to f09ddb2 Compare May 13, 2026 17:06
@NicolasBonet NicolasBonet force-pushed the feat/90248-hide-account-items branch from 29cd61d to f14b58b Compare May 13, 2026 17:10
@yuwenmemon

Copy link
Copy Markdown
Contributor

Should this PR be held on another, or is this just a proposal to merge into a feature branch?

@NicolasBonet

Copy link
Copy Markdown
Contributor Author

Should this PR be held on another, or is this just a proposal to merge into a feature branch?

This re-uses some logic of #90259, that is why the target isn't main, once we merge that one this will focus on main with the same changes we've right now.

Base automatically changed from feat/90247-hide-non-applicable-profile-sections-for-agents to main May 13, 2026 22:00
@NicolasBonet NicolasBonet force-pushed the feat/90248-hide-account-items branch from f14b58b to 166404e Compare May 13, 2026 22:01
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @NicolasBonet has triggered a test Expensify/App build. You can view the workflow run here.

@Expensify Expensify deleted a comment from github-actions Bot May 13, 2026
@ShridharGoel

ShridharGoel commented May 14, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-05-16.at.12.28.19.AM.mov
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-05-16.at.12.24.58.AM.mov

@ShridharGoel

ShridharGoel commented May 14, 2026

Copy link
Copy Markdown
Contributor

Verify the sections listed above are not visible.

We can also mention the sections which are not visible, in the testing steps.

@ShridharGoel

Copy link
Copy Markdown
Contributor

The remove copilot option should also show "Not so fast" dialog.

Also, should we even show this screen, since anyways the agent account can't make any changes?

Screen.Recording.2026-05-14.at.8.18.55.PM.mov

@NicolasBonet

NicolasBonet commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

The remove copilot option should also show "Not so fast" dialog.

The copilot part has a different issue @ShridharGoel : #90251

@NicolasBonet NicolasBonet force-pushed the feat/90248-hide-account-items branch from 166404e to d16eef2 Compare May 14, 2026 16:29
@NicolasBonet

Copy link
Copy Markdown
Contributor Author

@ShridharGoel I updated the pr with the list of sections hidden

@NicolasBonet NicolasBonet force-pushed the feat/90248-hide-account-items branch from d16eef2 to eba50ce Compare May 14, 2026 19:47
…tion for non-agent accounts and enhance tests for agent account visibility
…in AddAgentPage, EditAgentPage, EditNamePage, EditPromptPage, and SecuritySettingsPage
…n in various settings and navigation components
… to streamline access control and improve component structure
…HOC in multiple settings and profile pages to enhance access control and improve component structure
…ge, and MergeResultPage to clean up code and improve maintainability
…ontrol behavior for agent and non-agent accounts
…ssDenied test file to improve consistency and maintainability
@NicolasBonet NicolasBonet force-pushed the feat/90248-hide-account-items branch from 0093b93 to 5729d79 Compare May 18, 2026 21:41

@ShridharGoel ShridharGoel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are still unguarded:

SCREENS.SETTINGS.PROFILE.LEGAL_NAME
DYNAMIC_ROUTES.VERIFY_ACCOUNT
DYNAMIC_ROUTES.ADD_BANK_ACCOUNT_VERIFY_ACCOUNT

Approving, the above can be added before merging (or in a separate pull request)

@NicolasBonet NicolasBonet merged commit 1fc7d1d into main May 19, 2026
42 checks passed
@NicolasBonet NicolasBonet deleted the feat/90248-hide-account-items branch May 19, 2026 14:09
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @NicolasBonet has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@puneetlath

Copy link
Copy Markdown
Contributor

These are still unguarded:

I feel like that's probably worth adding. What do you think @NicolasBonet?

@NicolasBonet

Copy link
Copy Markdown
Contributor Author

I feel like that's probably worth adding. What do you think @NicolasBonet?

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/NicolasBonet in version: 9.3.78-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site changes are required for this PR.

This PR hides Subscription, Wallet, Agents, Preferences, and Security sections specifically for agent accounts when copiloted into. The help site articles are written for general end users and correctly describe the experience for them.

While several articles reference these sections (e.g., Copilot-Access.md references Account > Security, billing articles reference Account > Subscription), adding agent-specific caveats would be unnecessary noise — agent accounts are a specialized internal account type, and their restrictions don't affect the instructions for regular users or copilots.

@mitarachim

Copy link
Copy Markdown

@NicolasBonet This PR is failing in step 5 because of a regression issue #91145

Screenshot 2026-05-20 at 8 31 49 AM

The issue is reproducible in: web

Bug7158400_1779239299598.Recording__2216.mp4

@NicolasBonet

Copy link
Copy Markdown
Contributor Author

@NicolasBonet This PR is failing in step 5 because of a regression issue #91145

it actually works? The idea is you cannot see the agents page anymore, so this is intended, we could redirect to the agent profile if the page isn't accessible or something else but the functionality isn't broken it might need polishing tho.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.78-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants