Skip to content

[No QA] Docs updates for E/A#90276 Remove auto-select first item from QBD export fields#90569

Merged
stephanieelliott merged 1 commit into
mainfrom
melvin-docsUpdatesForEA90276
May 15, 2026
Merged

[No QA] Docs updates for E/A#90276 Remove auto-select first item from QBD export fields#90569
stephanieelliott merged 1 commit into
mainfrom
melvin-docsUpdatesForEA90276

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Summary

  • Updates the QuickBooks Desktop help article (Configure-QuickBooks-Desktop.md) to remove language stating that company card export fields default to the first item in the imported list.
  • Fields like credit card account, debit card account, accounts payable account, and default vendor now require explicit user selection, matching the behavior introduced in Stop auto-selecting first item on NetSuite/Xero accounting settings rows #90276.

Related PR

#90276 — Stop auto-selecting first item on NetSuite/Xero/QBD accounting settings rows

The accounting settings for company card expenses no longer auto-select the
first item in the list when no value is saved. Update the help site article
to reflect that users must explicitly select a value.

Co-authored-by: Benjamin Limpich <blimpich@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label May 13, 2026
@blimpich blimpich marked this pull request as ready for review May 13, 2026 22:39
@blimpich

Copy link
Copy Markdown
Contributor

This pr is correct, necessary update

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a small, focused update to the QuickBooks Desktop configuration article, replacing four lines that described default auto-selected values (e.g., "First credit card account in the imported list (default)") with action-oriented instructions (e.g., "Select a credit card account from the imported list"). The change aligns the documentation with the product behavior introduced in #90276, where these fields no longer auto-select the first item.

Scores Summary

  • Readability: 9/10 - The new phrasing is clearer and more action-oriented. Each bullet now tells the user what to do rather than describing a passive default, which improves scannability and reduces confusion.
  • AI Readiness: 8/10 - The change is limited to inline bullet descriptions and does not affect headings, metadata, or YAML frontmatter. The existing article structure (which predates this PR) has known heading issues (e.g., # Step 4: Configure Advanced Settings uses a generic "Step N" pattern forbidden by the authoring guidelines), but those are outside the scope of this diff.
  • Style Compliance: 9/10 - The updated text uses exact UI field names in bold, consistent sentence structure, and action verbs ("Select"). This follows the naming conventions well.

Key Findings

  • The diff is small (4 lines changed) and surgically correct -- it removes inaccurate "default" language that no longer reflects product behavior.
  • The new phrasing ("Select a credit card account from the imported list") is consistently structured across all four bullets, which aids readability and predictability.
  • No new headings, metadata, or structural elements were introduced, so there is minimal governance surface area to evaluate.
  • The existing article has pre-existing governance issues (generic step-number headings, heading hierarchy using # for multiple sections), but these are not part of this PR and should be addressed separately.

Recommendations

  • No blocking issues with the proposed changes. This is a clean, accurate update.
  • Consider filing a follow-up to bring the full article into compliance with current heading rules (replace # Step 1 through # Step 4 with task-based headings, and ensure only one # heading is used for the article title with ## for all sections).

Files Reviewed

  • docs/articles/new-expensify/connections/quickbooks-desktop/Configure-QuickBooks-Desktop.md -- 4 lines updated to replace default-value descriptions with explicit selection instructions. Changes are accurate and well-written.

Review based on docs/HELP_AUTHORING_GUIDELINES.md, docs/HELPSITE_NAMING_CONVENTIONS.md, and docs/TEMPLATE.md governance standards.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 67f681376c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +86 to +89
* **Credit card account**: Select a credit card account from the imported list
* **Debit card account**: Select a bank account from the imported list
* **Accounts payable account**: Select an Accounts Payable account (for vendor bills)
* **Default vendor**: Select a vendor from the imported list (for vendor bills)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Don't document manual selection before behavior ships

This new wording says users must explicitly select each QBD company-card account/vendor, but the current QBD flow still auto-fills them when the export type is changed: QuickbooksDesktopCompanyCardExpenseAccountSelectCardPage takes row.accounts.at(0)?.id and sends it as NON_REIMBURSABLE_ACCOUNT (lines 80-89), and vendor-bill uses vendors?.[0]?.id as the default vendor (lines 68-74). The dynamic account page also displays the first account when none is saved (DynamicQuickbooksDesktopCompanyCardExpenseAccountPage line 37). Until that app behavior changes in this branch, this help article will mislead admins who switch between Credit card/Debit card/Vendor bill and still get the first imported account/vendor selected automatically.

Useful? React with 👍 / 👎.

@stephanieelliott stephanieelliott merged commit f96597b into main May 15, 2026
30 checks passed
@stephanieelliott stephanieelliott deleted the melvin-docsUpdatesForEA90276 branch May 15, 2026 02:14
@melvin-bot melvin-bot Bot added the Emergency label May 15, 2026
@melvin-bot

melvin-bot Bot commented May 15, 2026

Copy link
Copy Markdown

@stephanieelliott looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a small, focused change to four bullet points in the "Company Card Expenses" subsection of the QuickBooks Desktop configuration article. The change replaces passive, description-oriented language ("First credit card account in the imported list (default)") with action-oriented selection instructions ("Select a credit card account from the imported list"). This is a positive directional improvement that better aligns with the governance requirement that step instructions be action-oriented.

Scores Summary

  • Readability: 8/10 - The revised lines are clearer and more scannable. Each bullet now tells the user what to do rather than describing a system default. The parallel "Select a/an..." structure is consistent and easy to follow.
  • AI Readiness: 7/10 - The changes themselves are well-written for retrieval. However, this score reflects that the broader file (which is not part of this diff and therefore not penalized) has pre-existing structural issues. The changed lines use exact feature names and clear task language, which is good for AI retrieval.
  • Style Compliance: 8/10 - The changes correctly bold UI field labels, use action-oriented phrasing, and maintain consistent formatting. Field names like Credit card account, Debit card account, Accounts payable account, and Default vendor are bolded appropriately per naming conventions.

Key Findings

  • Positive: The shift from "First X in the imported list (default)" to "Select a/an X from the imported list" directly addresses the governance requirement in HELP_AUTHORING_GUIDELINES.md Section 5 that instructions be "action-oriented" and "aligned with actual UI flow."
  • Positive: Consistent parallel structure across all four bullet points improves scannability.
  • Minor observation: The old text communicated what the default selection would be, which could be useful context for users. The new text removes this default-value information entirely. If the UI does pre-select a default, it may be worth preserving that detail (e.g., "Select a credit card account from the imported list (defaults to the first account)"). However, if the UI requires an explicit selection with no pre-populated default, the current wording is correct.

Recommendations

  1. Verify default behavior: Confirm whether the UI pre-selects a default value for these fields. If it does, consider appending default information to preserve that context while keeping the action-oriented phrasing.
  2. No blocking issues: The changes are a clear improvement and can be merged as-is from a documentation quality standpoint.

Files Reviewed

  • docs/articles/new-expensify/connections/quickbooks-desktop/Configure-QuickBooks-Desktop.md - Four lines updated from descriptive to action-oriented language. Clean, well-scoped change.

Note: This review assessed only the proposed changes in the diff, not unchanged portions of the file.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.74-7 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.74-7 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@IuliiaHerets

Copy link
Copy Markdown

Any QA steps here?

cc @stephanieelliott

@stephanieelliott

Copy link
Copy Markdown
Contributor

Oops, no - thank you @IuliiaHerets!

@stephanieelliott stephanieelliott changed the title Docs updates for E/A#90276 Remove auto-select first item from QBD export fields [No QA] Docs updates for E/A#90276 Remove auto-select first item from QBD export fields May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Emergency HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants