[No QA] Docs updates for E/A#90276 Remove auto-select first item from QBD export fields#90569
Conversation
The accounting settings for company card expenses no longer auto-select the first item in the list when no value is saved. Update the help site article to reflect that users must explicitly select a value. Co-authored-by: Benjamin Limpich <blimpich@users.noreply.github.com>
|
This pr is correct, necessary update |
HelpDot Documentation ReviewOverall AssessmentThis PR makes a small, focused update to the QuickBooks Desktop configuration article, replacing four lines that described default auto-selected values (e.g., "First credit card account in the imported list (default)") with action-oriented instructions (e.g., "Select a credit card account from the imported list"). The change aligns the documentation with the product behavior introduced in #90276, where these fields no longer auto-select the first item. Scores Summary
Key Findings
Recommendations
Files Reviewed
Review based on docs/HELP_AUTHORING_GUIDELINES.md, docs/HELPSITE_NAMING_CONVENTIONS.md, and docs/TEMPLATE.md governance standards. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 67f681376c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| * **Credit card account**: Select a credit card account from the imported list | ||
| * **Debit card account**: Select a bank account from the imported list | ||
| * **Accounts payable account**: Select an Accounts Payable account (for vendor bills) | ||
| * **Default vendor**: Select a vendor from the imported list (for vendor bills) |
There was a problem hiding this comment.
Don't document manual selection before behavior ships
This new wording says users must explicitly select each QBD company-card account/vendor, but the current QBD flow still auto-fills them when the export type is changed: QuickbooksDesktopCompanyCardExpenseAccountSelectCardPage takes row.accounts.at(0)?.id and sends it as NON_REIMBURSABLE_ACCOUNT (lines 80-89), and vendor-bill uses vendors?.[0]?.id as the default vendor (lines 68-74). The dynamic account page also displays the first account when none is saved (DynamicQuickbooksDesktopCompanyCardExpenseAccountPage line 37). Until that app behavior changes in this branch, this help article will mislead admins who switch between Credit card/Debit card/Vendor bill and still get the first imported account/vendor selected automatically.
Useful? React with 👍 / 👎.
|
@stephanieelliott looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
HelpDot Documentation ReviewOverall AssessmentThis PR makes a small, focused change to four bullet points in the "Company Card Expenses" subsection of the QuickBooks Desktop configuration article. The change replaces passive, description-oriented language ("First credit card account in the imported list (default)") with action-oriented selection instructions ("Select a credit card account from the imported list"). This is a positive directional improvement that better aligns with the governance requirement that step instructions be action-oriented. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This review assessed only the proposed changes in the diff, not unchanged portions of the file. |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.74-7 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.74-7 🚀
|
|
Any QA steps here? |
|
Oops, no - thank you @IuliiaHerets! |
Summary
Configure-QuickBooks-Desktop.md) to remove language stating that company card export fields default to the first item in the imported list.Related PR
#90276 — Stop auto-selecting first item on NetSuite/Xero/QBD accounting settings rows