[No qa] Move files for EditableCell#90780
Conversation
There was a problem hiding this comment.
💡 Codex Review
Moving EditableCell out of src/components/Table removes the module that the app entry point still uses: a repo-wide search shows src/App.tsx still imports EditingCellProvider from ./components/Table/EditableCell, while this commit only leaves the provider under TransactionItemRow/EditableCell. Any build that loads App.tsx will fail module resolution until that import is updated or a compatibility re-export is left behind.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.3.75-0 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed the changes in this PR. It's a pure internal refactor that moves the No help site documentation changes are required. |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.75-14 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
The 'EditableCell' component (added in #89166) has nothing to do with the common 'Table' component, so lets move it closer to where it is used
Fixed Issues
N/A
Tests
N/A
Offline tests
N/a
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videosundefined