Skip to content

Fix #90861: preserve test drive suggestion when in: typed without value#90887

Closed
weilixiong wants to merge 1 commit into
Expensify:mainfrom
weilixiong:fix-90861-testdrive
Closed

Fix #90861: preserve test drive suggestion when in: typed without value#90887
weilixiong wants to merge 1 commit into
Expensify:mainfrom
weilixiong:fix-90861-testdrive

Conversation

@weilixiong

@weilixiong weilixiong commented May 16, 2026

Copy link
Copy Markdown

$ #90861\n\nProblem: "Take a test drive" suggestion no longer appears when typing "in:" in search.\n\nRoot cause: PR #83138 introduced logic that auto-forces type=CHAT when an in: filter is present without an explicit type:. This correctly handles completed in: filters, but also triggers when the user typed in: with no value (autocomplete mode), suppressing onboarding suggestions.\n\nFix: Added a check ensuring in: filter has a non-empty value before forcing type=CHAT.\n\nFile: src/libs/SearchQueryUtils.ts

@weilixiong weilixiong requested review from a team as code owners May 16, 2026 18:03
@melvin-bot melvin-bot Bot requested review from marcochavezf and trjExpensify and removed request for a team May 16, 2026 18:03
@melvin-bot

melvin-bot Bot commented May 16, 2026

Copy link
Copy Markdown

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi @weilixiong, thanks for your interest in contributing to Expensify!

This PR has been automatically closed because it doesn't appear to meet our contribution requirements:

  • You are not a member of the Expensify GitHub organization
  • No linked GitHub issue was found in the PR description where you are listed as an assignee
  • No linked GitHub PR was found in the PR description where you are the author or a reviewer

If you'd like to contribute, please make sure to:

  1. Find an open issue you'd like to work on
  2. Get assigned to the issue by following our contribution process
  3. Link the issue in your PR description using the format: $ https://github.com/Expensify/App/issues/<issueID>

Please review our contributing guidelines for more details.

If you believe this was closed in error, please reach out in the #expensify-open-source Slack channel.

@github-actions github-actions Bot closed this May 16, 2026
@github-actions github-actions Bot locked as spam and limited conversation to collaborators May 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant