Fix #90861: preserve test drive suggestion when in: typed without value#90887
Closed
weilixiong wants to merge 1 commit into
Closed
Fix #90861: preserve test drive suggestion when in: typed without value#90887weilixiong wants to merge 1 commit into
weilixiong wants to merge 1 commit into
Conversation
|
@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
|
👋 Hi @weilixiong, thanks for your interest in contributing to Expensify! This PR has been automatically closed because it doesn't appear to meet our contribution requirements:
If you'd like to contribute, please make sure to:
Please review our contributing guidelines for more details. If you believe this was closed in error, please reach out in the #expensify-open-source Slack channel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$ #90861\n\nProblem: "Take a test drive" suggestion no longer appears when typing "in:" in search.\n\nRoot cause: PR #83138 introduced logic that auto-forces type=CHAT when an
in:filter is present without an explicittype:. This correctly handles completedin:filters, but also triggers when the user typedin:with no value (autocomplete mode), suppressing onboarding suggestions.\n\nFix: Added a check ensuringin:filter has a non-empty value before forcing type=CHAT.\n\nFile: src/libs/SearchQueryUtils.ts