perf: Defer EditableCell interactivity by jmusial · Pull Request #91034 · Expensify/App

jmusial · 2026-05-19T06:01:35Z

Explanation of Change

This PR defers rendering of EditableCells PressableWithFeedback tree. This avoids mounting the expensive Tooltip / Hoverable / BoundsObserver subtree during the initial skeleton render, unblocking the main thread so the network response can be processed sooner.

Perf gains

Each run = 3 navigations: #1 is the first (cold) navigate, #2–#3 are repeat navigations to the already-mounted screen.

Branch: `deferred`

Run	First load (ms)	2nd nav (ms)	3rd nav (ms)
1	3194	73	69
2	3174	72	70
3	3127	73	71
4	3220	74	74
5	3150	71	71
Avg	3173	72.6	71.0

Branch: `main`

Run	First load (ms)	2nd nav (ms)	3rd nav (ms)
1	3456	72	72
2	3523	77	74
3	3485	71	73
4	3522	70	70
5	3517	72	71
Avg	3500.6	72.4	72.0

Summary

Metric	main avg	deferred avg	Δ (deferred − main)	Δ %
First load	3500.6	3173.0	−327.6 ms	−9.4%
Consecutive nav (2nd+3rd combined)	72.2	71.8	−0.4 ms	−0.6%

Takeaway: deferred is ~330 ms (~9%) faster on the cold/first navigation to Reports. Subsequent navigations are effectively identical between the two branches (~72 ms), as expected — the screen is already mounted, so deferral has nothing left to defer.

Fixed Issues

$ #91037
PROPOSAL:

Tests

Note: This change only affects web release.

Start @ Home
Navigate to Spend
Verify that an editable cell can be edited

Offline tests

Note: This change only affects web release.

Same as tests

QA Steps

Note: This change only affects web release.

Same as tests

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2026-05-19.at.08.00.29.mov

jmusial · 2026-05-19T06:01:45Z

@codex review

codecov · 2026-05-19T06:10:39Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...s/TransactionItemRow/EditableCell/EditableCell.tsx	`50.00% <50.00%> (+1.85%)`	⬆️
... and 16 files with indirect coverage changes

mountiny · 2026-05-19T07:14:17Z

@codex review

Copilot

Pull request overview

This PR improves first-load performance for editable transaction/report cells by deferring the expensive interactive pressable subtree until after the initial render.

Changes:

Adds useDeferredValue(true, false) to gate initial interactivity.
Renders the existing non-interactive layout fallback while interactivity is deferred.
Updates comments to explain the performance motivation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4c03d6e948

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-19T07:17:28Z

+    if (!canEdit || !isInteractive) {
        return <View style={[styles.editableCell]}>{children}</View>;


Keep deferred cells from falling through to row press

On wide search rows these cells are nested inside TransactionListItemWide's row-level PressableWithFeedback, so while useDeferredValue(true, false) is still false this plain View has no handler to consume the click. A user who clicks a visible editable cell immediately after the row renders can therefore trigger the parent row press/select navigation instead of editing the cell until the deferred render commits, which is a regression from always mounting the inner pressable when canEdit is true.

Useful? React with 👍 / 👎.

I think this is an acceptable tradeoff for the screen loading faster.

melvin-bot · 2026-05-19T07:37:01Z

@mountiny Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

linhvovan29546 · 2026-05-19T08:43:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

telegram-cloud-document-5-6080074468653277064.mp4

Android: mWeb Chrome

iOS: HybridApp

Screen.Recording.2026-05-19.at.16.04.31.mov

iOS: mWeb Safari

Screen.Recording.2026-05-19.at.15.55.14.mov

MacOS: Chrome / Safari

Screen.Recording.2026-05-19.at.15.51.23.mov

linhvovan29546 · 2026-05-19T09:02:59Z

@jmusial The change only affects web. Could you please mention that in the QA steps?

github-actions · 2026-05-19T09:16:32Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-19T09:20:59Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #91034.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-e68594a-d67ad90-17a90a8f2b780d74e698d7cf41df4c9badc6e656/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-e68594a-d67ad90-db02880e9b3b80afd1a66b1d653371cd81177201/index.html

Web 🕸️
https://91034.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-19T09:26:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-19T22:08:40Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.78-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-19T22:13:40Z

No help site changes are required for this PR.

This is a purely internal performance optimization that defers mounting the PressableWithFeedback / Tooltip / Hoverable subtree in EditableCell during initial render. It doesn't change any user-facing behavior, features, settings, navigation paths, or UI labels — it just makes the existing Spend view load ~330ms faster on first navigation.

OSBotify · 2026-05-21T21:26:47Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.78-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Defer EditableCell

4c03d6e

melvin-bot Bot assigned jmusial May 19, 2026

mountiny mentioned this pull request May 19, 2026

[Due for payment 2026-05-28] perf: Defer EditableCell interactivity #91037

Closed

mountiny requested a review from Copilot May 19, 2026 07:14

Copilot started reviewing on behalf of mountiny May 19, 2026 07:15 View session

Copilot AI reviewed May 19, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed May 19, 2026

View reviewed changes

mountiny requested a review from linhvovan29546 May 19, 2026 07:36

jmusial marked this pull request as ready for review May 19, 2026 07:36

jmusial requested review from a team as code owners May 19, 2026 07:36

melvin-bot Bot requested review from heyjennahay and mountiny and removed request for a team May 19, 2026 07:36

melvin-bot Bot removed the request for review from a team May 19, 2026 07:37

linhvovan29546 approved these changes May 19, 2026

View reviewed changes

mountiny approved these changes May 19, 2026

View reviewed changes

mountiny merged commit e68594a into Expensify:main May 19, 2026
64 of 66 checks passed

OSBotify mentioned this pull request May 19, 2026

Deploy Checklist: New Expensify 2026-05-19 #91122

Closed

39 tasks

		if (!canEdit \|\| !isInteractive) {
		return <View style={[styles.editableCell]}>{children}</View>;

Conversation

jmusial commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Perf gains

Branch: deferred

Branch: main

Summary

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

jmusial commented May 19, 2026

Uh oh!

codecov Bot commented May 19, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mountiny commented May 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 19, 2026

Choose a reason for hiding this comment

Uh oh!

jmusial May 19, 2026

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented May 19, 2026

Uh oh!

linhvovan29546 commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

linhvovan29546 commented May 19, 2026

Uh oh!

Uh oh!

github-actions Bot commented May 19, 2026

Uh oh!

github-actions Bot commented May 19, 2026

Uh oh!

OSBotify commented May 19, 2026

Uh oh!

OSBotify commented May 19, 2026

Uh oh!

MelvinBot commented May 19, 2026

Uh oh!

OSBotify commented May 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jmusial commented May 19, 2026 •

edited

Loading

Branch: `deferred`

Branch: `main`

codecov Bot commented May 19, 2026 •

edited by github-actions Bot

Loading

linhvovan29546 commented May 19, 2026 •

edited

Loading