[No QA] Fix Help preview PR comments#91103
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. |
This comment has been minimized.
This comment has been minimized.
|
@chiragsalian Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This comment has been minimized.
This comment has been minimized.
|
Your New Help changes have been deployed to https://5c9d213d.newhelp.pages.dev ⚡️ |
|
A preview of your ExpensifyHelp changes have been deployed to https://d623b929.helpdot.pages.dev ⚡️ |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚀Deployed to NewHelp production! 🚀 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.3.78-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.78-1 🚀
|

Explanation of Change
Replaces the blocked
actions-cool/maintain-one-commentaction in the Help deploy workflows by reusing the existingpostTestBuildCommentaction. The action now accepts a requiredCOMMENT_PREFIX, hides the previous matching comment as outdated, and posts a fresh preview comment, matching the ad-hoc build comment pattern.Fixed Issues
Fixes broken help site deploys
Tests
git diff --checktests/unit/postTestBuildComment.tsfor the requiredCOMMENT_PREFIXinputOffline tests
N/A, workflow-only change.
QA Steps
N/A, workflow-only change.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.