Manual tab shows scan confirm page after uploading receipt on Scan and returning to Manual by dukenv0307 · Pull Request #91218 · Expensify/App

dukenv0307 · 2026-05-20T17:07:41Z

Explanation of Change

RCA

When entering "+ → Create expense" from a workspace chat with the new manual flow beta, the Manual tab embeds IOURequestStepConfirmation. After uploading a receipt on the Scan tab and returning to Manual, our cleanup (initMoneyRequest on tab switch) correctly wipes the draft — but IOURequestStepConfirmation's auto-assign useEffect (IOURequestStepConfirmation.tsx:354-368) immediately re-fires because the fresh transaction has no participants. That re-fire triggers a cascade of sibling useEffects (ExpenseDefaultsSetter writes billable/reimbursable, and the Scan-tab hooks still mounted in the background re-write receipt and participantsAutoAssigned), restoring the entire 15-key Scan state on top of our cleanup. Legacy doesn't hit this because the Manual tab is IOURequestStepAmount, which has none of those side-effect children.

Solution

Seed the freshly-rebuilt transaction with participants up-front so the auto-assign effect short-circuits:

Fixed Issues

$ #90652
#90648
PROPOSAL:

Tests

Precondition:

Run Onyx.merge('betas', ['newManualExpenseFlow']); in console.

Go to staging.new.expensify.com
Go to workspace chat.
Click + > Create expense > Scan.
Upload a receipt.
Click RHP back button.
Go to Manual tab.
Verify that manual tab will not show scan confirm page.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-05-21.at.00.07.22.mov

…d returning to Manual

melvin-bot · 2026-05-20T17:08:22Z

@ChavdaSachin Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-05-20T17:23:09Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/actions/IOU/MoneyRequest.ts	`67.54% <100.00%> (+0.12%)`	⬆️
src/pages/iou/request/IOURequestStartPage.tsx	`85.04% <100.00%> (ø)`
src/hooks/useResetIOUType.ts	`91.89% <66.66%> (-4.89%)`	⬇️
... and 5 files with indirect coverage changes

trjExpensify

Nice one, one down! ❤️

ChavdaSachin · 2026-05-25T15:18:02Z

@dukenv0307, the infinite loading bug is still reproducible.

FAB -> create expense -> scan -> close the RHP.
FAB -> create expense -> click Manual.
Notice infinite loading.

And one more severe bug.

FAB -> PerDiem/time.
Select a workspace.
Go back.
Select the Manual tab.
Notice the app is crashing.

Video

Screen.Recording.2026-05-25.at.8.43.28.PM.mov

ChavdaSachin · 2026-05-25T15:19:13Z

@dukenv0307, for the solution, I'd say we gotta add some sort of mechanism to completely reset the transaction draft as soon as the tab is changed.

dukenv0307 · 2026-05-25T15:56:25Z

for the solution, I'd say we gotta add some sort of mechanism to completely reset the transaction draft as soon as the tab is changed.

@ChavdaSachin Actually, initMoneyRequest is triggered in this case that will clear the transaction draft data. Is #90652 fixed?

ChavdaSachin · 2026-05-25T16:01:11Z

Yes #90652 was fixed

dukenv0307 · 2026-05-25T16:05:02Z

@ChavdaSachin I explained the RCA and solution in the PR description, could you please take a look? If it makes sense to you, we can merge this PR to fix #90652 first.

I thought it had the same RCA as #90648, but I was wrong. I'll dig deeply to find the RCA soon

thelullabyy · 2026-05-27T19:40:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-06-02.at.00.11.45.mov

Android: mWeb Chrome

Screen.Recording.2026-06-02.at.00.09.38.mov

iOS: HybridApp

Screen.Recording.2026-06-02.at.00.07.26.mov

iOS: mWeb Safari

Screen.Recording.2026-06-02.at.00.01.02.mov

MacOS: Chrome / Safari

Screen.Recording.2026-06-01.at.23.56.28.mov

truph01 · 2026-05-29T02:35:13Z

@trjExpensify trjExpensify requested a review from truph01 2 hours ago

@trjExpensify I noticed that you assigned me to review this PR. Was that intentional, or was it assigned by accident?

trjExpensify · 2026-05-29T02:36:27Z

No, my bad. I meant to assign @thelullabyy.

dukenv0307 · 2026-06-01T02:54:43Z

@thelullabyy any updates?

trjExpensify · 2026-06-01T15:15:19Z

Bump, @thelullabyy.

thelullabyy · 2026-06-01T16:29:03Z

@trjExpensify Checking now

thelullabyy

LGTM

dukenv0307 · 2026-06-03T07:22:56Z

@JS00001 can you please review this PR?

github-actions · 2026-06-03T12:12:26Z

🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-03T12:18:31Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #91218.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-4bc4ef9f65e-f63b6dc-73f51fa74d38f48d09f4696187e49c50eb8646ac/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-4bc4ef9-f63b6dc-61d68e96c8b797137377b69bbdda4f5d2e1a4d13/index.html

Web 🕸️
https://91218.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-03T12:20:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-06-03T13:03:36Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.98-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-03T13:06:03Z

🤖 No help site changes required.

I reviewed the changes in this PR against the help site files under App/docs/articles and no documentation updates are needed.

Why no docs changes are needed

What this PR does: It's an internal bug fix for the new manual expense flow (gated behind the NEW_MANUAL_EXPENSE_FLOW beta). When a user uploads a receipt on the Scan tab, hits back, then switches to the Manual tab, the embedded confirmation's auto-assign useEffect was re-firing and dragging stale Scan-tab state back in — causing the Manual tab to incorrectly show the scan confirm page. The fix seeds the freshly-rebuilt transaction with participants so that effect short-circuits.

Changed files are all internal state/logic — no user-facing copy, labels, tabs, or settings:

src/hooks/useResetIOUType.ts
src/libs/actions/IOU/MoneyRequest.ts
src/pages/iou/request/IOURequestStartPage.tsx

Why docs are unaffected:

This restores expected behavior rather than changing a documented workflow. The relevant help article, Create an Expense, documents the correct happy-path flow for the Scan and Manual tabs — it never described the buggy state, so nothing there is now inaccurate.
The change is behind a beta flag and not generally available, so it's not yet reflected in customer-facing docs.
No feature names, tab names, settings labels, or buttons were added or renamed.

@dukenv0307, no help site PR was created because no documentation changes are required. Please let me know if you believe a docs update is warranted and I'll reassess.

jponikarchuk · 2026-06-03T13:41:30Z

Deploy Blocker #92508 was identified to be related to this PR.

OSBotify · 2026-06-04T07:25:57Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.98-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Manual tab shows scan confirm page after uploading receipt on Scan an…

9b02c12

…d returning to Manual

melvin-bot Bot assigned dukenv0307 May 20, 2026

dukenv0307 marked this pull request as ready for review May 20, 2026 17:08

dukenv0307 requested review from a team as code owners May 20, 2026 17:08

melvin-bot Bot requested a review from ChavdaSachin May 20, 2026 17:08

melvin-bot Bot requested review from trjExpensify and removed request for a team May 20, 2026 17:08

trjExpensify previously approved these changes May 21, 2026

View reviewed changes

dukenv0307 mentioned this pull request May 21, 2026

Expense - Confirm page loads infinitely after switching from Scan to Manual tab #90648

Closed

7 tasks

trjExpensify requested a review from truph01 May 29, 2026 00:06

trjExpensify requested review from thelullabyy and removed request for truph01 May 29, 2026 02:36

thelullabyy approved these changes Jun 1, 2026

View reviewed changes

melvin-bot Bot requested a review from puneetlath June 1, 2026 17:11

merge main

2a38305

dukenv0307 dismissed trjExpensify’s stale review via 2a38305 June 2, 2026 04:13

Merge branch 'main' into fix/90652

cd2d021

JS00001 approved these changes Jun 3, 2026

View reviewed changes

JS00001 merged commit 4bc4ef9 into Expensify:main Jun 3, 2026
32 checks passed

OSBotify mentioned this pull request Jun 3, 2026

Deploy Checklist: New Expensify 2026-06-03 #92500

Closed

20 tasks

applause-bot Bot mentioned this pull request Jun 3, 2026

[Due for payment 2026-06-16] Expense - App freezes and becomes unresponsive after switching from Scan to Manual tab #92508

Closed

7 tasks

jponikarchuk mentioned this pull request Jun 3, 2026

[Due for payment 2026-06-11] Manual tab shows scan confirm page after uploading receipt on Scan and returning to Manual #90652

Closed

7 tasks

dukenv0307 mentioned this pull request Jun 3, 2026

Revert "Manual tab shows scan confirm page after uploading receipt on Scan and returning to Manual" #92542

Closed

Conversation

dukenv0307 commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 20, 2026

Uh oh!

codecov Bot commented May 20, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

ChavdaSachin commented May 25, 2026

Uh oh!

ChavdaSachin commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dukenv0307 commented May 25, 2026

Uh oh!

ChavdaSachin commented May 25, 2026

Uh oh!

dukenv0307 commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thelullabyy commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

truph01 commented May 29, 2026

Uh oh!

trjExpensify commented May 29, 2026

Uh oh!

dukenv0307 commented Jun 1, 2026

Uh oh!

trjExpensify commented Jun 1, 2026

Uh oh!

thelullabyy commented Jun 1, 2026

Uh oh!

thelullabyy left a comment

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Jun 3, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 3, 2026

Uh oh!

github-actions Bot commented Jun 3, 2026

Uh oh!

OSBotify commented Jun 3, 2026

Uh oh!

OSBotify commented Jun 3, 2026

Uh oh!

MelvinBot commented Jun 3, 2026

Uh oh!

jponikarchuk commented Jun 3, 2026 • edited by mallenexpensify Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Jun 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

dukenv0307 commented May 20, 2026 •

edited

Loading

codecov Bot commented May 20, 2026 •

edited by github-actions Bot

Loading

ChavdaSachin commented May 25, 2026 •

edited

Loading

dukenv0307 commented May 25, 2026 •

edited

Loading

thelullabyy commented May 27, 2026 •

edited

Loading

jponikarchuk commented Jun 3, 2026 •

edited by mallenexpensify

Loading