Skip to content

Implement read-only access to workspace pages#91305

Merged
flodnv merged 31 commits into
Expensify:mainfrom
ShridharGoel:ws1.2
Jun 1, 2026
Merged

Implement read-only access to workspace pages#91305
flodnv merged 31 commits into
Expensify:mainfrom
ShridharGoel:ws1.2

Conversation

@ShridharGoel

@ShridharGoel ShridharGoel commented May 21, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

This adds the frontend support for workspace scoped roles.

Auditors can now open workspace pages they have read access to, including direct links. The workspace menu checks feature read permissions before showing each item. Page access wrappers use the new policy feature read check instead of requiring full admin access when a page passes policyFeature.

This also allows read-only access by disabling or hiding write-only controls on the More Features, Expensify Card, and Company Cards top-level pages.

Fixed Issues

$ #90497, #90498
PROPOSAL:

Tests

  1. Log in with account A that is an admin on a workspace.
  2. Go to Workspaces and open the workspace.
  3. Verify the workspace menu still shows the expected enabled sections for an admin.
  4. Open these workspace pages and verify they still load: Overview, Members, More Features, Reports, Accounting, Categories, Tags, Taxes, Workflows, Rules, Distance Rates, Per Diem, Expensify Card, and Company Cards.
  5. Verify admin-only actions still work where available, such as toggling a More Features switch and opening card settings.
  6. Make account B as an auditor of the workspace.
  7. Verify the Auditor can see the workspace menu items for enabled read-access sections.
  8. Open the read-access pages from the menu and verify they load properly.
  9. Open direct links to read-access workspace pages and verify they load properly.
  10. Verify the Auditor cannot make changes: More Features switches are disabled, Expensify Card issue/settings actions are hidden, and Company Cards assign/settings actions are disabled or hidden.
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-05-22.at.1.28.50.AM.mov

@melvin-bot

melvin-bot Bot commented May 21, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@ShridharGoel ShridharGoel changed the title Add auditor read access to workspace pages Implement read-only access to workspace pages May 21, 2026
@ShridharGoel ShridharGoel marked this pull request as ready for review May 21, 2026 20:02
@ShridharGoel ShridharGoel requested review from a team as code owners May 21, 2026 20:02
@melvin-bot melvin-bot Bot requested review from Pujan92 and flaviadefaria and removed request for a team May 21, 2026 20:02
@melvin-bot

melvin-bot Bot commented May 21, 2026

Copy link
Copy Markdown

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Comment thread src/pages/workspace/categories/WorkspaceCategoriesPage.tsx Outdated
Comment thread src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx Outdated
Comment thread src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx Outdated
Comment thread src/pages/workspace/taxes/WorkspaceTaxesPage.tsx Outdated
Comment thread src/pages/workspace/tags/WorkspaceTagsPage.tsx Outdated
Comment thread src/pages/workspace/tags/WorkspaceViewTagsPage.tsx Outdated
Comment thread src/pages/workspace/reports/WorkspaceReportsPage.tsx Outdated
Comment thread src/pages/workspace/receiptPartners/WorkspaceReceiptPartnersPage.tsx Outdated
Comment thread src/pages/workspace/travel/BookOrManageYourTrip.tsx Outdated
@ShridharGoel

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3bddbc9abf

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/pages/workspace/accounting/PolicyAccountingPage.tsx
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

🚧 @flodnv has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/flodnv in version: 9.3.91-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

Help site review for this PR

Yes — a help site update is needed. This PR expands the Auditor role from "view and comment on reports" to also viewing workspace settings pages in read-only mode (Overview, Members, More features, Categories, Tags, Taxes, Expensify Card, Company cards, etc.), with write actions hidden or disabled. The new in-product copy is "Your workspace role can view these settings, but can't edit them."

The existing article Managing-Workspace-Members.md only described the Auditor as able to view/comment on reports, so its role description is now incomplete.

Draft help site PR: #92315

What the docs PR changes
  • Expands the Auditor role bullet to note read-only access to workspace settings (Control plan only).
  • Adds an FAQ entry: "What can an Auditor view in a workspace?"

All UI labels were verified against src/languages/en.ts and use the exact sentence-case product labels (e.g. More features, Company cards, Distance rates, Per diem, Expensify Card). The change follows docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md.


@ShridharGoel, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #92320 was identified to be related to this PR.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #92322 was identified to be related to this PR.

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #92324 was identified to be related to this PR.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #92325 was identified to be related to this PR.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #92328 was identified to be related to this PR.

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #92336 was identified to be related to this PR.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #92335 was identified to be related to this PR.

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #92354 was identified to be related to this PR.

@OSBotify

OSBotify commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/flodnv in version: 9.3.94-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Docs review complete — changes required, draft PR already exists

Yes, this PR requires a help site update. It expands the Auditor role: auditors can now open and view workspace settings pages (Overview, Members, More features, Categories, Tags, Taxes, Expensify Card, Company cards, and others they have read access to) in read-only mode, with write controls disabled or hidden. The existing article described Auditors only as able to "view and comment on reports," which is now incomplete.

A draft docs PR already covers this update: #92315

What it changes (docs/articles/new-expensify/workspaces/Managing-Workspace-Members.md):

  • Expands the Auditor role description to include read-only access to workspace settings (Control plan only).
  • Adds an FAQ entry: "What can an Auditor view in a workspace?"

All UI labels were verified against src/languages/en.ts and use the exact sentence-case product labels (More features, Company cards, Distance rates, Per diem, Expensify Card, Overview). The change follows HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, and TEMPLATE.md.

I did not open a new PR since the existing one already covers the required changes, has the HelpDot label, and is assigned to you.

@ShridharGoel, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

@OSBotify

OSBotify commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.94-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants